From: Manfred Spraul <manfred@colorfullife.com>
To: Yinghai Lu <yhlu.kernel@gmail.com>
Cc: Jeff Garzik <jgarzik@pobox.com>,
Ayaz Abdulla <aabdulla@nvidia.com>,
nedev <netdev@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
David Miller <davem@davemloft.net>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: MSI interrupts and disable_irq
Date: Wed, 17 Oct 2007 21:43:19 +0200 [thread overview]
Message-ID: <471665D7.5020607@colorfullife.com> (raw)
In-Reply-To: <86802c440710161101o34a1b982w95c7473f0ec744ed@mail.gmail.com>
Yinghai Lu wrote:
>>
>> Correct, but the overall point was that MSI-X conceptually conflicts
>> with the existing "lockless" disable_irq() schedule, which was written
>> when there was a one-one relationship between irq, PCI device, and work
>> to be done.
>>
>
> at this point, nic in mcp55 is using msi or INTx.
>
>
Correct.
For msi-x, the driver does three disable_irq() calls to the correct
vectors. ugly, but nevertheless correct.
The bug only affected msi: The driver did disable_irq(<old INTx irq
num>) instead of disable_irq(<new msi-x irq num>).
The patch that I've attached to the bugzilla report 9047 seems to fix
the crash, thus I would propose to apply it to 2.6.23 and 2.6.24. I'll
send a seperate mail.
All other problem [reduce code duplication, less ugly locking, ...]
should be fixed with independant patches.
--
Manfred
> YH
>
next prev parent reply other threads:[~2007-10-17 19:44 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-27 20:42 MSI interrupts and disable_irq Ayaz Abdulla
2007-09-29 2:47 ` Jeff Garzik
2007-09-29 3:08 ` Stephen Hemminger
2007-10-05 22:12 ` Eric W. Biederman
2007-10-06 6:23 ` Yinghai Lu
2007-10-06 17:43 ` Yinghai Lu
2007-10-06 17:59 ` Jeff Garzik
2007-10-07 16:54 ` Manfred Spraul
2007-10-13 9:30 ` Manfred Spraul
2007-10-14 5:59 ` Yinghai Lu
2007-10-14 7:15 ` Manfred Spraul
2007-10-14 19:55 ` Yinghai Lu
2007-10-14 21:47 ` Benjamin Herrenschmidt
2007-10-14 23:15 ` Yinghai Lu
2007-10-14 23:36 ` Benjamin Herrenschmidt
2007-10-15 22:17 ` Jeff Garzik
2007-10-16 17:23 ` Yinghai Lu
2007-10-16 17:39 ` Jeff Garzik
2007-10-16 17:59 ` Yinghai Lu
2007-10-16 19:44 ` Jeff Garzik
2007-10-16 18:01 ` Yinghai Lu
2007-10-17 19:43 ` Manfred Spraul [this message]
2007-10-02 19:03 ` Manfred Spraul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=471665D7.5020607@colorfullife.com \
--to=manfred@colorfullife.com \
--cc=aabdulla@nvidia.com \
--cc=akpm@linux-foundation.org \
--cc=davem@davemloft.net \
--cc=jgarzik@pobox.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=yhlu.kernel@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.