All of lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Zijlstra <peterz@infradead.org>
To: linux-kernel <linux-kernel@vger.kernel.org>,
	linux-mm <linux-mm@kvack.org>
Cc: hugh <hugh@veritas.com>, Nick Piggin <npiggin@suse.de>,
	riel <riel@redhat.com>, Lennart Poettering <mztabzr@0pointer.de>
Subject: [rfc][patch] mm: madvise(WILLNEED) for anonymous memory
Date: Thu, 20 Dec 2007 14:05:38 +0100	[thread overview]
Message-ID: <1198155938.6821.3.camel@twins> (raw)

Hi,

Lennart asked for madvise(WILLNEED) to work on anonymous pages, he plans
to use this to pre-fault pages. He currently uses: mlock/munlock for
this purpose.

[ compile tested only ]

Signed-off-by: Peter Zijlstra <a.p.zijlstra@chello.nl>
---
diff --git a/mm/madvise.c b/mm/madvise.c
index 93ee375..eff60ce 100644
--- a/mm/madvise.c
+++ b/mm/madvise.c
@@ -100,6 +100,24 @@ out:
 	return error;
 }
 
+static long madvice_willneed_anon(struct vm_area_struct *vma,
+				  struct vm_area_struct **prev,
+				  unsigned long start, unsigned long end)
+{
+	int ret, len;
+
+	*prev = vma;
+	if (end > vma->vm_end)
+		end = vma->vm_end;
+
+	len = end - start;
+	ret = get_user_pages(current, current->mm, start, len,
+			0, 0, NULL, NULL);
+	if (ret < 0)
+		return ret;
+	return ret == len ? 0 : -1;
+}
+
 /*
  * Schedule all required I/O operations.  Do not wait for completion.
  */
@@ -110,7 +128,7 @@ static long madvise_willneed(struct vm_area_struct * vma,
 	struct file *file = vma->vm_file;
 
 	if (!file)
-		return -EBADF;
+		return madvice_willneed_anon(vma, prev, start, end);
 
 	if (file->f_mapping->a_ops->get_xip_page) {
 		/* no bad return value, but ignore advice */



WARNING: multiple messages have this Message-ID (diff)
From: Peter Zijlstra <peterz@infradead.org>
To: linux-kernel <linux-kernel@vger.kernel.org>,
	linux-mm <linux-mm@kvack.org>
Cc: hugh <hugh@veritas.com>, Nick Piggin <npiggin@suse.de>,
	riel <riel@redhat.com>, Lennart Poettering <mztabzr@0pointer.de>
Subject: [rfc][patch] mm: madvise(WILLNEED) for anonymous memory
Date: Thu, 20 Dec 2007 14:05:38 +0100	[thread overview]
Message-ID: <1198155938.6821.3.camel@twins> (raw)

Hi,

Lennart asked for madvise(WILLNEED) to work on anonymous pages, he plans
to use this to pre-fault pages. He currently uses: mlock/munlock for
this purpose.

[ compile tested only ]

Signed-off-by: Peter Zijlstra <a.p.zijlstra@chello.nl>
---
diff --git a/mm/madvise.c b/mm/madvise.c
index 93ee375..eff60ce 100644
--- a/mm/madvise.c
+++ b/mm/madvise.c
@@ -100,6 +100,24 @@ out:
 	return error;
 }
 
+static long madvice_willneed_anon(struct vm_area_struct *vma,
+				  struct vm_area_struct **prev,
+				  unsigned long start, unsigned long end)
+{
+	int ret, len;
+
+	*prev = vma;
+	if (end > vma->vm_end)
+		end = vma->vm_end;
+
+	len = end - start;
+	ret = get_user_pages(current, current->mm, start, len,
+			0, 0, NULL, NULL);
+	if (ret < 0)
+		return ret;
+	return ret == len ? 0 : -1;
+}
+
 /*
  * Schedule all required I/O operations.  Do not wait for completion.
  */
@@ -110,7 +128,7 @@ static long madvise_willneed(struct vm_area_struct * vma,
 	struct file *file = vma->vm_file;
 
 	if (!file)
-		return -EBADF;
+		return madvice_willneed_anon(vma, prev, start, end);
 
 	if (file->f_mapping->a_ops->get_xip_page) {
 		/* no bad return value, but ignore advice */


--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

             reply	other threads:[~2007-12-20 13:06 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-12-20 13:05 Peter Zijlstra [this message]
2007-12-20 13:05 ` [rfc][patch] mm: madvise(WILLNEED) for anonymous memory Peter Zijlstra
2007-12-20 14:09 ` Hugh Dickins
2007-12-20 14:09   ` Hugh Dickins
2007-12-20 14:47   ` Peter Zijlstra
2007-12-20 14:47     ` Peter Zijlstra
2007-12-20 14:56     ` Peter Zijlstra
2007-12-20 14:56       ` Peter Zijlstra
2007-12-20 15:18       ` Peter Zijlstra
2007-12-20 15:18         ` Peter Zijlstra
2007-12-20 15:23         ` Peter Zijlstra
2007-12-20 15:23           ` Peter Zijlstra
2007-12-20 15:26     ` Hugh Dickins
2007-12-20 15:26       ` Hugh Dickins
2007-12-20 16:53       ` Peter Zijlstra
2007-12-20 16:53         ` Peter Zijlstra
2007-12-20 17:11         ` Matt Mackall
2007-12-20 17:11           ` Matt Mackall
2007-12-20 17:15           ` Peter Zijlstra
2007-12-20 17:15             ` Peter Zijlstra
2007-12-20 16:29   ` Lennart Poettering
2007-12-20 16:29     ` Lennart Poettering

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1198155938.6821.3.camel@twins \
    --to=peterz@infradead.org \
    --cc=hugh@veritas.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mztabzr@0pointer.de \
    --cc=npiggin@suse.de \
    --cc=riel@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.