All of lore.kernel.org
 help / color / mirror / Atom feed
From: Michael Opdenacker <michael.opdenacker@rootcommit.com>
To: Joshua Milas <josh.milas@gmail.com>,
	tglx@kernel.org, robh@kernel.org, krzk+dt@kernel.org,
	conor+dt@kernel.org, pjw@kernel.org, samuel.holland@sifive.com,
	unicorn_wang@outlook.com, inochiama@gmail.com,
	daniel.lezcano@linaro.org, palmer@dabbelt.com,
	aou@eecs.berkeley.edu, alex@ghiti.fr,
	liujingqi@lanxincomputing.com, alexander.sverdlin@gmail.com,
	rabenda.cn@gmail.com, dlan@kernel.org, chao.wei@sophgo.com,
	anup@brainfault.org
Cc: michael.opdenacker@rootcommit.com, linux-kernel@vger.kernel.org,
	devicetree@vger.kernel.org, linux-riscv@lists.infradead.org,
	sophgo@lists.linux.dev, hanguidong02@gmail.com
Subject: Re: [PATCH v4 2/5] arm64: dts: sophgo: add initial Milk-V Duo S board support
Date: Sun, 29 Mar 2026 20:21:30 +0000 (UTC)	[thread overview]
Message-ID: <11e7fcc9-c8dd-4bf5-a600-3d130407bb82@rootcommit.com> (raw)
In-Reply-To: <20260328173450.219664-3-josh.milas@gmail.com>

Hi Joshua

Thanks a lot for this new update!

On 3/28/26 6:34 PM, Joshua Milas wrote:
> Adds initial arm64 support for the Milk-V Duo S board
> [1] making it possible to boot Linux to the command line.
>
> Link: https://milkv.io/duo-s [1]
>
> Signed-off-by: Joshua Milas <josh.milas@gmail.com>
...
> diff --git a/arch/arm64/boot/dts/sophgo/sg2000-milkv-duo-s.dts b/arch/arm64/boot/dts/sophgo/sg2000-milkv-duo-s.dts
> new file mode 100644
> index 0000000000000..4ae44b40f9edb
> --- /dev/null
> +++ b/arch/arm64/boot/dts/sophgo/sg2000-milkv-duo-s.dts
...
> +
> +&usb {
> +       dr_mode = "host";
> +       status = "okay";
> +};


You have a small checkpatch.pl issue here:

./scripts/checkpatch.pl *.patch
...
WARNING: please, no spaces at the start of a line
#120: FILE: arch/riscv/boot/dts/sophgo/sg2000-milkv-duo-s.dts:82:
+       dr_mode = "host";$

WARNING: please, no spaces at the start of a line
#121: FILE: arch/riscv/boot/dts/sophgo/sg2000-milkv-duo-s.dts:83:
+       status = "okay";$

Replace the spaces by a tab as in the other entries in the DTS and you 
should be fine.
Thanks again
Cheers
Michael.

-- 
Root Commit
Embedded Linux Training and Consulting
https://rootcommit.com


WARNING: multiple messages have this Message-ID (diff)
From: Michael Opdenacker <michael.opdenacker@rootcommit.com>
To: Joshua Milas <josh.milas@gmail.com>,
	tglx@kernel.org, robh@kernel.org, krzk+dt@kernel.org,
	conor+dt@kernel.org, pjw@kernel.org, samuel.holland@sifive.com,
	unicorn_wang@outlook.com, inochiama@gmail.com,
	daniel.lezcano@linaro.org, palmer@dabbelt.com,
	aou@eecs.berkeley.edu, alex@ghiti.fr,
	liujingqi@lanxincomputing.com, alexander.sverdlin@gmail.com,
	rabenda.cn@gmail.com, dlan@kernel.org, chao.wei@sophgo.com,
	anup@brainfault.org
Cc: michael.opdenacker@rootcommit.com, linux-kernel@vger.kernel.org,
	devicetree@vger.kernel.org, linux-riscv@lists.infradead.org,
	sophgo@lists.linux.dev, hanguidong02@gmail.com
Subject: Re: [PATCH v4 2/5] arm64: dts: sophgo: add initial Milk-V Duo S board support
Date: Sun, 29 Mar 2026 20:21:30 +0000 (UTC)	[thread overview]
Message-ID: <11e7fcc9-c8dd-4bf5-a600-3d130407bb82@rootcommit.com> (raw)
In-Reply-To: <20260328173450.219664-3-josh.milas@gmail.com>

Hi Joshua

Thanks a lot for this new update!

On 3/28/26 6:34 PM, Joshua Milas wrote:
> Adds initial arm64 support for the Milk-V Duo S board
> [1] making it possible to boot Linux to the command line.
>
> Link: https://milkv.io/duo-s [1]
>
> Signed-off-by: Joshua Milas <josh.milas@gmail.com>
...
> diff --git a/arch/arm64/boot/dts/sophgo/sg2000-milkv-duo-s.dts b/arch/arm64/boot/dts/sophgo/sg2000-milkv-duo-s.dts
> new file mode 100644
> index 0000000000000..4ae44b40f9edb
> --- /dev/null
> +++ b/arch/arm64/boot/dts/sophgo/sg2000-milkv-duo-s.dts
...
> +
> +&usb {
> +       dr_mode = "host";
> +       status = "okay";
> +};


You have a small checkpatch.pl issue here:

./scripts/checkpatch.pl *.patch
...
WARNING: please, no spaces at the start of a line
#120: FILE: arch/riscv/boot/dts/sophgo/sg2000-milkv-duo-s.dts:82:
+       dr_mode = "host";$

WARNING: please, no spaces at the start of a line
#121: FILE: arch/riscv/boot/dts/sophgo/sg2000-milkv-duo-s.dts:83:
+       status = "okay";$

Replace the spaces by a tab as in the other entries in the DTS and you 
should be fine.
Thanks again
Cheers
Michael.

-- 
Root Commit
Embedded Linux Training and Consulting
https://rootcommit.com


_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv

  reply	other threads:[~2026-03-29 21:37 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-28 17:34 [PATCH v4 0/5] Add initial Milk-V Duo S board support Joshua Milas
2026-03-28 17:34 ` Joshua Milas
2026-03-28 17:34 ` [PATCH v4 1/5] dt-bindings: soc: sophgo: add Milk-V Duo S board compatibles Joshua Milas
2026-03-28 17:34   ` Joshua Milas
2026-03-28 17:34 ` [PATCH v4 2/5] arm64: dts: sophgo: add initial Milk-V Duo S board support Joshua Milas
2026-03-28 17:34   ` Joshua Milas
2026-03-29 20:21   ` Michael Opdenacker [this message]
2026-03-29 20:21     ` Michael Opdenacker
2026-04-02 12:14     ` Joshua Milas
2026-04-02 12:14       ` Joshua Milas
2026-03-28 17:34 ` [PATCH v4 3/5] dt-bindings: soc: sophgo: add sg2000 plic and clint documentation Joshua Milas
2026-03-28 17:34   ` Joshua Milas
2026-03-28 17:34 ` [PATCH v4 4/5] riscv64: dts: sophgo: add SG2000 dtsi Joshua Milas
2026-03-28 17:34   ` Joshua Milas
2026-03-28 17:34 ` [PATCH v4 5/5] riscv64: dts: sophgo: add initial Milk-V Duo S board support Joshua Milas
2026-03-28 17:34   ` Joshua Milas
2026-03-29 21:14 ` [PATCH v4 0/5] Add " Michael Opdenacker
2026-03-29 21:14   ` Michael Opdenacker
2026-04-02 12:29   ` Joshua Milas
2026-04-02 12:29     ` Joshua Milas
2026-04-02 13:47     ` Michael Opdenacker
2026-04-02 13:47       ` Michael Opdenacker

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=11e7fcc9-c8dd-4bf5-a600-3d130407bb82@rootcommit.com \
    --to=michael.opdenacker@rootcommit.com \
    --cc=alex@ghiti.fr \
    --cc=alexander.sverdlin@gmail.com \
    --cc=anup@brainfault.org \
    --cc=aou@eecs.berkeley.edu \
    --cc=chao.wei@sophgo.com \
    --cc=conor+dt@kernel.org \
    --cc=daniel.lezcano@linaro.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dlan@kernel.org \
    --cc=hanguidong02@gmail.com \
    --cc=inochiama@gmail.com \
    --cc=josh.milas@gmail.com \
    --cc=krzk+dt@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-riscv@lists.infradead.org \
    --cc=liujingqi@lanxincomputing.com \
    --cc=palmer@dabbelt.com \
    --cc=pjw@kernel.org \
    --cc=rabenda.cn@gmail.com \
    --cc=robh@kernel.org \
    --cc=samuel.holland@sifive.com \
    --cc=sophgo@lists.linux.dev \
    --cc=tglx@kernel.org \
    --cc=unicorn_wang@outlook.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.