From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Andrea Arcangeli <andrea@qumranet.com>
Cc: Christoph Lameter <clameter@sgi.com>, Robin Holt <holt@sgi.com>,
Avi Kivity <avi@qumranet.com>, Izik Eidus <izike@qumranet.com>,
Nick Piggin <npiggin@suse.de>,
kvm-devel@lists.sourceforge.net,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
steiner@sgi.com, linux-kernel@vger.kernel.org,
linux-mm@kvack.org, daniel.blueman@quadrics.com,
Hugh Dickins <hugh@veritas.com>
Subject: Re: [patch 0/4] [RFC] MMU Notifiers V1
Date: Sat, 26 Jan 2008 08:18:41 +1100 [thread overview]
Message-ID: <1201295921.6815.150.camel@pasglop> (raw)
In-Reply-To: <20080125114229.GA7454@v2.random>
On Fri, 2008-01-25 at 12:42 +0100, Andrea Arcangeli wrote:
> On Thu, Jan 24, 2008 at 09:56:06PM -0800, Christoph Lameter wrote:
> > Andrea's mmu_notifier #4 -> RFC V1
> >
> > - Merge subsystem rmap based with Linux rmap based approach
> > - Move Linux rmap based notifiers out of macro
> > - Try to account for what locks are held while the notifiers are
> > called.
> > - Develop a patch sequence that separates out the different types of
> > hooks so that it is easier to review their use.
> > - Avoid adding #include to linux/mm_types.h
> > - Integrate RCU logic suggested by Peter.
>
> I'm glad you're converging on something a bit saner and much much
> closer to my code, plus perfectly usable by KVM optimal rmap design
> too. It would have preferred if you would have sent me patches like
> Peter did for review and merging etc... that would have made review
> especially easier. Anyway I'm used to that on lkml so it's ok, I just
> need this patch to be included in mainline, everything else is
> irrelevant to me.
Also, wouldn't there be a problem with something trying to use that
interface to keep in sync a secondary device MMU such as the DRM or
other accelerators, which might need virtual address based
invalidation ?
Ben.
WARNING: multiple messages have this Message-ID (diff)
From: Benjamin Herrenschmidt <benh-XVmvHMARGAS8U2dJNN8I7kB+6BGkLq7r@public.gmane.org>
To: Andrea Arcangeli <andrea-atKUWr5tajBWk0Htik3J/w@public.gmane.org>
Cc: Nick Piggin <npiggin-l3A5Bk7waGM@public.gmane.org>,
Peter Zijlstra
<a.p.zijlstra-/NLkJaSkS4VmR6Xm/wNWPw@public.gmane.org>,
linux-mm-Bw31MaZKKs3YtjvyW6yDsg@public.gmane.org,
steiner-sJ/iWh9BUns@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Avi Kivity <avi-atKUWr5tajBWk0Htik3J/w@public.gmane.org>,
kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org,
daniel.blueman-xqY44rlHlBpWk0Htik3J/w@public.gmane.org,
Robin Holt <holt-sJ/iWh9BUns@public.gmane.org>,
Hugh Dickins <hugh-DTz5qymZ9yRBDgjK7y7TUQ@public.gmane.org>,
Christoph Lameter <clameter-sJ/iWh9BUns@public.gmane.org>
Subject: Re: [patch 0/4] [RFC] MMU Notifiers V1
Date: Sat, 26 Jan 2008 08:18:41 +1100 [thread overview]
Message-ID: <1201295921.6815.150.camel@pasglop> (raw)
In-Reply-To: <20080125114229.GA7454-lysg2Xt5kKMAvxtiuMwx3w@public.gmane.org>
On Fri, 2008-01-25 at 12:42 +0100, Andrea Arcangeli wrote:
> On Thu, Jan 24, 2008 at 09:56:06PM -0800, Christoph Lameter wrote:
> > Andrea's mmu_notifier #4 -> RFC V1
> >
> > - Merge subsystem rmap based with Linux rmap based approach
> > - Move Linux rmap based notifiers out of macro
> > - Try to account for what locks are held while the notifiers are
> > called.
> > - Develop a patch sequence that separates out the different types of
> > hooks so that it is easier to review their use.
> > - Avoid adding #include to linux/mm_types.h
> > - Integrate RCU logic suggested by Peter.
>
> I'm glad you're converging on something a bit saner and much much
> closer to my code, plus perfectly usable by KVM optimal rmap design
> too. It would have preferred if you would have sent me patches like
> Peter did for review and merging etc... that would have made review
> especially easier. Anyway I'm used to that on lkml so it's ok, I just
> need this patch to be included in mainline, everything else is
> irrelevant to me.
Also, wouldn't there be a problem with something trying to use that
interface to keep in sync a secondary device MMU such as the DRM or
other accelerators, which might need virtual address based
invalidation ?
Ben.
-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
WARNING: multiple messages have this Message-ID (diff)
From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Andrea Arcangeli <andrea@qumranet.com>
Cc: Christoph Lameter <clameter@sgi.com>, Robin Holt <holt@sgi.com>,
Avi Kivity <avi@qumranet.com>, Izik Eidus <izike@qumranet.com>,
Nick Piggin <npiggin@suse.de>,
kvm-devel@lists.sourceforge.net,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
steiner@sgi.com, linux-kernel@vger.kernel.org,
linux-mm@kvack.org, daniel.blueman@quadrics.com,
Hugh Dickins <hugh@veritas.com>
Subject: Re: [patch 0/4] [RFC] MMU Notifiers V1
Date: Sat, 26 Jan 2008 08:18:41 +1100 [thread overview]
Message-ID: <1201295921.6815.150.camel@pasglop> (raw)
In-Reply-To: <20080125114229.GA7454@v2.random>
On Fri, 2008-01-25 at 12:42 +0100, Andrea Arcangeli wrote:
> On Thu, Jan 24, 2008 at 09:56:06PM -0800, Christoph Lameter wrote:
> > Andrea's mmu_notifier #4 -> RFC V1
> >
> > - Merge subsystem rmap based with Linux rmap based approach
> > - Move Linux rmap based notifiers out of macro
> > - Try to account for what locks are held while the notifiers are
> > called.
> > - Develop a patch sequence that separates out the different types of
> > hooks so that it is easier to review their use.
> > - Avoid adding #include to linux/mm_types.h
> > - Integrate RCU logic suggested by Peter.
>
> I'm glad you're converging on something a bit saner and much much
> closer to my code, plus perfectly usable by KVM optimal rmap design
> too. It would have preferred if you would have sent me patches like
> Peter did for review and merging etc... that would have made review
> especially easier. Anyway I'm used to that on lkml so it's ok, I just
> need this patch to be included in mainline, everything else is
> irrelevant to me.
Also, wouldn't there be a problem with something trying to use that
interface to keep in sync a secondary device MMU such as the DRM or
other accelerators, which might need virtual address based
invalidation ?
Ben.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2008-01-25 21:19 UTC|newest]
Thread overview: 68+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-25 5:56 [patch 0/4] [RFC] MMU Notifiers V1 Christoph Lameter
2008-01-25 5:56 ` Christoph Lameter
2008-01-25 5:56 ` [patch 1/4] mmu_notifier: Core code Christoph Lameter
2008-01-25 5:56 ` Christoph Lameter
2008-01-25 18:39 ` Robin Holt
2008-01-25 18:39 ` Robin Holt
2008-01-25 18:39 ` Robin Holt
2008-01-25 18:47 ` Christoph Lameter
2008-01-25 18:47 ` Christoph Lameter
2008-01-25 18:47 ` Christoph Lameter
2008-01-25 18:56 ` Robin Holt
2008-01-25 18:56 ` Robin Holt
2008-01-25 19:03 ` Christoph Lameter
2008-01-25 19:03 ` Christoph Lameter
2008-01-25 19:03 ` Christoph Lameter
2008-01-25 19:35 ` Robin Holt
2008-01-25 19:35 ` Robin Holt
2008-01-25 19:35 ` Robin Holt
2008-01-25 20:10 ` Christoph Lameter
2008-01-25 20:10 ` Christoph Lameter
2008-01-25 20:10 ` Christoph Lameter
2008-01-26 11:56 ` Robin Holt
2008-01-26 11:56 ` Robin Holt
2008-01-26 11:56 ` Robin Holt
2008-01-28 18:51 ` Christoph Lameter
2008-01-28 18:51 ` Christoph Lameter
2008-01-25 21:18 ` Christoph Lameter
2008-01-25 21:18 ` Christoph Lameter
2008-01-25 21:18 ` Christoph Lameter
2008-01-26 12:01 ` Robin Holt
2008-01-26 12:01 ` Robin Holt
2008-01-26 12:01 ` Robin Holt
2008-01-28 18:44 ` Christoph Lameter
2008-01-28 18:44 ` Christoph Lameter
2008-01-28 18:44 ` Christoph Lameter
2008-01-25 5:56 ` [patch 2/4] mmu_notifier: Callbacks to invalidate address ranges Christoph Lameter
2008-01-25 5:56 ` Christoph Lameter
2008-01-25 5:56 ` [patch 3/4] mmu_notifier: invalidate_page callbacks for subsystems with rmap Christoph Lameter
2008-01-25 5:56 ` Christoph Lameter
2008-01-25 5:56 ` [patch 4/4] MMU notifier: invalidate_page callbacks using Linux rmaps Christoph Lameter
2008-01-25 5:56 ` Christoph Lameter
2008-01-25 11:42 ` [patch 0/4] [RFC] MMU Notifiers V1 Andrea Arcangeli
2008-01-25 11:42 ` Andrea Arcangeli
2008-01-25 12:43 ` Robin Holt
2008-01-25 12:43 ` Robin Holt
2008-01-25 12:43 ` Robin Holt
2008-01-25 18:31 ` Christoph Lameter
2008-01-25 18:31 ` Christoph Lameter
2008-01-25 18:31 ` Christoph Lameter
2008-01-25 21:18 ` Benjamin Herrenschmidt [this message]
2008-01-25 21:18 ` Benjamin Herrenschmidt
2008-01-25 21:18 ` Benjamin Herrenschmidt
2008-01-25 21:25 ` Christoph Lameter
2008-01-25 21:25 ` Christoph Lameter
2008-01-25 21:25 ` Christoph Lameter
2008-01-28 16:10 ` Izik Eidus
2008-01-28 16:10 ` Izik Eidus
2008-01-28 16:10 ` Izik Eidus
2008-01-28 17:25 ` Andrea Arcangeli
2008-01-28 17:25 ` Andrea Arcangeli
2008-01-28 19:04 ` Christoph Lameter
2008-01-28 19:04 ` Christoph Lameter
2008-01-28 19:40 ` Andrea Arcangeli
2008-01-28 19:40 ` Andrea Arcangeli
2008-01-28 19:40 ` Andrea Arcangeli
2008-01-28 20:16 ` Christoph Lameter
2008-01-28 20:16 ` Christoph Lameter
2008-01-28 20:16 ` Christoph Lameter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1201295921.6815.150.camel@pasglop \
--to=benh@kernel.crashing.org \
--cc=a.p.zijlstra@chello.nl \
--cc=andrea@qumranet.com \
--cc=avi@qumranet.com \
--cc=clameter@sgi.com \
--cc=daniel.blueman@quadrics.com \
--cc=holt@sgi.com \
--cc=hugh@veritas.com \
--cc=izike@qumranet.com \
--cc=kvm-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=npiggin@suse.de \
--cc=steiner@sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.