All of lore.kernel.org
 help / color / mirror / Atom feed
From: Saeed Bishara <saeed@marvell.com>
To: jeff@garzik.org, mlord@pobox.com, htejun@gmail.com,
	linux-ide@vger.kernel.org
Cc: saeed.bishara@gmail.com, nico@cam.org, byron.bbradley@gmail.com,
	Saeed Bishara <saeed@marvell.com>
Subject: [PATCH 2/2] sata_mv: remove iounmap in mv_platform_remove
Date: Wed, 13 Feb 2008 10:09:10 -1100	[thread overview]
Message-ID: <12029369532977-git-send-email-saeed@marvell.com> (raw)
In-Reply-To: <12029369502995-git-send-email-saeed@marvell.com>

this will fix crash bug when doing rmmod to the driver, this is because the
port_stop function get called later and it could access the device's registers.

Signed-off-by: Saeed Bishara <saeed@marvell.com>
---
 drivers/ata/sata_mv.c |    3 ---
 1 files changed, 0 insertions(+), 3 deletions(-)

diff --git a/drivers/ata/sata_mv.c b/drivers/ata/sata_mv.c
index 9c9a5b0..c61e666 100644
--- a/drivers/ata/sata_mv.c
+++ b/drivers/ata/sata_mv.c
@@ -2983,11 +2983,8 @@ static int __devexit mv_platform_remove(struct platform_device *pdev)
 {
 	struct device *dev = &pdev->dev;
 	struct ata_host *host = dev_get_drvdata(dev);
-	struct mv_host_priv *hpriv = host->private_data;
-	void __iomem *base = hpriv->base;
 
 	ata_host_detach(host);
-	iounmap(base);
 	return 0;
 }
 
-- 
1.5.2.5


  reply	other threads:[~2008-02-13 18:56 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-02-13 21:09 [PATCH 1/2] sata_mv: use hpriv->base instead of the host->iomap Saeed Bishara
2008-02-13 21:09 ` Saeed Bishara [this message]
2008-02-13 19:31   ` [PATCH 2/2] sata_mv: remove iounmap in mv_platform_remove Mark Lord
2008-02-14 12:56     ` saeed bishara
2008-02-14 16:43       ` Mark Lord
2008-02-14 18:33         ` saeed bishara
2008-02-14 19:40           ` Mark Lord
2008-02-16 11:11     ` Martin Michlmayr
2008-02-16 14:05 ` [PATCH 1/2] sata_mv: use hpriv->base instead of the host->iomap Mark Lord
2008-02-20 17:09 ` Jeff Garzik

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=12029369532977-git-send-email-saeed@marvell.com \
    --to=saeed@marvell.com \
    --cc=byron.bbradley@gmail.com \
    --cc=htejun@gmail.com \
    --cc=jeff@garzik.org \
    --cc=linux-ide@vger.kernel.org \
    --cc=mlord@pobox.com \
    --cc=nico@cam.org \
    --cc=saeed.bishara@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.