From: Martin Michlmayr <tbm@cyrius.com>
To: Mark Lord <mlord@pobox.com>
Cc: Saeed Bishara <saeed@marvell.com>,
jeff@garzik.org, htejun@gmail.com, linux-ide@vger.kernel.org,
saeed.bishara@gmail.com, nico@cam.org, byron.bbradley@gmail.com
Subject: Re: [PATCH 2/2] sata_mv: remove iounmap in mv_platform_remove
Date: Sat, 16 Feb 2008 12:11:34 +0100 [thread overview]
Message-ID: <20080216111134.GA30516@deprecation.cyrius.com> (raw)
In-Reply-To: <47B345A6.9000605@pobox.com>
* Mark Lord <mlord@pobox.com> [2008-02-13 14:31]:
>> struct device *dev = &pdev->dev;
>> struct ata_host *host = dev_get_drvdata(dev);
>> - struct mv_host_priv *hpriv = host->private_data;
>> - void __iomem *base = hpriv->base;
>> ata_host_detach(host);
>> - iounmap(base);
>> return 0;
>> }
> ..
>
> Where does the iounmap() now get done instead of that place?
You commented on the 2nd patch but can you please review/ack the 1st
one so this can go in. Thanks.
--
Martin Michlmayr
http://www.cyrius.com/
next prev parent reply other threads:[~2008-02-16 11:35 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-13 21:09 [PATCH 1/2] sata_mv: use hpriv->base instead of the host->iomap Saeed Bishara
2008-02-13 21:09 ` [PATCH 2/2] sata_mv: remove iounmap in mv_platform_remove Saeed Bishara
2008-02-13 19:31 ` Mark Lord
2008-02-14 12:56 ` saeed bishara
2008-02-14 16:43 ` Mark Lord
2008-02-14 18:33 ` saeed bishara
2008-02-14 19:40 ` Mark Lord
2008-02-16 11:11 ` Martin Michlmayr [this message]
2008-02-16 14:05 ` [PATCH 1/2] sata_mv: use hpriv->base instead of the host->iomap Mark Lord
2008-02-20 17:09 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080216111134.GA30516@deprecation.cyrius.com \
--to=tbm@cyrius.com \
--cc=byron.bbradley@gmail.com \
--cc=htejun@gmail.com \
--cc=jeff@garzik.org \
--cc=linux-ide@vger.kernel.org \
--cc=mlord@pobox.com \
--cc=nico@cam.org \
--cc=saeed.bishara@gmail.com \
--cc=saeed@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.