From: Mark Lord <liml@rtr.ca>
To: Saeed Bishara <saeed@marvell.com>
Cc: jeff@garzik.org, mlord@pobox.com, htejun@gmail.com,
linux-ide@vger.kernel.org, saeed.bishara@gmail.com, nico@cam.org,
byron.bbradley@gmail.com
Subject: Re: [PATCH 1/2] sata_mv: use hpriv->base instead of the host->iomap
Date: Sat, 16 Feb 2008 09:05:31 -0500 [thread overview]
Message-ID: <47B6EDAB.3000705@rtr.ca> (raw)
In-Reply-To: <12029369502995-git-send-email-saeed@marvell.com>
Saeed Bishara wrote:
> this fixes crash bug as the iomap table is not valid for integrated controllers.
>
> Signed-off-by: Saeed Bishara <saeed@marvell.com>
> ---
> drivers/ata/sata_mv.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/ata/sata_mv.c b/drivers/ata/sata_mv.c
> index 04b5717..9c9a5b0 100644
> --- a/drivers/ata/sata_mv.c
> +++ b/drivers/ata/sata_mv.c
> @@ -870,7 +870,7 @@ static void mv_start_dma(struct ata_port *ap, void __iomem *port_mmio,
> struct mv_host_priv *hpriv = ap->host->private_data;
> int hard_port = mv_hardport_from_port(ap->port_no);
> void __iomem *hc_mmio = mv_hc_base_from_port(
> - ap->host->iomap[MV_PRIMARY_BAR], hard_port);
> + mv_host_base(ap->host), hard_port);
> u32 hc_irq_cause, ipending;
>
> /* clear EDMA event indicators, if any */
..
This one looks fine.
Acked-by: Mark Lord <mlord@pobox.com>
Cheers
next prev parent reply other threads:[~2008-02-16 14:05 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-13 21:09 [PATCH 1/2] sata_mv: use hpriv->base instead of the host->iomap Saeed Bishara
2008-02-13 21:09 ` [PATCH 2/2] sata_mv: remove iounmap in mv_platform_remove Saeed Bishara
2008-02-13 19:31 ` Mark Lord
2008-02-14 12:56 ` saeed bishara
2008-02-14 16:43 ` Mark Lord
2008-02-14 18:33 ` saeed bishara
2008-02-14 19:40 ` Mark Lord
2008-02-16 11:11 ` Martin Michlmayr
2008-02-16 14:05 ` Mark Lord [this message]
2008-02-20 17:09 ` [PATCH 1/2] sata_mv: use hpriv->base instead of the host->iomap Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47B6EDAB.3000705@rtr.ca \
--to=liml@rtr.ca \
--cc=byron.bbradley@gmail.com \
--cc=htejun@gmail.com \
--cc=jeff@garzik.org \
--cc=linux-ide@vger.kernel.org \
--cc=mlord@pobox.com \
--cc=nico@cam.org \
--cc=saeed.bishara@gmail.com \
--cc=saeed@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.