From: Joe Perches <joe@perches.com>
To: Patrick McHardy <kaber@trash.net>
Cc: David Miller <davem@davemloft.net>,
bruno@thinktube.com, netdev@vger.kernel.org, jgarzik@pobox.com,
linux-wireless@vger.kernel.org, linville@tuxdriver.com
Subject: Re: [PATCH] net/8021q/vlan_dev.c - Use print_mac
Date: Mon, 18 Feb 2008 10:31:02 -0800 [thread overview]
Message-ID: <1203359462.7181.80.camel@localhost> (raw)
In-Reply-To: <47B9A20C.10304@trash.net>
On Mon, 2008-02-18 at 16:19 +0100, Patrick McHardy wrote:
> > @@ -404,11 +405,8 @@ static int vlan_dev_hard_start_xmit(struct sk_buff *skb, struct net_device *dev)
> >
> > pr_debug("%s: about to send skb: %p to dev: %s\n",
> > __FUNCTION__, skb, skb->dev->name);
> > - pr_debug(" " MAC_FMT " " MAC_FMT " %4hx %4hx %4hx\n",
> > - veth->h_dest[0], veth->h_dest[1], veth->h_dest[2],
> > - veth->h_dest[3], veth->h_dest[4], veth->h_dest[5],
> > - veth->h_source[0], veth->h_source[1], veth->h_source[2],
> > - veth->h_source[3], veth->h_source[4], veth->h_source[5],
> > + pr_debug(" %s %s %4hx %4hx %4hx\n",
> > + print_mac(mac, veth->h_dest), print_mac(mac2, veth->h_source),
> This results in print_mac getting called twice per packet even without
> debugging. Whats the problem with MAC_FMT?
It's just a consistency thing.
It identifies code where MAC addresses are used.
an allyesconfig is a bit smaller (~.1%).
pr_debug is a noop when not debugging, print_mac is optimized away.
WARNING: multiple messages have this Message-ID (diff)
From: Joe Perches <joe-6d6DIl74uiNBDgjK7y7TUQ@public.gmane.org>
To: Patrick McHardy <kaber-dcUjhNyLwpNeoWH0uzbU5w@public.gmane.org>
Cc: David Miller <davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>,
bruno-L9ZBdB2wSWtl57MIdRCFDg@public.gmane.org,
netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
jgarzik-e+AXbWqSrlAAvxtiuMwx3w@public.gmane.org,
linux-wireless-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linville-2XuSBdqkA4R54TAoqtyWWQ@public.gmane.org
Subject: Re: [PATCH] net/8021q/vlan_dev.c - Use print_mac
Date: Mon, 18 Feb 2008 10:31:02 -0800 [thread overview]
Message-ID: <1203359462.7181.80.camel@localhost> (raw)
In-Reply-To: <47B9A20C.10304-dcUjhNyLwpNeoWH0uzbU5w@public.gmane.org>
On Mon, 2008-02-18 at 16:19 +0100, Patrick McHardy wrote:
> > @@ -404,11 +405,8 @@ static int vlan_dev_hard_start_xmit(struct sk_buff *skb, struct net_device *dev)
> >
> > pr_debug("%s: about to send skb: %p to dev: %s\n",
> > __FUNCTION__, skb, skb->dev->name);
> > - pr_debug(" " MAC_FMT " " MAC_FMT " %4hx %4hx %4hx\n",
> > - veth->h_dest[0], veth->h_dest[1], veth->h_dest[2],
> > - veth->h_dest[3], veth->h_dest[4], veth->h_dest[5],
> > - veth->h_source[0], veth->h_source[1], veth->h_source[2],
> > - veth->h_source[3], veth->h_source[4], veth->h_source[5],
> > + pr_debug(" %s %s %4hx %4hx %4hx\n",
> > + print_mac(mac, veth->h_dest), print_mac(mac2, veth->h_source),
> This results in print_mac getting called twice per packet even without
> debugging. Whats the problem with MAC_FMT?
It's just a consistency thing.
It identifies code where MAC addresses are used.
an allyesconfig is a bit smaller (~.1%).
pr_debug is a noop when not debugging, print_mac is optimized away.
next prev parent reply other threads:[~2008-02-18 18:31 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-15 10:48 [PATCH] add macro for printing mac addresses Bruno Randolf
2008-02-15 10:48 ` Bruno Randolf
2008-02-15 10:58 ` David Miller
2008-02-15 17:42 ` [PATCH] net/8021q/vlan_dev.c - Use print_mac Joe Perches
2008-02-15 17:42 ` Joe Perches
2008-02-18 7:35 ` David Miller
2008-02-18 15:19 ` Patrick McHardy
2008-02-18 18:31 ` Joe Perches [this message]
2008-02-18 18:31 ` Joe Perches
2008-02-18 21:31 ` Patrick McHardy
2008-02-18 21:31 ` Patrick McHardy
2008-02-18 20:55 ` David Miller
2008-02-18 21:17 ` Patrick McHardy
2008-02-18 21:17 ` Patrick McHardy
2008-02-19 0:43 ` David Miller
2008-02-19 0:43 ` David Miller
2008-02-19 0:50 ` David Miller
2008-02-19 0:50 ` David Miller
2008-02-19 1:03 ` Joe Perches
2008-02-19 1:03 ` Joe Perches
2008-02-19 1:30 ` Philip Craig
2008-02-19 1:30 ` Philip Craig
2008-02-19 3:23 ` David Miller
2008-02-19 3:23 ` David Miller
2008-02-19 11:48 ` Patrick McHardy
2008-02-15 17:42 ` [PATCH 2/2] Remove MAC_FMT Joe Perches
2008-02-15 17:42 ` Joe Perches
2008-02-18 7:35 ` David Miller
2008-02-15 12:54 ` [PATCH] add macro for printing mac addresses Johannes Berg
2008-02-15 12:54 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1203359462.7181.80.camel@localhost \
--to=joe@perches.com \
--cc=bruno@thinktube.com \
--cc=davem@davemloft.net \
--cc=jgarzik@pobox.com \
--cc=kaber@trash.net \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.