From: Patrick McHardy <kaber@trash.net>
To: David Miller <davem@davemloft.net>
Cc: joe@perches.com, bruno@thinktube.com, netdev@vger.kernel.org,
jgarzik@pobox.com, linux-wireless@vger.kernel.org,
linville@tuxdriver.com
Subject: Re: [PATCH] net/8021q/vlan_dev.c - Use print_mac
Date: Mon, 18 Feb 2008 22:17:27 +0100 [thread overview]
Message-ID: <47B9F5E7.3020905@trash.net> (raw)
In-Reply-To: <20080218.125525.192686382.davem@davemloft.net>
David Miller wrote:
> From: Patrick McHardy <kaber@trash.net>
> Date: Mon, 18 Feb 2008 16:19:40 +0100
>
>
>> Joe Perches wrote:
>>
>>>
>>>> We specifically removed this sort of thing, please don't
>>>> add it back.
>>>>
>> Why?
>>
>
> We converted the entire tree over the print_mac(), and since
> the MAC_FMT stuff was therefore no longer used we could
> remove it.
>
> Some references slipped back in somehow, and thus MAC_FMT
> did too.
>
> There is no reason to keep around a global interface for
> _one_ user when that user can use the recommended interface
> just as equally as the rest of the tree which we converted.
>
> This is a pr_debug() statement we're talking about here.
> :-)
>
The way pr_debug is implemented it still results in two function
calls per packet since the compiler doesn't know that it doesn't
have visible side-effects besides modifying the (unused) buffer.
I confirmed this using codiff.
WARNING: multiple messages have this Message-ID (diff)
From: Patrick McHardy <kaber-dcUjhNyLwpNeoWH0uzbU5w@public.gmane.org>
To: David Miller <davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>
Cc: joe-6d6DIl74uiNBDgjK7y7TUQ@public.gmane.org,
bruno-L9ZBdB2wSWtl57MIdRCFDg@public.gmane.org,
netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
jgarzik-e+AXbWqSrlAAvxtiuMwx3w@public.gmane.org,
linux-wireless-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linville-2XuSBdqkA4R54TAoqtyWWQ@public.gmane.org
Subject: Re: [PATCH] net/8021q/vlan_dev.c - Use print_mac
Date: Mon, 18 Feb 2008 22:17:27 +0100 [thread overview]
Message-ID: <47B9F5E7.3020905@trash.net> (raw)
In-Reply-To: <20080218.125525.192686382.davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>
David Miller wrote:
> From: Patrick McHardy <kaber-dcUjhNyLwpNeoWH0uzbU5w@public.gmane.org>
> Date: Mon, 18 Feb 2008 16:19:40 +0100
>
>
>> Joe Perches wrote:
>>
>>>
>>>> We specifically removed this sort of thing, please don't
>>>> add it back.
>>>>
>> Why?
>>
>
> We converted the entire tree over the print_mac(), and since
> the MAC_FMT stuff was therefore no longer used we could
> remove it.
>
> Some references slipped back in somehow, and thus MAC_FMT
> did too.
>
> There is no reason to keep around a global interface for
> _one_ user when that user can use the recommended interface
> just as equally as the rest of the tree which we converted.
>
> This is a pr_debug() statement we're talking about here.
> :-)
>
The way pr_debug is implemented it still results in two function
calls per packet since the compiler doesn't know that it doesn't
have visible side-effects besides modifying the (unused) buffer.
I confirmed this using codiff.
next prev parent reply other threads:[~2008-02-18 21:17 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-15 10:48 [PATCH] add macro for printing mac addresses Bruno Randolf
2008-02-15 10:48 ` Bruno Randolf
2008-02-15 10:58 ` David Miller
2008-02-15 17:42 ` [PATCH] net/8021q/vlan_dev.c - Use print_mac Joe Perches
2008-02-15 17:42 ` Joe Perches
2008-02-18 7:35 ` David Miller
2008-02-18 15:19 ` Patrick McHardy
2008-02-18 18:31 ` Joe Perches
2008-02-18 18:31 ` Joe Perches
2008-02-18 21:31 ` Patrick McHardy
2008-02-18 21:31 ` Patrick McHardy
2008-02-18 20:55 ` David Miller
2008-02-18 21:17 ` Patrick McHardy [this message]
2008-02-18 21:17 ` Patrick McHardy
2008-02-19 0:43 ` David Miller
2008-02-19 0:43 ` David Miller
2008-02-19 0:50 ` David Miller
2008-02-19 0:50 ` David Miller
2008-02-19 1:03 ` Joe Perches
2008-02-19 1:03 ` Joe Perches
2008-02-19 1:30 ` Philip Craig
2008-02-19 1:30 ` Philip Craig
2008-02-19 3:23 ` David Miller
2008-02-19 3:23 ` David Miller
2008-02-19 11:48 ` Patrick McHardy
2008-02-15 17:42 ` [PATCH 2/2] Remove MAC_FMT Joe Perches
2008-02-15 17:42 ` Joe Perches
2008-02-18 7:35 ` David Miller
2008-02-15 12:54 ` [PATCH] add macro for printing mac addresses Johannes Berg
2008-02-15 12:54 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47B9F5E7.3020905@trash.net \
--to=kaber@trash.net \
--cc=bruno@thinktube.com \
--cc=davem@davemloft.net \
--cc=jgarzik@pobox.com \
--cc=joe@perches.com \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.