From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Gerhard Pircher <gerhard_pircher@gmx.net>
Cc: airlied@linux.ie, linuxppc-dev@ozlabs.org,
dri-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org
Subject: Re: [BUG/RFC/PATCH] drm: Fix for non-coherent DMA PowerPC
Date: Mon, 03 Mar 2008 07:47:09 +1100 [thread overview]
Message-ID: <1204490829.15052.482.camel@pasglop> (raw)
In-Reply-To: <20080302110505.175270@gmx.net>
> Xorg (v7.1.1, Debian Etch) crashes with this patch (applied to 2.6.25-rc3)
> on my AmigaOne with a Radeon 9200 (PCIGART mode enabled). See the attached
> log file for the stack trace.
That doesn't look possible, which is weird... looks like we are passing
0 to clean_dcache_range().
Interestingly enough, I can -see- possible issues with the ppc32 DMA API
when trying to use HIGHMEM but that isn't the case here...
Can you add printk's to ati_pcigart.c to print the arguments passed to
+ dma_sync_single_for_device(&dev->pdev->dev,
+ bus_address,
+ max_pages * sizeof(u32),
+ PCI_DMA_TODEVICE);
+
And also print the result of bus_to_virt(bus_address) ?
Ben.
WARNING: multiple messages have this Message-ID (diff)
From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Gerhard Pircher <gerhard_pircher@gmx.net>
Cc: airlied@linux.ie, linux-kernel@vger.kernel.org,
dri-devel@lists.sourceforge.net, linuxppc-dev@ozlabs.org
Subject: Re: [BUG/RFC/PATCH] drm: Fix for non-coherent DMA PowerPC
Date: Mon, 03 Mar 2008 07:47:09 +1100 [thread overview]
Message-ID: <1204490829.15052.482.camel@pasglop> (raw)
In-Reply-To: <20080302110505.175270@gmx.net>
> Xorg (v7.1.1, Debian Etch) crashes with this patch (applied to 2.6.25-rc3)
> on my AmigaOne with a Radeon 9200 (PCIGART mode enabled). See the attached
> log file for the stack trace.
That doesn't look possible, which is weird... looks like we are passing
0 to clean_dcache_range().
Interestingly enough, I can -see- possible issues with the ppc32 DMA API
when trying to use HIGHMEM but that isn't the case here...
Can you add printk's to ati_pcigart.c to print the arguments passed to
+ dma_sync_single_for_device(&dev->pdev->dev,
+ bus_address,
+ max_pages * sizeof(u32),
+ PCI_DMA_TODEVICE);
+
And also print the result of bus_to_virt(bus_address) ?
Ben.
next prev parent reply other threads:[~2008-03-02 20:48 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-25 23:41 [RFC/PATCH] drm: Fix for non-coherent DMA PowerPC Benjamin Herrenschmidt
2007-11-25 23:41 ` Benjamin Herrenschmidt
2008-03-02 11:05 ` [BUG/RFC/PATCH] " Gerhard Pircher
2008-03-02 11:05 ` Gerhard Pircher
2008-03-02 20:47 ` Benjamin Herrenschmidt [this message]
2008-03-02 20:47 ` Benjamin Herrenschmidt
2008-03-02 22:30 ` Gerhard Pircher
2008-03-02 22:30 ` Gerhard Pircher
2008-03-02 22:54 ` Benjamin Herrenschmidt
2008-03-02 22:54 ` Benjamin Herrenschmidt
2008-03-02 22:56 ` Benjamin Herrenschmidt
2008-03-02 22:56 ` Benjamin Herrenschmidt
2008-03-03 19:51 ` Gerhard Pircher
2008-03-03 19:51 ` Gerhard Pircher
2008-03-03 20:44 ` Benjamin Herrenschmidt
2008-03-03 20:44 ` Benjamin Herrenschmidt
2008-03-03 21:37 ` Gerhard Pircher
2008-03-03 21:37 ` Gerhard Pircher
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1204490829.15052.482.camel@pasglop \
--to=benh@kernel.crashing.org \
--cc=airlied@linux.ie \
--cc=dri-devel@lists.sourceforge.net \
--cc=gerhard_pircher@gmx.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.