From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Gerhard Pircher <gerhard_pircher@gmx.net>
Cc: airlied@linux.ie, linuxppc-dev@ozlabs.org,
dri-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org
Subject: Re: [BUG/RFC/PATCH] drm: Fix for non-coherent DMA PowerPC
Date: Mon, 03 Mar 2008 09:56:09 +1100 [thread overview]
Message-ID: <1204498569.15052.488.camel@pasglop> (raw)
In-Reply-To: <20080302223012.90210@gmx.net>
Bah, I think I found the problem:
+static inline void *drm_vmalloc_dma(unsigned long size)
+{
+#if defined(__powerpc__) && defined(CONFIG_NOT_COHERENT_CACHE)
+ return __vmalloc(size, GFP_KERNEL | __GFP_HIGHMEM,
+ PAGE_KERNEL | _PAGE_NO_CACHE);
+#else
+ return vmalloc_32(size);
+#endif
+}
+
Remove the GFP_HIGHMEM from the above. It looks like our cache
flushing isn't going to work for highmem, it would need some
kmap's for that.
Ben.
WARNING: multiple messages have this Message-ID (diff)
From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Gerhard Pircher <gerhard_pircher@gmx.net>
Cc: linuxppc-dev@ozlabs.org, dri-devel@lists.sourceforge.net,
linux-kernel@vger.kernel.org, airlied@linux.ie
Subject: Re: [BUG/RFC/PATCH] drm: Fix for non-coherent DMA PowerPC
Date: Mon, 03 Mar 2008 09:56:09 +1100 [thread overview]
Message-ID: <1204498569.15052.488.camel@pasglop> (raw)
In-Reply-To: <20080302223012.90210@gmx.net>
Bah, I think I found the problem:
+static inline void *drm_vmalloc_dma(unsigned long size)
+{
+#if defined(__powerpc__) && defined(CONFIG_NOT_COHERENT_CACHE)
+ return __vmalloc(size, GFP_KERNEL | __GFP_HIGHMEM,
+ PAGE_KERNEL | _PAGE_NO_CACHE);
+#else
+ return vmalloc_32(size);
+#endif
+}
+
Remove the GFP_HIGHMEM from the above. It looks like our cache
flushing isn't going to work for highmem, it would need some
kmap's for that.
Ben.
next prev parent reply other threads:[~2008-03-02 22:56 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-25 23:41 [RFC/PATCH] drm: Fix for non-coherent DMA PowerPC Benjamin Herrenschmidt
2007-11-25 23:41 ` Benjamin Herrenschmidt
2008-03-02 11:05 ` [BUG/RFC/PATCH] " Gerhard Pircher
2008-03-02 11:05 ` Gerhard Pircher
2008-03-02 20:47 ` Benjamin Herrenschmidt
2008-03-02 20:47 ` Benjamin Herrenschmidt
2008-03-02 22:30 ` Gerhard Pircher
2008-03-02 22:30 ` Gerhard Pircher
2008-03-02 22:54 ` Benjamin Herrenschmidt
2008-03-02 22:54 ` Benjamin Herrenschmidt
2008-03-02 22:56 ` Benjamin Herrenschmidt [this message]
2008-03-02 22:56 ` Benjamin Herrenschmidt
2008-03-03 19:51 ` Gerhard Pircher
2008-03-03 19:51 ` Gerhard Pircher
2008-03-03 20:44 ` Benjamin Herrenschmidt
2008-03-03 20:44 ` Benjamin Herrenschmidt
2008-03-03 21:37 ` Gerhard Pircher
2008-03-03 21:37 ` Gerhard Pircher
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1204498569.15052.488.camel@pasglop \
--to=benh@kernel.crashing.org \
--cc=airlied@linux.ie \
--cc=dri-devel@lists.sourceforge.net \
--cc=gerhard_pircher@gmx.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.