All of lore.kernel.org
 help / color / mirror / Atom feed
From: Hollis Blanchard <hollisb@us.ibm.com>
To: linuxppc-dev <linuxppc-dev@ozlabs.org>
Cc: kvm-ppc-devel <kvm-ppc-devel@lists.sourceforge.net>
Subject: [kvm-ppc-devel] Bamboo PCI interrupt issues
Date: Tue, 04 Mar 2008 00:02:33 +0000	[thread overview]
Message-ID: <1204588953.7921.13.camel@basalt> (raw)

I'm having two problems with PCI interrupts as described in bamboo.dts.
Here is are the properties in question:

	/* Bamboo has all 4 IRQ pins tied together per slot */
	interrupt-map-mask = <f800 0 0 0>;
	interrupt-map = <
		/* IDSEL 1 */
		0800 0 0 0 &UIC0 1c 8

		/* IDSEL 2 */
		1000 0 0 0 &UIC0 1b 8

		/* IDSEL 3 */
		1800 0 0 0 &UIC0 1a 8

		/* IDSEL 4 */
		2000 0 0 0 &UIC0 19 8
	>;


First, the 440EP[1] and Bamboo[2] user manuals indicate that PCI IRQ 0-3
-> board IRQ 2-5 -> UIC IRQ 25-28. However, the device tree has that
reversed, so PCI IRQ 0 appears as UIC IRQ 28 (0x1c).

Second, the sensitivity seems to be wrong. All these interrupts have the
sensitivity encoded as 8, which means "high to low edge" in the OpenPIC
binding. Now, 440EP has a UIC, rather than an OpenPIC, but there is no
UIC binding AFAICS.

When I change the 8 to a 4 ("active high level"), I see the proper
values in the UIC polarity register, and PCI interrupts start working in
KVM.

Is anybody using Bamboo PCI support right now? Does it actually work?

[1]
https://www.amcc.com/MyAMCC/retrieveDocument/PowerPC/440EP/PPC440EP_UM2000.pdf
[2] Seems to have been deleted from the web. Thanks, AMCC.

-- 
Hollis Blanchard
IBM Linux Technology Center


-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
_______________________________________________
kvm-ppc-devel mailing list
kvm-ppc-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/kvm-ppc-devel

WARNING: multiple messages have this Message-ID (diff)
From: Hollis Blanchard <hollisb@us.ibm.com>
To: linuxppc-dev <linuxppc-dev@ozlabs.org>
Cc: kvm-ppc-devel <kvm-ppc-devel@lists.sourceforge.net>
Subject: Bamboo PCI interrupt issues
Date: Mon, 03 Mar 2008 18:02:33 -0600	[thread overview]
Message-ID: <1204588953.7921.13.camel@basalt> (raw)

I'm having two problems with PCI interrupts as described in bamboo.dts.
Here is are the properties in question:

	/* Bamboo has all 4 IRQ pins tied together per slot */
	interrupt-map-mask = <f800 0 0 0>;
	interrupt-map = <
		/* IDSEL 1 */
		0800 0 0 0 &UIC0 1c 8

		/* IDSEL 2 */
		1000 0 0 0 &UIC0 1b 8

		/* IDSEL 3 */
		1800 0 0 0 &UIC0 1a 8

		/* IDSEL 4 */
		2000 0 0 0 &UIC0 19 8
	>;


First, the 440EP[1] and Bamboo[2] user manuals indicate that PCI IRQ 0-3
-> board IRQ 2-5 -> UIC IRQ 25-28. However, the device tree has that
reversed, so PCI IRQ 0 appears as UIC IRQ 28 (0x1c).

Second, the sensitivity seems to be wrong. All these interrupts have the
sensitivity encoded as 8, which means "high to low edge" in the OpenPIC
binding. Now, 440EP has a UIC, rather than an OpenPIC, but there is no
UIC binding AFAICS.

When I change the 8 to a 4 ("active high level"), I see the proper
values in the UIC polarity register, and PCI interrupts start working in
KVM.

Is anybody using Bamboo PCI support right now? Does it actually work?

[1]
https://www.amcc.com/MyAMCC/retrieveDocument/PowerPC/440EP/PPC440EP_UM2000.pdf
[2] Seems to have been deleted from the web. Thanks, AMCC.

-- 
Hollis Blanchard
IBM Linux Technology Center

             reply	other threads:[~2008-03-04  0:02 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-03-04  0:02 Hollis Blanchard [this message]
2008-03-04  0:02 ` Bamboo PCI interrupt issues Hollis Blanchard
2008-03-04  0:59 ` [kvm-ppc-devel] " David Gibson
2008-03-04  0:59   ` David Gibson
2008-03-04  1:42   ` [kvm-ppc-devel] " Benjamin Herrenschmidt
2008-03-04  1:42     ` Benjamin Herrenschmidt
2008-03-04  1:53     ` [kvm-ppc-devel] " David Gibson
2008-03-04  1:53       ` David Gibson
2008-03-04  2:07       ` [kvm-ppc-devel] " Segher Boessenkool
2008-03-04  2:07         ` Segher Boessenkool
2008-03-04  2:15         ` [kvm-ppc-devel] " David Gibson
2008-03-04  2:15           ` David Gibson
2008-03-04  3:37 ` [kvm-ppc-devel] " Josh Boyer
2008-03-04  3:37   ` Josh Boyer
2008-03-04  6:15   ` [kvm-ppc-devel] " Stefan Roese
2008-03-04  6:15     ` Stefan Roese
2008-03-04  6:33     ` [kvm-ppc-devel] " Benjamin Herrenschmidt
2008-03-04  6:33       ` Benjamin Herrenschmidt
2008-03-04 20:39       ` [kvm-ppc-devel] " Segher Boessenkool
2008-03-04 20:39         ` Segher Boessenkool
2008-03-04 20:41         ` [kvm-ppc-devel] " Benjamin Herrenschmidt
2008-03-04 20:41           ` Benjamin Herrenschmidt
2008-03-04 20:59           ` [kvm-ppc-devel] " Segher Boessenkool
2008-03-04 20:59             ` Segher Boessenkool
2008-03-04 21:01             ` [kvm-ppc-devel] " Benjamin Herrenschmidt
2008-03-04 21:01               ` Benjamin Herrenschmidt
2008-03-04  6:18   ` [kvm-ppc-devel] " Benjamin Herrenschmidt
2008-03-04  6:18     ` Benjamin Herrenschmidt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1204588953.7921.13.camel@basalt \
    --to=hollisb@us.ibm.com \
    --cc=kvm-ppc-devel@lists.sourceforge.net \
    --cc=linuxppc-dev@ozlabs.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.