From: Peter Zijlstra <peterz@infradead.org>
To: Miklos Szeredi <miklos@szeredi.hu>
Cc: akpm@linux-foundation.org, linux-kernel@vger.kernel.org,
linux-fsdevel@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [patch 3/8] mm: rotate_reclaimable_page() cleanup
Date: Tue, 18 Mar 2008 12:31:36 +0100 [thread overview]
Message-ID: <1205839896.8514.344.camel@twins> (raw)
In-Reply-To: <20080317191944.208962764@szeredi.hu>
On Mon, 2008-03-17 at 20:19 +0100, Miklos Szeredi wrote:
> plain text document attachment (rotate_reclaimable_page_cleanup.patch)
> From: Miklos Szeredi <mszeredi@suse.cz>
>
> Clean up messy conditional calling of test_clear_page_writeback() from
> both rotate_reclaimable_page() and end_page_writeback().
> -int rotate_reclaimable_page(struct page *page)
> +void rotate_reclaimable_page(struct page *page)
> {
> - struct pagevec *pvec;
> - unsigned long flags;
> -
> - if (PageLocked(page))
> - return 1;
> - if (PageDirty(page))
> - return 1;
> - if (PageActive(page))
> - return 1;
> - if (!PageLRU(page))
> - return 1;
Might be me, but I find the above easier to read than
> + if (!PageLocked(page) && !PageDirty(page) && !PageActive(page) &&
> + PageLRU(page)) {
>
WARNING: multiple messages have this Message-ID (diff)
From: Peter Zijlstra <peterz@infradead.org>
To: Miklos Szeredi <miklos@szeredi.hu>
Cc: akpm@linux-foundation.org, linux-kernel@vger.kernel.org,
linux-fsdevel@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [patch 3/8] mm: rotate_reclaimable_page() cleanup
Date: Tue, 18 Mar 2008 12:31:36 +0100 [thread overview]
Message-ID: <1205839896.8514.344.camel@twins> (raw)
In-Reply-To: <20080317191944.208962764@szeredi.hu>
On Mon, 2008-03-17 at 20:19 +0100, Miklos Szeredi wrote:
> plain text document attachment (rotate_reclaimable_page_cleanup.patch)
> From: Miklos Szeredi <mszeredi@suse.cz>
>
> Clean up messy conditional calling of test_clear_page_writeback() from
> both rotate_reclaimable_page() and end_page_writeback().
> -int rotate_reclaimable_page(struct page *page)
> +void rotate_reclaimable_page(struct page *page)
> {
> - struct pagevec *pvec;
> - unsigned long flags;
> -
> - if (PageLocked(page))
> - return 1;
> - if (PageDirty(page))
> - return 1;
> - if (PageActive(page))
> - return 1;
> - if (!PageLRU(page))
> - return 1;
Might be me, but I find the above easier to read than
> + if (!PageLocked(page) && !PageDirty(page) && !PageActive(page) &&
> + PageLRU(page)) {
>
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2008-03-18 11:31 UTC|newest]
Thread overview: 58+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-17 19:19 [patch 0/8] fuse: writable mmap + batched write Miklos Szeredi
2008-03-17 19:19 ` Miklos Szeredi
2008-03-17 19:19 ` [patch 1/8] mm: bdi: export bdi_writeout_inc() Miklos Szeredi
2008-03-17 19:19 ` Miklos Szeredi, Miklos Szeredi
2008-03-18 11:27 ` Peter Zijlstra
2008-03-18 11:27 ` Peter Zijlstra
2008-03-18 11:46 ` Miklos Szeredi
2008-03-18 11:46 ` Miklos Szeredi
2008-03-17 19:19 ` [patch 2/8] mm: Add NR_WRITEBACK_TEMP counter Miklos Szeredi
2008-03-17 19:19 ` Miklos Szeredi, Miklos Szeredi
2008-03-18 5:05 ` Andrew Morton
2008-03-18 5:05 ` Andrew Morton
2008-03-17 19:19 ` [patch 3/8] mm: rotate_reclaimable_page() cleanup Miklos Szeredi
2008-03-17 19:19 ` Miklos Szeredi, Miklos Szeredi
2008-03-18 11:31 ` Peter Zijlstra [this message]
2008-03-18 11:31 ` Peter Zijlstra
2008-03-18 11:56 ` Miklos Szeredi
2008-03-18 11:56 ` Miklos Szeredi
2008-03-18 16:45 ` Andrew Morton
2008-03-18 16:45 ` Andrew Morton
2008-03-17 19:19 ` [patch 4/8] mm: allow not updating BDI stats in end_page_writeback() Miklos Szeredi
2008-03-17 19:19 ` Miklos Szeredi, Miklos Szeredi
2008-03-18 5:04 ` Andrew Morton
2008-03-18 5:04 ` Andrew Morton
2008-03-18 8:11 ` Miklos Szeredi
2008-03-18 8:11 ` Miklos Szeredi
2008-03-18 8:18 ` Andrew Morton
2008-03-18 8:18 ` Andrew Morton
2008-03-18 11:33 ` Peter Zijlstra
2008-03-18 11:33 ` Peter Zijlstra
2008-03-18 11:59 ` Miklos Szeredi
2008-03-18 11:59 ` Miklos Szeredi
2008-03-18 12:29 ` Peter Zijlstra
2008-03-18 12:29 ` Peter Zijlstra
2008-03-18 12:51 ` Miklos Szeredi
2008-03-18 12:51 ` Miklos Szeredi
2008-03-18 13:08 ` Peter Zijlstra
2008-03-18 13:08 ` Peter Zijlstra
2008-03-18 13:58 ` Miklos Szeredi
2008-03-18 13:58 ` Miklos Szeredi
2008-03-18 13:59 ` Peter Zijlstra
2008-03-18 13:59 ` Peter Zijlstra
2008-03-18 15:53 ` Miklos Szeredi
2008-03-18 15:53 ` Miklos Szeredi
2008-03-18 16:49 ` Andrew Morton
2008-03-18 16:49 ` Andrew Morton
2008-03-17 19:19 ` [patch 5/8] fuse: support writable mmap Miklos Szeredi
2008-03-17 19:19 ` Miklos Szeredi, Miklos Szeredi
2008-03-17 19:19 ` [patch 6/8] fuse: clean up setting i_size in write Miklos Szeredi
2008-03-17 19:19 ` Miklos Szeredi, Miklos Szeredi
2008-03-18 5:08 ` Andrew Morton
2008-03-18 5:08 ` Andrew Morton
2008-03-18 8:16 ` Miklos Szeredi
2008-03-18 8:16 ` Miklos Szeredi
2008-03-17 19:19 ` [patch 7/8] fuse: implement perform_write Miklos Szeredi
2008-03-17 19:19 ` Miklos Szeredi, Nick Piggin
2008-03-17 19:19 ` [patch 8/8] fuse: update file size on short read Miklos Szeredi
2008-03-17 19:19 ` Miklos Szeredi, Miklos Szeredi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1205839896.8514.344.camel@twins \
--to=peterz@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=miklos@szeredi.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.