All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@linux-foundation.org>
To: Miklos Szeredi <miklos@szeredi.hu>
Cc: a.p.zijlstra@chello.nl, linux-kernel@vger.kernel.org,
	linux-fsdevel@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [patch 4/8] mm: allow not updating BDI stats in end_page_writeback()
Date: Tue, 18 Mar 2008 01:18:11 -0700	[thread overview]
Message-ID: <20080318011811.252c7c59.akpm@linux-foundation.org> (raw)
In-Reply-To: <E1JbWvF-0005Hr-Ur@pomaz-ex.szeredi.hu>

On Tue, 18 Mar 2008 09:11:49 +0100 Miklos Szeredi <miklos@szeredi.hu> wrote:

> > 
> > Reason: bdi_cap_writeback_dirty() is kinda weirdly intrepreted to mean
> > various different things in different places and we really should separate
> > its multiple interpretations into separate flags.
> > 
> > Note that this becomes a standalone VFS cleanup patch, and the fuse code
> > can then just use it later on.  
> 
> Hmm, I can see two slightly different meanings of bdi_cap_writeback_dirty():
> 
>  1) need to call ->writepage (sync_page_range(), ...)
>  2) need to update BDI stats  (test_clear_page_writeback(), ...)
> 
> If these two were different flags, then fuse could set the
> NEED_WRITEPAGE flag, but clear the NEED_UPDATE_BDI_STATS flag, and do
> it manually.
> 
> Does that sound workable?

Yup, thanks.

WARNING: multiple messages have this Message-ID (diff)
From: Andrew Morton <akpm@linux-foundation.org>
To: Miklos Szeredi <miklos@szeredi.hu>
Cc: a.p.zijlstra@chello.nl, linux-kernel@vger.kernel.org,
	linux-fsdevel@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [patch 4/8] mm: allow not updating BDI stats in end_page_writeback()
Date: Tue, 18 Mar 2008 01:18:11 -0700	[thread overview]
Message-ID: <20080318011811.252c7c59.akpm@linux-foundation.org> (raw)
In-Reply-To: <E1JbWvF-0005Hr-Ur@pomaz-ex.szeredi.hu>

On Tue, 18 Mar 2008 09:11:49 +0100 Miklos Szeredi <miklos@szeredi.hu> wrote:

> > 
> > Reason: bdi_cap_writeback_dirty() is kinda weirdly intrepreted to mean
> > various different things in different places and we really should separate
> > its multiple interpretations into separate flags.
> > 
> > Note that this becomes a standalone VFS cleanup patch, and the fuse code
> > can then just use it later on.  
> 
> Hmm, I can see two slightly different meanings of bdi_cap_writeback_dirty():
> 
>  1) need to call ->writepage (sync_page_range(), ...)
>  2) need to update BDI stats  (test_clear_page_writeback(), ...)
> 
> If these two were different flags, then fuse could set the
> NEED_WRITEPAGE flag, but clear the NEED_UPDATE_BDI_STATS flag, and do
> it manually.
> 
> Does that sound workable?

Yup, thanks.

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  reply	other threads:[~2008-03-18  8:19 UTC|newest]

Thread overview: 58+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-03-17 19:19 [patch 0/8] fuse: writable mmap + batched write Miklos Szeredi
2008-03-17 19:19 ` Miklos Szeredi
2008-03-17 19:19 ` [patch 1/8] mm: bdi: export bdi_writeout_inc() Miklos Szeredi
2008-03-17 19:19   ` Miklos Szeredi, Miklos Szeredi
2008-03-18 11:27   ` Peter Zijlstra
2008-03-18 11:27     ` Peter Zijlstra
2008-03-18 11:46     ` Miklos Szeredi
2008-03-18 11:46       ` Miklos Szeredi
2008-03-17 19:19 ` [patch 2/8] mm: Add NR_WRITEBACK_TEMP counter Miklos Szeredi
2008-03-17 19:19   ` Miklos Szeredi, Miklos Szeredi
2008-03-18  5:05   ` Andrew Morton
2008-03-18  5:05     ` Andrew Morton
2008-03-17 19:19 ` [patch 3/8] mm: rotate_reclaimable_page() cleanup Miklos Szeredi
2008-03-17 19:19   ` Miklos Szeredi, Miklos Szeredi
2008-03-18 11:31   ` Peter Zijlstra
2008-03-18 11:31     ` Peter Zijlstra
2008-03-18 11:56     ` Miklos Szeredi
2008-03-18 11:56       ` Miklos Szeredi
2008-03-18 16:45       ` Andrew Morton
2008-03-18 16:45         ` Andrew Morton
2008-03-17 19:19 ` [patch 4/8] mm: allow not updating BDI stats in end_page_writeback() Miklos Szeredi
2008-03-17 19:19   ` Miklos Szeredi, Miklos Szeredi
2008-03-18  5:04   ` Andrew Morton
2008-03-18  5:04     ` Andrew Morton
2008-03-18  8:11     ` Miklos Szeredi
2008-03-18  8:11       ` Miklos Szeredi
2008-03-18  8:18       ` Andrew Morton [this message]
2008-03-18  8:18         ` Andrew Morton
2008-03-18 11:33   ` Peter Zijlstra
2008-03-18 11:33     ` Peter Zijlstra
2008-03-18 11:59     ` Miklos Szeredi
2008-03-18 11:59       ` Miklos Szeredi
2008-03-18 12:29       ` Peter Zijlstra
2008-03-18 12:29         ` Peter Zijlstra
2008-03-18 12:51         ` Miklos Szeredi
2008-03-18 12:51           ` Miklos Szeredi
2008-03-18 13:08           ` Peter Zijlstra
2008-03-18 13:08             ` Peter Zijlstra
2008-03-18 13:58             ` Miklos Szeredi
2008-03-18 13:58               ` Miklos Szeredi
2008-03-18 13:59               ` Peter Zijlstra
2008-03-18 13:59                 ` Peter Zijlstra
2008-03-18 15:53                 ` Miklos Szeredi
2008-03-18 15:53                   ` Miklos Szeredi
2008-03-18 16:49                   ` Andrew Morton
2008-03-18 16:49                     ` Andrew Morton
2008-03-17 19:19 ` [patch 5/8] fuse: support writable mmap Miklos Szeredi
2008-03-17 19:19   ` Miklos Szeredi, Miklos Szeredi
2008-03-17 19:19 ` [patch 6/8] fuse: clean up setting i_size in write Miklos Szeredi
2008-03-17 19:19   ` Miklos Szeredi, Miklos Szeredi
2008-03-18  5:08   ` Andrew Morton
2008-03-18  5:08     ` Andrew Morton
2008-03-18  8:16     ` Miklos Szeredi
2008-03-18  8:16       ` Miklos Szeredi
2008-03-17 19:19 ` [patch 7/8] fuse: implement perform_write Miklos Szeredi
2008-03-17 19:19   ` Miklos Szeredi, Nick Piggin
2008-03-17 19:19 ` [patch 8/8] fuse: update file size on short read Miklos Szeredi
2008-03-17 19:19   ` Miklos Szeredi, Miklos Szeredi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080318011811.252c7c59.akpm@linux-foundation.org \
    --to=akpm@linux-foundation.org \
    --cc=a.p.zijlstra@chello.nl \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=miklos@szeredi.hu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.