From: "Abdul Rahim, Faizal" <faizal.abdul.rahim@linux.intel.com>
To: Simon Horman <horms@kernel.org>
Cc: Tony Nguyen <anthony.l.nguyen@intel.com>,
Przemek Kitszel <przemyslaw.kitszel@intel.com>,
Andrew Lunn <andrew+netdev@lunn.ch>,
"David S . Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Vladimir Oltean <vladimir.oltean@nxp.com>,
intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org,
Aleksandr Loktionov <aleksandr.loktionov@intel.com>,
Chwee-Lin Choong <chwee.lin.choong@intel.com>
Subject: Re: [Intel-wired-lan] [PATCH iwl-next v2 8/8] igc: SW pad preemptible frames for correct mCRC calculation
Date: Mon, 19 May 2025 14:27:36 +0800 [thread overview]
Message-ID: <12093d3c-ca0a-46fd-950e-6af1448ee079@linux.intel.com> (raw)
In-Reply-To: <20250516094336.GH1898636@horms.kernel.org>
On 16/5/2025 5:43 pm, Simon Horman wrote:
> On Wed, May 14, 2025 at 12:29:45AM -0400, Faizal Rahim wrote:
>> From: Chwee-Lin Choong <chwee.lin.choong@intel.com>
>>
>> A hardware-padded frame transmitted from the preemptible queue
>> results in an incorrect mCRC computation by hardware, as the
>> padding bytes are not included in the mCRC calculation.
>>
>> To address this, manually pad frames in preemptible queues to a
>> minimum length of 60 bytes using skb_padto() before transmission.
>> This ensures that the hardware includes the padding bytes in the
>> mCRC computation, producing a correct mCRC value.
>>
>> Signed-off-by: Chwee-Lin Choong <chwee.lin.choong@intel.com>
>> Signed-off-by: Faizal Rahim <faizal.abdul.rahim@linux.intel.com>
>
> Hi Faizal, all,
>
> Perhaps it would be best to shuffle this patch within this series
> so that it appears before the patches that add pre-emption support.
> That way, when the are added the bug isn't present.
>
Makes sense, will update. Thanks!
WARNING: multiple messages have this Message-ID (diff)
From: "Abdul Rahim, Faizal" <faizal.abdul.rahim@linux.intel.com>
To: Simon Horman <horms@kernel.org>
Cc: Tony Nguyen <anthony.l.nguyen@intel.com>,
Przemek Kitszel <przemyslaw.kitszel@intel.com>,
Andrew Lunn <andrew+netdev@lunn.ch>,
"David S . Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Vladimir Oltean <vladimir.oltean@nxp.com>,
intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org,
Aleksandr Loktionov <aleksandr.loktionov@intel.com>,
Chwee-Lin Choong <chwee.lin.choong@intel.com>
Subject: Re: [PATCH iwl-next v2 8/8] igc: SW pad preemptible frames for correct mCRC calculation
Date: Mon, 19 May 2025 14:27:36 +0800 [thread overview]
Message-ID: <12093d3c-ca0a-46fd-950e-6af1448ee079@linux.intel.com> (raw)
In-Reply-To: <20250516094336.GH1898636@horms.kernel.org>
On 16/5/2025 5:43 pm, Simon Horman wrote:
> On Wed, May 14, 2025 at 12:29:45AM -0400, Faizal Rahim wrote:
>> From: Chwee-Lin Choong <chwee.lin.choong@intel.com>
>>
>> A hardware-padded frame transmitted from the preemptible queue
>> results in an incorrect mCRC computation by hardware, as the
>> padding bytes are not included in the mCRC calculation.
>>
>> To address this, manually pad frames in preemptible queues to a
>> minimum length of 60 bytes using skb_padto() before transmission.
>> This ensures that the hardware includes the padding bytes in the
>> mCRC computation, producing a correct mCRC value.
>>
>> Signed-off-by: Chwee-Lin Choong <chwee.lin.choong@intel.com>
>> Signed-off-by: Faizal Rahim <faizal.abdul.rahim@linux.intel.com>
>
> Hi Faizal, all,
>
> Perhaps it would be best to shuffle this patch within this series
> so that it appears before the patches that add pre-emption support.
> That way, when the are added the bug isn't present.
>
Makes sense, will update. Thanks!
next prev parent reply other threads:[~2025-05-19 6:27 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-14 4:29 [Intel-wired-lan] [PATCH iwl-next v2 0/8] igc: harmonize queue priority and add preemptible queue support Faizal Rahim
2025-05-14 4:29 ` Faizal Rahim
2025-05-14 4:29 ` [Intel-wired-lan] [PATCH iwl-next v2 1/8] igc: move TXDCTL and RXDCTL related macros Faizal Rahim
2025-05-14 4:29 ` Faizal Rahim
2025-05-16 9:44 ` [Intel-wired-lan] " Simon Horman
2025-05-16 9:44 ` Simon Horman
2025-05-14 4:29 ` [Intel-wired-lan] [PATCH iwl-next v2 2/8] igc: add DCTL prefix to " Faizal Rahim
2025-05-14 4:29 ` Faizal Rahim
2025-05-16 9:44 ` [Intel-wired-lan] " Simon Horman
2025-05-16 9:44 ` Simon Horman
2025-05-14 4:29 ` [Intel-wired-lan] [PATCH iwl-next v2 3/8] igc: refactor TXDCTL macros to use FIELD_PREP and GEN_MASK Faizal Rahim
2025-05-14 4:29 ` Faizal Rahim
2025-05-16 9:44 ` [Intel-wired-lan] " Simon Horman
2025-05-16 9:44 ` Simon Horman
2025-05-14 4:29 ` [Intel-wired-lan] [PATCH iwl-next v2 4/8] igc: assign highest TX queue number as highest priority in mqprio Faizal Rahim
2025-05-14 4:29 ` Faizal Rahim
2025-05-16 9:44 ` [Intel-wired-lan] " Simon Horman
2025-05-16 9:44 ` Simon Horman
2025-05-14 4:29 ` [Intel-wired-lan] [PATCH iwl-next v2 5/8] igc: add private flag to reverse TX queue priority in TSN mode Faizal Rahim
2025-05-14 4:29 ` Faizal Rahim
2025-05-16 9:45 ` [Intel-wired-lan] " Simon Horman
2025-05-16 9:45 ` Simon Horman
2025-05-14 4:29 ` [Intel-wired-lan] [PATCH iwl-next v2 6/8] igc: add preemptible queue support in taprio Faizal Rahim
2025-05-14 4:29 ` Faizal Rahim
2025-05-14 4:29 ` [Intel-wired-lan] [PATCH iwl-next v2 7/8] igc: add preemptible queue support in mqprio Faizal Rahim
2025-05-14 4:29 ` Faizal Rahim
2025-05-14 4:29 ` [Intel-wired-lan] [PATCH iwl-next v2 8/8] igc: SW pad preemptible frames for correct mCRC calculation Faizal Rahim
2025-05-14 4:29 ` Faizal Rahim
2025-05-16 9:43 ` [Intel-wired-lan] " Simon Horman
2025-05-16 9:43 ` Simon Horman
2025-05-19 6:27 ` Abdul Rahim, Faizal [this message]
2025-05-19 6:27 ` Abdul Rahim, Faizal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=12093d3c-ca0a-46fd-950e-6af1448ee079@linux.intel.com \
--to=faizal.abdul.rahim@linux.intel.com \
--cc=aleksandr.loktionov@intel.com \
--cc=andrew+netdev@lunn.ch \
--cc=anthony.l.nguyen@intel.com \
--cc=chwee.lin.choong@intel.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=przemyslaw.kitszel@intel.com \
--cc=vladimir.oltean@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.