* [PATCH] ARM: dts: rockchip: initialize rk3066 PLL clock rate
@ 2016-10-06 19:42 ` Paweł Jarosz
0 siblings, 0 replies; 4+ messages in thread
From: Paweł Jarosz @ 2016-10-06 19:42 UTC (permalink / raw)
To: heiko-4mtYJXux2i+zQB+pC5nmwQ, robh+dt-DgEjT+Ai2ygdnm+yROfE0A,
mark.rutland-5wv7dgnIgG8, linux-I+IVW8TIWO2tmTQ+vhA3Yw,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r
Initialize PLL rate while kernel init. No other module does than.
Clock rates are taken from rk3066 TRM. Assigned values are for 125 degrees
celcius operating point.
This gives us performance boost observable for example in mmc transfers.
Signed-off-by: Paweł Jarosz <paweljarosz3691@gmail.com>
---
arch/arm/boot/dts/rk3066a.dtsi | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/arch/arm/boot/dts/rk3066a.dtsi b/arch/arm/boot/dts/rk3066a.dtsi
index 0d0dae3..cf215e8 100644
--- a/arch/arm/boot/dts/rk3066a.dtsi
+++ b/arch/arm/boot/dts/rk3066a.dtsi
@@ -151,6 +151,10 @@
#clock-cells = <1>;
#reset-cells = <1>;
+ assigned-clocks = <&cru PLL_DPLL>, <&cru PLL_APLL>,
+ <&cru PLL_CPLL>, <&cru PLL_GPLL>;
+ assigned-clock-rates = <533000000>, <600000000>,
+ <600000000>, <600000000>;
};
timer@2000e000 {
--
2.7.4
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
^ permalink raw reply related [flat|nested] 4+ messages in thread* [PATCH] ARM: dts: rockchip: initialize rk3066 PLL clock rate
@ 2016-10-06 19:42 ` Paweł Jarosz
0 siblings, 0 replies; 4+ messages in thread
From: Paweł Jarosz @ 2016-10-06 19:42 UTC (permalink / raw)
To: linux-arm-kernel
Initialize PLL rate while kernel init. No other module does than.
Clock rates are taken from rk3066 TRM. Assigned values are for 125 degrees
celcius operating point.
This gives us performance boost observable for example in mmc transfers.
Signed-off-by: Pawe? Jarosz <paweljarosz3691@gmail.com>
---
arch/arm/boot/dts/rk3066a.dtsi | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/arch/arm/boot/dts/rk3066a.dtsi b/arch/arm/boot/dts/rk3066a.dtsi
index 0d0dae3..cf215e8 100644
--- a/arch/arm/boot/dts/rk3066a.dtsi
+++ b/arch/arm/boot/dts/rk3066a.dtsi
@@ -151,6 +151,10 @@
#clock-cells = <1>;
#reset-cells = <1>;
+ assigned-clocks = <&cru PLL_DPLL>, <&cru PLL_APLL>,
+ <&cru PLL_CPLL>, <&cru PLL_GPLL>;
+ assigned-clock-rates = <533000000>, <600000000>,
+ <600000000>, <600000000>;
};
timer at 2000e000 {
--
2.7.4
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] ARM: dts: rockchip: initialize rk3066 PLL clock rate
2016-10-06 19:42 ` Paweł Jarosz
@ 2016-10-11 9:19 ` Heiko Stuebner
-1 siblings, 0 replies; 4+ messages in thread
From: Heiko Stuebner @ 2016-10-11 9:19 UTC (permalink / raw)
To: Paweł Jarosz
Cc: mark.rutland-5wv7dgnIgG8,
linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
robh+dt-DgEjT+Ai2ygdnm+yROfE0A, linux-I+IVW8TIWO2tmTQ+vhA3Yw,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r
Am Donnerstag, 6. Oktober 2016, 21:42:21 CEST schrieb Paweł Jarosz:
> Initialize PLL rate while kernel init. No other module does than.
> Clock rates are taken from rk3066 TRM. Assigned values are for 125 degrees
> celcius operating point.
> This gives us performance boost observable for example in mmc transfers.
>
> Signed-off-by: Paweł Jarosz <paweljarosz3691@gmail.com>
> ---
> arch/arm/boot/dts/rk3066a.dtsi | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/arch/arm/boot/dts/rk3066a.dtsi b/arch/arm/boot/dts/rk3066a.dtsi
> index 0d0dae3..cf215e8 100644
> --- a/arch/arm/boot/dts/rk3066a.dtsi
> +++ b/arch/arm/boot/dts/rk3066a.dtsi
> @@ -151,6 +151,10 @@
>
> #clock-cells = <1>;
> #reset-cells = <1>;
> + assigned-clocks = <&cru PLL_DPLL>, <&cru PLL_APLL>,
we shouldn't touch the DPLL and APLL at all in this context. They are quite
reliant on the underlying voltages and the bootloader might've set other
values. Also changing the DDR frequency through the DPLL requires special
handling on the DDR side.
> + <&cru PLL_CPLL>, <&cru PLL_GPLL>;
please also initialize the PERI and BUS clocks (similar to what the rk3288 clk
settings do), so that they stay sane, even if we change CPLL and GPLL
frequencies.
> + assigned-clock-rates = <533000000>, <600000000>,
> + <600000000>, <600000000>;
Also setting both CPLL and GPLL to the same value might be unhelpful to
achieve special divided frequencies? Again see rk3288.dtsi where we have a 594
/ 400 MHz division. Especially the downstream clocks normally can select
between CPLL and GPLL.
Heiko
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH] ARM: dts: rockchip: initialize rk3066 PLL clock rate
@ 2016-10-11 9:19 ` Heiko Stuebner
0 siblings, 0 replies; 4+ messages in thread
From: Heiko Stuebner @ 2016-10-11 9:19 UTC (permalink / raw)
To: linux-arm-kernel
Am Donnerstag, 6. Oktober 2016, 21:42:21 CEST schrieb Pawe? Jarosz:
> Initialize PLL rate while kernel init. No other module does than.
> Clock rates are taken from rk3066 TRM. Assigned values are for 125 degrees
> celcius operating point.
> This gives us performance boost observable for example in mmc transfers.
>
> Signed-off-by: Pawe? Jarosz <paweljarosz3691@gmail.com>
> ---
> arch/arm/boot/dts/rk3066a.dtsi | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/arch/arm/boot/dts/rk3066a.dtsi b/arch/arm/boot/dts/rk3066a.dtsi
> index 0d0dae3..cf215e8 100644
> --- a/arch/arm/boot/dts/rk3066a.dtsi
> +++ b/arch/arm/boot/dts/rk3066a.dtsi
> @@ -151,6 +151,10 @@
>
> #clock-cells = <1>;
> #reset-cells = <1>;
> + assigned-clocks = <&cru PLL_DPLL>, <&cru PLL_APLL>,
we shouldn't touch the DPLL and APLL at all in this context. They are quite
reliant on the underlying voltages and the bootloader might've set other
values. Also changing the DDR frequency through the DPLL requires special
handling on the DDR side.
> + <&cru PLL_CPLL>, <&cru PLL_GPLL>;
please also initialize the PERI and BUS clocks (similar to what the rk3288 clk
settings do), so that they stay sane, even if we change CPLL and GPLL
frequencies.
> + assigned-clock-rates = <533000000>, <600000000>,
> + <600000000>, <600000000>;
Also setting both CPLL and GPLL to the same value might be unhelpful to
achieve special divided frequencies? Again see rk3288.dtsi where we have a 594
/ 400 MHz division. Especially the downstream clocks normally can select
between CPLL and GPLL.
Heiko
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2016-10-11 9:19 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-10-06 19:42 [PATCH] ARM: dts: rockchip: initialize rk3066 PLL clock rate Paweł Jarosz
2016-10-06 19:42 ` Paweł Jarosz
2016-10-11 9:19 ` Heiko Stuebner
2016-10-11 9:19 ` Heiko Stuebner
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.