* Re: [PATCH stable] libertas: Extend CMD_MESH_CONFIG to get and set persistent mesh default params. [not found] <482c8eb8.0b97600a.08e2.ffff8ee3@mx.google.com> @ 2008-05-16 14:09 ` David Woodhouse 2008-05-16 14:50 ` Johannes Berg 0 siblings, 1 reply; 4+ messages in thread From: David Woodhouse @ 2008-05-16 14:09 UTC (permalink / raw) To: Brian Cavagnolo Cc: devel, libertas-dev, linux-wireless, Andres Salomon, Javier Cardona, Ricardo Carrano On Thu, 2008-05-15 at 11:01 -0700, Brian Cavagnolo wrote: > This patch is based on a patch from Shailendra Govardhan. It introduces > several new iwprivs: {get,set}_bootflag {get,set}_boottime {get,set}_def_chan > {get,set}_def_protid {get,set}_def_metid {get,set}_def_meshcap > {get,set}_def_meshid. These commands are only supported on Marvell hardware > that implements persistent defaults, such as the OLPC Active Antenna. > Accordingly, this patch may not be suitable for upstream merging. > > See http://dev.laptop.org/ticket/6823 for minimal testing results and known > issues. See http://www.laptop.org/teamwiki/index.php/Tech:Wireless#Firmware_image_which_stores_the_mesh_parameters_in_flash for iwpriv documentation. > > Signed-off-by: Brian Cavagnolo <brian@cozybit.com> > --- Hm. I was intending to veto the addition of any more private ioctls to the olpc tree, because they all need fixing to use cfg80211 or something else upstream, and we only make pain for ourselves by adding to the divergence -- adding new APIs to userspace when we _know_ are going to have to change them is just silly. But this is the _one_ thing which might actually be OK to do with a private ioctl, since it's very hardware-specific. Unlike like all the mesh-mangling stuff where we really ought to be compatible with o11s. So maybe, just maybe, we _can_ do this with iwpriv and push that upstream. If you want to revamp the patch to apply to the upstream kernel and see what people think of it, go ahead. -- dwmw2 ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH stable] libertas: Extend CMD_MESH_CONFIG to get and set persistent mesh default params. 2008-05-16 14:09 ` [PATCH stable] libertas: Extend CMD_MESH_CONFIG to get and set persistent mesh default params David Woodhouse @ 2008-05-16 14:50 ` Johannes Berg 2008-05-16 15:51 ` Stefanik Gábor 0 siblings, 1 reply; 4+ messages in thread From: Johannes Berg @ 2008-05-16 14:50 UTC (permalink / raw) To: David Woodhouse Cc: Brian Cavagnolo, devel, libertas-dev, linux-wireless, Andres Salomon, Javier Cardona, Ricardo Carrano [-- Attachment #1: Type: text/plain, Size: 1050 bytes --] On Fri, 2008-05-16 at 15:09 +0100, David Woodhouse wrote: > On Thu, 2008-05-15 at 11:01 -0700, Brian Cavagnolo wrote: > > This patch is based on a patch from Shailendra Govardhan. It introduces > > several new iwprivs: {get,set}_bootflag {get,set}_boottime {get,set}_def_chan > > {get,set}_def_protid {get,set}_def_metid {get,set}_def_meshcap > > {get,set}_def_meshid. These commands are only supported on Marvell hardware > > that implements persistent defaults, such as the OLPC Active Antenna. > > Accordingly, this patch may not be suitable for upstream merging. > But this is the _one_ thing which might actually be OK to do with a > private ioctl, since it's very hardware-specific. Unlike like all the > mesh-mangling stuff where we really ought to be compatible with o11s. > > So maybe, just maybe, we _can_ do this with iwpriv and push that > upstream. Maybe we do, after all, need an iwpriv equivalent in cfg80211/nl80211 so that we can kill wext at some point. Or maybe this should be in sysfs or so? johannes [-- Attachment #2: This is a digitally signed message part --] [-- Type: application/pgp-signature, Size: 828 bytes --] ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH stable] libertas: Extend CMD_MESH_CONFIG to get and set persistent mesh default params. 2008-05-16 14:50 ` Johannes Berg @ 2008-05-16 15:51 ` Stefanik Gábor 2008-05-13 15:54 ` Dan Williams 0 siblings, 1 reply; 4+ messages in thread From: Stefanik Gábor @ 2008-05-16 15:51 UTC (permalink / raw) To: Johannes Berg Cc: David Woodhouse, Brian Cavagnolo, devel, libertas-dev, linux-wireless, Andres Salomon, Javier Cardona, Ricardo Carrano On Fri, May 16, 2008 at 4:50 PM, Johannes Berg <johannes@sipsolutions.net> wrote: > On Fri, 2008-05-16 at 15:09 +0100, David Woodhouse wrote: >> On Thu, 2008-05-15 at 11:01 -0700, Brian Cavagnolo wrote: >> > This patch is based on a patch from Shailendra Govardhan. It introduces >> > several new iwprivs: {get,set}_bootflag {get,set}_boottime {get,set}_def_chan >> > {get,set}_def_protid {get,set}_def_metid {get,set}_def_meshcap >> > {get,set}_def_meshid. These commands are only supported on Marvell hardware >> > that implements persistent defaults, such as the OLPC Active Antenna. >> > Accordingly, this patch may not be suitable for upstream merging. > >> But this is the _one_ thing which might actually be OK to do with a >> private ioctl, since it's very hardware-specific. Unlike like all the >> mesh-mangling stuff where we really ought to be compatible with o11s. >> >> So maybe, just maybe, we _can_ do this with iwpriv and push that >> upstream. > > Maybe we do, after all, need an iwpriv equivalent in cfg80211/nl80211 so > that we can kill wext at some point. > > Or maybe this should be in sysfs or so? > > johannes > Or maybe in configfs? That's a better place for configuration options. (BTW rt2x00 uses debugfs as an iwpriv replacement, so that's another possibility.) -- Vista: [V]iruses, [I]ntruders, [S]pyware, [T]rojans and [A]dware. :-) ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH stable] libertas: Extend CMD_MESH_CONFIG to get and set persistent mesh default params. 2008-05-16 15:51 ` Stefanik Gábor @ 2008-05-13 15:54 ` Dan Williams 0 siblings, 0 replies; 4+ messages in thread From: Dan Williams @ 2008-05-13 15:54 UTC (permalink / raw) To: Stefanik Gábor Cc: Johannes Berg, David Woodhouse, Brian Cavagnolo, devel, libertas-dev, linux-wireless, Andres Salomon, Javier Cardona, Ricardo Carrano On Fri, 2008-05-16 at 17:51 +0200, Stefanik G=C3=A1bor wrote: > On Fri, May 16, 2008 at 4:50 PM, Johannes Berg > <johannes@sipsolutions.net> wrote: > > On Fri, 2008-05-16 at 15:09 +0100, David Woodhouse wrote: > >> On Thu, 2008-05-15 at 11:01 -0700, Brian Cavagnolo wrote: > >> > This patch is based on a patch from Shailendra Govardhan. It in= troduces > >> > several new iwprivs: {get,set}_bootflag {get,set}_boottime {get,= set}_def_chan > >> > {get,set}_def_protid {get,set}_def_metid {get,set}_def_meshcap > >> > {get,set}_def_meshid. These commands are only supported on Marv= ell hardware > >> > that implements persistent defaults, such as the OLPC Active Ant= enna. > >> > Accordingly, this patch may not be suitable for upstream merging= =2E > > > >> But this is the _one_ thing which might actually be OK to do with = a > >> private ioctl, since it's very hardware-specific. Unlike like all = the > >> mesh-mangling stuff where we really ought to be compatible with o1= 1s. > >> > >> So maybe, just maybe, we _can_ do this with iwpriv and push that > >> upstream. > > > > Maybe we do, after all, need an iwpriv equivalent in cfg80211/nl802= 11 so > > that we can kill wext at some point. > > > > Or maybe this should be in sysfs or so? > > > > johannes > > >=20 > Or maybe in configfs? That's a better place for configuration options= =2E > (BTW rt2x00 uses debugfs as an iwpriv replacement, so that's another > possibility.) I keep proposing debugfs too, but in some cases the commands aren't jus= t for poking around with stuff. configfs is probably a better answer to tweakables that aren't just ricer-geekporn. Dan -- To unsubscribe from this list: send the line "unsubscribe linux-wireles= s" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2008-05-16 15:54 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <482c8eb8.0b97600a.08e2.ffff8ee3@mx.google.com>
2008-05-16 14:09 ` [PATCH stable] libertas: Extend CMD_MESH_CONFIG to get and set persistent mesh default params David Woodhouse
2008-05-16 14:50 ` Johannes Berg
2008-05-16 15:51 ` Stefanik Gábor
2008-05-13 15:54 ` Dan Williams
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.