All of lore.kernel.org
 help / color / mirror / Atom feed
From: Matt Mackall <mpm@selenic.com>
To: Dave Hansen <dave@linux.vnet.ibm.com>
Cc: Hans Rosenfeld <hans.rosenfeld@amd.com>,
	Hugh Dickins <hugh@veritas.com>,
	Nishanth Aravamudan <nacc@us.ibm.com>,
	Ingo Molnar <mingo@elte.hu>,
	Jeff Chua <jeff.chua.linux@gmail.com>,
	Thomas Gleixner <tglx@linutronix.de>,
	"H. Peter Anvin" <hpa@zytor.com>,
	Gabriel C <nix.or.die@googlemail.com>,
	Arjan van de Ven <arjan@linux.intel.com>,
	linux-kernel@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [PATCH] x86: fix PAE pmd_bad bootup warning
Date: Wed, 14 May 2008 14:01:41 -0500	[thread overview]
Message-ID: <1210791701.4093.29.camel@calx> (raw)
In-Reply-To: <1210288532.7905.89.camel@nimitz.home.sr71.net>


On Thu, 2008-05-08 at 16:15 -0700, Dave Hansen wrote:
> Here's one quick stab at a solution.  I figured that we already pass
> that 'private' variable around.  This patch just sticks that variable
> *in* the mm_walk and also makes the caller fill in an 'mm' as well.
> Then, we just pass the actual mm_walk around.
> 
> Maybe we should just stick the VMA in the mm_walk as well, and have the
> common code keep it up to date with the addresses currently being
> walked.
> 
> Sadly, I didn't quite get enough time to flesh this idea out very far
> today, and I'll be offline for a couple of days now.  But, if someone
> wants to go this route, I thought this might be useful.  

This much looks reasonable. But the real test of course is to actually
teach it about detecting huge pages efficiently. And I suspect that
means tracking the current VMA all the time in the walk. Am I wrong?

-- 
Mathematics is the supreme nostalgia of our time.


WARNING: multiple messages have this Message-ID (diff)
From: Matt Mackall <mpm@selenic.com>
To: Dave Hansen <dave@linux.vnet.ibm.com>
Cc: Hans Rosenfeld <hans.rosenfeld@amd.com>,
	Hugh Dickins <hugh@veritas.com>,
	Nishanth Aravamudan <nacc@us.ibm.com>,
	Ingo Molnar <mingo@elte.hu>,
	Jeff Chua <jeff.chua.linux@gmail.com>,
	Thomas Gleixner <tglx@linutronix.de>,
	"H. Peter Anvin" <hpa@zytor.com>,
	Gabriel C <nix.or.die@googlemail.com>,
	Arjan van de Ven <arjan@linux.intel.com>,
	linux-kernel@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [PATCH] x86: fix PAE pmd_bad bootup warning
Date: Wed, 14 May 2008 14:01:41 -0500	[thread overview]
Message-ID: <1210791701.4093.29.camel@calx> (raw)
In-Reply-To: <1210288532.7905.89.camel@nimitz.home.sr71.net>

On Thu, 2008-05-08 at 16:15 -0700, Dave Hansen wrote:
> Here's one quick stab at a solution.  I figured that we already pass
> that 'private' variable around.  This patch just sticks that variable
> *in* the mm_walk and also makes the caller fill in an 'mm' as well.
> Then, we just pass the actual mm_walk around.
> 
> Maybe we should just stick the VMA in the mm_walk as well, and have the
> common code keep it up to date with the addresses currently being
> walked.
> 
> Sadly, I didn't quite get enough time to flesh this idea out very far
> today, and I'll be offline for a couple of days now.  But, if someone
> wants to go this route, I thought this might be useful.  

This much looks reasonable. But the real test of course is to actually
teach it about detecting huge pages efficiently. And I suspect that
means tracking the current VMA all the time in the walk. Am I wrong?

-- 
Mathematics is the supreme nostalgia of our time.

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  reply	other threads:[~2008-05-14 19:02 UTC|newest]

Thread overview: 75+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-05-06  1:06 Linux 2.6.26-rc1 - pgtable_32.c:178 pmd_bad Jeff Chua
2008-05-06 12:49 ` Ingo Molnar
2008-05-06 13:56   ` Hugh Dickins
2008-05-06 15:04     ` Ingo Molnar
2008-05-06 15:09       ` Linus Torvalds
2008-05-06 15:15         ` Ingo Molnar
2008-05-06 16:16           ` Linus Torvalds
2008-05-06 16:30             ` Ingo Molnar
2008-05-06 15:32         ` Jeremy Fitzhardinge
2008-05-06 16:12           ` Hugh Dickins
2008-05-06 18:39     ` Linus Torvalds
2008-05-06 19:43       ` Hugh Dickins
2008-05-06 19:49       ` [PATCH] x86: fix PAE pmd_bad bootup warning Hugh Dickins
2008-05-06 19:49         ` Hugh Dickins
2008-05-06 20:06         ` Linus Torvalds
2008-05-06 20:06           ` Linus Torvalds
2008-05-06 20:30           ` Hugh Dickins
2008-05-06 20:30             ` Hugh Dickins
2008-05-08 16:07             ` Nishanth Aravamudan
2008-05-08 16:07               ` Nishanth Aravamudan
2008-05-06 20:22         ` Hans Rosenfeld
2008-05-06 20:22           ` Hans Rosenfeld
2008-05-06 20:36           ` Hugh Dickins
2008-05-06 20:36             ` Hugh Dickins
2008-05-07 23:39             ` Nishanth Aravamudan
2008-05-07 23:39               ` Nishanth Aravamudan
2008-05-06 20:42           ` Dave Hansen
2008-05-06 20:42             ` Dave Hansen
2008-05-08 14:34             ` Hans Rosenfeld
2008-05-08 14:34               ` Hans Rosenfeld
2008-05-08 14:39               ` Hans Rosenfeld
2008-05-08 14:52               ` Dave Hansen
2008-05-08 14:52                 ` Dave Hansen
2008-05-08 15:11                 ` Hans Rosenfeld
2008-05-08 15:11                   ` Hans Rosenfeld
2008-05-08 15:51                   ` Dave Hansen
2008-05-08 15:51                     ` Dave Hansen
2008-05-08 16:19                     ` Hans Rosenfeld
2008-05-08 16:19                       ` Hans Rosenfeld
2008-05-08 16:33                       ` Nishanth Aravamudan
2008-05-08 16:33                         ` Nishanth Aravamudan
2008-05-08 16:51                         ` Hans Rosenfeld
2008-05-08 16:51                           ` Hans Rosenfeld
2008-05-08 17:16                           ` Nishanth Aravamudan
2008-05-08 17:16                             ` Nishanth Aravamudan
2008-05-08 18:42                             ` Dave Hansen
2008-05-08 18:42                               ` Dave Hansen
2008-05-08 18:58                               ` Hugh Dickins
2008-05-08 18:58                                 ` Hugh Dickins
2008-05-08 19:06                                 ` Dave Hansen
2008-05-08 19:06                                   ` Dave Hansen
2008-05-08 18:48                             ` Hugh Dickins
2008-05-08 18:48                               ` Hugh Dickins
2008-05-08 19:49                               ` Matt Mackall
2008-05-08 19:49                                 ` Matt Mackall
2008-05-08 20:08                                 ` Dave Hansen
2008-05-08 20:08                                   ` Dave Hansen
2008-05-08 20:02                               ` Hans Rosenfeld
2008-05-08 20:02                                 ` Hans Rosenfeld
2008-05-08 20:16                                 ` Dave Hansen
2008-05-08 20:16                                   ` Dave Hansen
2008-05-08 23:15                                 ` Dave Hansen
2008-05-08 23:15                                   ` Dave Hansen
2008-05-14 19:01                                   ` Matt Mackall [this message]
2008-05-14 19:01                                     ` Matt Mackall
2008-05-09  9:03                                 ` Paul Mundt
2008-05-09  9:03                                   ` Paul Mundt
2008-05-08 16:42                       ` Dave Hansen
2008-05-08 16:42                         ` Dave Hansen
2008-05-08 15:44                 ` Nishanth Aravamudan
2008-05-08 15:44                   ` Nishanth Aravamudan
2008-05-07  4:40         ` Jeff Chua
2008-05-07  4:40           ` Jeff Chua
2008-05-07  5:30           ` Hugh Dickins
2008-05-07  5:30             ` Hugh Dickins

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1210791701.4093.29.camel@calx \
    --to=mpm@selenic.com \
    --cc=arjan@linux.intel.com \
    --cc=dave@linux.vnet.ibm.com \
    --cc=hans.rosenfeld@amd.com \
    --cc=hpa@zytor.com \
    --cc=hugh@veritas.com \
    --cc=jeff.chua.linux@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mingo@elte.hu \
    --cc=nacc@us.ibm.com \
    --cc=nix.or.die@googlemail.com \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.