All of lore.kernel.org
 help / color / mirror / Atom feed
From: Adam Litke <agl@us.ibm.com>
To: Adrian Bunk <bunk@kernel.org>
Cc: linux-mm <linux-mm@kvack.org>,
	npiggin@suse.de, nacc@us.ibm.com, mel@csn.ul.ie,
	Eric B Munson <ebmunson@us.ibm.com>,
	linux-kernel@vger.kernel.org, linux-ia64@vger.kernel.org,
	linuxppc-dev@ozlabs.org, sparclinux@vger.kernel.org,
	linux-sh@vger.kernel.org, linux-s390@vger.kernel.org,
	linux-mips@linux-mips.org
Subject: Re: [RFC PATCH 2/2] Update defconfigs for CONFIG_HUGETLB
Date: Fri, 13 Jun 2008 18:12:08 +0000	[thread overview]
Message-ID: <1213380728.15016.8.camel@localhost.localdomain> (raw)
In-Reply-To: <20080612193638.GB17231@cs181133002.pp.htv.fi>

On Thu, 2008-06-12 at 22:36 +0300, Adrian Bunk wrote:
> On Thu, Jun 12, 2008 at 02:55:45PM -0400, Adam Litke wrote:
> > Update all defconfigs that specify a default configuration for hugetlbfs.
> > There is now only one option: CONFIG_HUGETLB.  Replace the old
> > CONFIG_HUGETLB_PAGE and CONFIG_HUGETLBFS options with the new one.  I found no
> > cases where CONFIG_HUGETLBFS and CONFIG_HUGETLB_PAGE had different values so
> > this patch is large but completely mechanical:
> >...
> >  335 files changed, 335 insertions(+), 385 deletions(-)
> >...
> 
> Please don't do this kind of patches - it doesn't bring any advantage 
> but can create tons of patch conflicts.
> 
> The next time a defconfig gets updated it will anyway automatically be 
> fixed, and for defconfigs that aren't updated it doesn't create any 
> problems to keep them as they are today until they might one day get 
> updated.

Thanks for taking a look.  I am not sure if I have ever seen a defconfig
patch hit the mailing list before and I was wondering how those changes
happen.  In any case I am perfectly happy to drop this huge patch and
stick with just the first one.

-- 
Adam Litke - (agl at us.ibm.com)
IBM Linux Technology Center


WARNING: multiple messages have this Message-ID (diff)
From: Adam Litke <agl@us.ibm.com>
To: Adrian Bunk <bunk@kernel.org>
Cc: linux-mm <linux-mm@kvack.org>,
	npiggin@suse.de, nacc@us.ibm.com, mel@csn.ul.ie,
	Eric B Munson <ebmunson@us.ibm.com>,
	linux-kernel@vger.kernel.org, linux-ia64@vger.kernel.org,
	linuxppc-dev@ozlabs.org, sparclinux@vger.kernel.org,
	linux-sh@vger.kernel.org, linux-s390@vger.kernel.org,
	linux-mips@linux-mips.org
Subject: Re: [RFC PATCH 2/2] Update defconfigs for CONFIG_HUGETLB
Date: Fri, 13 Jun 2008 14:12:08 -0400	[thread overview]
Message-ID: <1213380728.15016.8.camel@localhost.localdomain> (raw)
In-Reply-To: <20080612193638.GB17231@cs181133002.pp.htv.fi>

On Thu, 2008-06-12 at 22:36 +0300, Adrian Bunk wrote:
> On Thu, Jun 12, 2008 at 02:55:45PM -0400, Adam Litke wrote:
> > Update all defconfigs that specify a default configuration for hugetlbfs.
> > There is now only one option: CONFIG_HUGETLB.  Replace the old
> > CONFIG_HUGETLB_PAGE and CONFIG_HUGETLBFS options with the new one.  I found no
> > cases where CONFIG_HUGETLBFS and CONFIG_HUGETLB_PAGE had different values so
> > this patch is large but completely mechanical:
> >...
> >  335 files changed, 335 insertions(+), 385 deletions(-)
> >...
> 
> Please don't do this kind of patches - it doesn't bring any advantage 
> but can create tons of patch conflicts.
> 
> The next time a defconfig gets updated it will anyway automatically be 
> fixed, and for defconfigs that aren't updated it doesn't create any 
> problems to keep them as they are today until they might one day get 
> updated.

Thanks for taking a look.  I am not sure if I have ever seen a defconfig
patch hit the mailing list before and I was wondering how those changes
happen.  In any case I am perfectly happy to drop this huge patch and
stick with just the first one.

-- 
Adam Litke - (agl at us.ibm.com)
IBM Linux Technology Center

WARNING: multiple messages have this Message-ID (diff)
From: Adam Litke <agl@us.ibm.com>
To: Adrian Bunk <bunk@kernel.org>
Cc: npiggin@suse.de, linux-s390@vger.kernel.org,
	linux-ia64@vger.kernel.org, linuxppc-dev@ozlabs.org,
	mel@csn.ul.ie, linux-sh@vger.kernel.org,
	linux-kernel@vger.kernel.org, linux-mm <linux-mm@kvack.org>,
	linux-mips@linux-mips.org, nacc@us.ibm.com,
	sparclinux@vger.kernel.org, Eric B Munson <ebmunson@us.ibm.com>
Subject: Re: [RFC PATCH 2/2] Update defconfigs for CONFIG_HUGETLB
Date: Fri, 13 Jun 2008 14:12:08 -0400	[thread overview]
Message-ID: <1213380728.15016.8.camel@localhost.localdomain> (raw)
In-Reply-To: <20080612193638.GB17231@cs181133002.pp.htv.fi>

On Thu, 2008-06-12 at 22:36 +0300, Adrian Bunk wrote:
> On Thu, Jun 12, 2008 at 02:55:45PM -0400, Adam Litke wrote:
> > Update all defconfigs that specify a default configuration for hugetlbfs.
> > There is now only one option: CONFIG_HUGETLB.  Replace the old
> > CONFIG_HUGETLB_PAGE and CONFIG_HUGETLBFS options with the new one.  I found no
> > cases where CONFIG_HUGETLBFS and CONFIG_HUGETLB_PAGE had different values so
> > this patch is large but completely mechanical:
> >...
> >  335 files changed, 335 insertions(+), 385 deletions(-)
> >...
> 
> Please don't do this kind of patches - it doesn't bring any advantage 
> but can create tons of patch conflicts.
> 
> The next time a defconfig gets updated it will anyway automatically be 
> fixed, and for defconfigs that aren't updated it doesn't create any 
> problems to keep them as they are today until they might one day get 
> updated.

Thanks for taking a look.  I am not sure if I have ever seen a defconfig
patch hit the mailing list before and I was wondering how those changes
happen.  In any case I am perfectly happy to drop this huge patch and
stick with just the first one.

-- 
Adam Litke - (agl at us.ibm.com)
IBM Linux Technology Center

WARNING: multiple messages have this Message-ID (diff)
From: Adam Litke <agl@us.ibm.com>
To: Adrian Bunk <bunk@kernel.org>
Cc: linux-mm <linux-mm@kvack.org>,
	npiggin@suse.de, nacc@us.ibm.com, mel@csn.ul.ie,
	Eric B Munson <ebmunson@us.ibm.com>,
	linux-kernel@vger.kernel.org, linux-ia64@vger.kernel.org,
	linuxppc-dev@ozlabs.org, sparclinux@vger.kernel.org,
	linux-sh@vger.kernel.org, linux-s390@vger.kernel.org,
	linux-mips@linux-mips.org
Subject: Re: [RFC PATCH 2/2] Update defconfigs for CONFIG_HUGETLB
Date: Fri, 13 Jun 2008 14:12:08 -0400	[thread overview]
Message-ID: <1213380728.15016.8.camel@localhost.localdomain> (raw)
In-Reply-To: <20080612193638.GB17231@cs181133002.pp.htv.fi>

On Thu, 2008-06-12 at 22:36 +0300, Adrian Bunk wrote:
> On Thu, Jun 12, 2008 at 02:55:45PM -0400, Adam Litke wrote:
> > Update all defconfigs that specify a default configuration for hugetlbfs.
> > There is now only one option: CONFIG_HUGETLB.  Replace the old
> > CONFIG_HUGETLB_PAGE and CONFIG_HUGETLBFS options with the new one.  I found no
> > cases where CONFIG_HUGETLBFS and CONFIG_HUGETLB_PAGE had different values so
> > this patch is large but completely mechanical:
> >...
> >  335 files changed, 335 insertions(+), 385 deletions(-)
> >...
> 
> Please don't do this kind of patches - it doesn't bring any advantage 
> but can create tons of patch conflicts.
> 
> The next time a defconfig gets updated it will anyway automatically be 
> fixed, and for defconfigs that aren't updated it doesn't create any 
> problems to keep them as they are today until they might one day get 
> updated.

Thanks for taking a look.  I am not sure if I have ever seen a defconfig
patch hit the mailing list before and I was wondering how those changes
happen.  In any case I am perfectly happy to drop this huge patch and
stick with just the first one.

-- 
Adam Litke - (agl at us.ibm.com)
IBM Linux Technology Center

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  reply	other threads:[~2008-06-13 18:12 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-06-12 18:49 [RFC PATCH 0/2] Merge HUGETLB_PAGE and HUGETLBFS Kconfig options Adam Litke
2008-06-12 18:49 ` Adam Litke
2008-06-12 18:49 ` Adam Litke
2008-06-12 18:49 ` Adam Litke
2008-06-12 18:53 ` [RFC PATCH 1/2] Merge options into CONFIG_HUGETLB Adam Litke
2008-06-12 18:53   ` Adam Litke
2008-06-12 18:53   ` Adam Litke
2008-06-12 18:53   ` Adam Litke
2008-06-12 18:55 ` [RFC PATCH 2/2] Update defconfigs for CONFIG_HUGETLB Adam Litke
2008-06-12 18:55   ` Adam Litke
2008-06-12 18:55   ` Adam Litke
2008-06-12 18:55   ` Adam Litke
2008-06-12 19:36   ` Adrian Bunk
2008-06-12 19:36     ` Adrian Bunk
2008-06-12 19:36     ` Adrian Bunk
2008-06-12 19:36     ` Adrian Bunk
2008-06-13 18:12     ` Adam Litke [this message]
2008-06-13 18:12       ` Adam Litke
2008-06-13 18:12       ` Adam Litke
2008-06-13 18:12       ` Adam Litke
2008-06-13 13:46 ` [RFC PATCH 0/2] Merge HUGETLB_PAGE and HUGETLBFS Kconfig Ralf Baechle
2008-06-13 13:46   ` [RFC PATCH 0/2] Merge HUGETLB_PAGE and HUGETLBFS Kconfig options Ralf Baechle
2008-06-13 13:46   ` Ralf Baechle
2008-06-13 13:46   ` Ralf Baechle
2008-06-13 14:03   ` [RFC PATCH 0/2] Merge HUGETLB_PAGE and HUGETLBFS Kconfig Adam Litke
2008-06-13 14:03     ` [RFC PATCH 0/2] Merge HUGETLB_PAGE and HUGETLBFS Kconfig options Adam Litke
2008-06-13 14:03     ` Adam Litke
2008-06-13 14:03     ` Adam Litke

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1213380728.15016.8.camel@localhost.localdomain \
    --to=agl@us.ibm.com \
    --cc=bunk@kernel.org \
    --cc=ebmunson@us.ibm.com \
    --cc=linux-ia64@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mips@linux-mips.org \
    --cc=linux-mm@kvack.org \
    --cc=linux-s390@vger.kernel.org \
    --cc=linux-sh@vger.kernel.org \
    --cc=linuxppc-dev@ozlabs.org \
    --cc=mel@csn.ul.ie \
    --cc=nacc@us.ibm.com \
    --cc=npiggin@suse.de \
    --cc=sparclinux@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.