From: Ralf Baechle <ralf@linux-mips.org>
To: Adam Litke <agl@us.ibm.com>
Cc: linux-mm <linux-mm@kvack.org>,
npiggin@suse.de, nacc@us.ibm.com, mel@csn.ul.ie,
Eric B Munson <ebmunson@us.ibm.com>,
linux-kernel@vger.kernel.org, linux-ia64@vger.kernel.org,
linuxppc-dev@ozlabs.org, sparclinux@vger.kernel.org,
linux-sh@vger.kernel.org, linux-s390@vger.kernel.org,
linux-mips@linux-mips.org
Subject: Re: [RFC PATCH 0/2] Merge HUGETLB_PAGE and HUGETLBFS Kconfig
Date: Fri, 13 Jun 2008 13:46:29 +0000 [thread overview]
Message-ID: <20080613134629.GD16344@linux-mips.org> (raw)
In-Reply-To: <1213296540.17108.8.camel@localhost.localdomain>
On Thu, Jun 12, 2008 at 02:49:00PM -0400, Adam Litke wrote:
> There are currently two global Kconfig options that enable/disable the
> hugetlb code: CONFIG_HUGETLB_PAGE and CONFIG_HUGETLBFS. This may have
> made sense before hugetlbfs became ubiquitous but now the pair of
> options are redundant. Merging these two options into one will simplify
> the code slightly and will, more importantly, avoid confusion and
> questions like: Which hugetlbfs CONFIG option should my code depend on?
>
> CONFIG_HUGETLB_PAGE is aliased to the value of CONFIG_HUGETLBFS, so one
> option can be removed without any effect. The first patch merges the
> two options into one option: CONFIG_HUGETLB. The second patch updates
> the defconfigs to set the one new option appropriately.
>
> I have cross-compiled this on i386, x86_64, ia64, powerpc, sparc64 and
> sh with the option enabled and disabled. This is completely mechanical
> but, due to the large number of files affected (especially defconfigs),
> could do well with a review from several sets of eyeballs. Thanks.
MIPS doesn't do HUGETLB (at least not in-tree atm) so I'm not sure why
linux-mips@linux-mips.org was cc'ed at all. So feel free to add my
Couldnt-care-less: ack line ;-)
Ralf
WARNING: multiple messages have this Message-ID (diff)
From: Ralf Baechle <ralf@linux-mips.org>
To: Adam Litke <agl@us.ibm.com>
Cc: linux-mm <linux-mm@kvack.org>,
npiggin@suse.de, nacc@us.ibm.com, mel@csn.ul.ie,
Eric B Munson <ebmunson@us.ibm.com>,
linux-kernel@vger.kernel.org, linux-ia64@vger.kernel.org,
linuxppc-dev@ozlabs.org, sparclinux@vger.kernel.org,
linux-sh@vger.kernel.org, linux-s390@vger.kernel.org,
linux-mips@linux-mips.org
Subject: Re: [RFC PATCH 0/2] Merge HUGETLB_PAGE and HUGETLBFS Kconfig options
Date: Fri, 13 Jun 2008 14:46:29 +0100 [thread overview]
Message-ID: <20080613134629.GD16344@linux-mips.org> (raw)
In-Reply-To: <1213296540.17108.8.camel@localhost.localdomain>
On Thu, Jun 12, 2008 at 02:49:00PM -0400, Adam Litke wrote:
> There are currently two global Kconfig options that enable/disable the
> hugetlb code: CONFIG_HUGETLB_PAGE and CONFIG_HUGETLBFS. This may have
> made sense before hugetlbfs became ubiquitous but now the pair of
> options are redundant. Merging these two options into one will simplify
> the code slightly and will, more importantly, avoid confusion and
> questions like: Which hugetlbfs CONFIG option should my code depend on?
>
> CONFIG_HUGETLB_PAGE is aliased to the value of CONFIG_HUGETLBFS, so one
> option can be removed without any effect. The first patch merges the
> two options into one option: CONFIG_HUGETLB. The second patch updates
> the defconfigs to set the one new option appropriately.
>
> I have cross-compiled this on i386, x86_64, ia64, powerpc, sparc64 and
> sh with the option enabled and disabled. This is completely mechanical
> but, due to the large number of files affected (especially defconfigs),
> could do well with a review from several sets of eyeballs. Thanks.
MIPS doesn't do HUGETLB (at least not in-tree atm) so I'm not sure why
linux-mips@linux-mips.org was cc'ed at all. So feel free to add my
Couldnt-care-less: ack line ;-)
Ralf
WARNING: multiple messages have this Message-ID (diff)
From: Ralf Baechle <ralf@linux-mips.org>
To: Adam Litke <agl@us.ibm.com>
Cc: npiggin@suse.de, linux-s390@vger.kernel.org,
linux-ia64@vger.kernel.org, linuxppc-dev@ozlabs.org,
mel@csn.ul.ie, linux-sh@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-mm <linux-mm@kvack.org>,
linux-mips@linux-mips.org, nacc@us.ibm.com,
sparclinux@vger.kernel.org, Eric B Munson <ebmunson@us.ibm.com>
Subject: Re: [RFC PATCH 0/2] Merge HUGETLB_PAGE and HUGETLBFS Kconfig options
Date: Fri, 13 Jun 2008 14:46:29 +0100 [thread overview]
Message-ID: <20080613134629.GD16344@linux-mips.org> (raw)
In-Reply-To: <1213296540.17108.8.camel@localhost.localdomain>
On Thu, Jun 12, 2008 at 02:49:00PM -0400, Adam Litke wrote:
> There are currently two global Kconfig options that enable/disable the
> hugetlb code: CONFIG_HUGETLB_PAGE and CONFIG_HUGETLBFS. This may have
> made sense before hugetlbfs became ubiquitous but now the pair of
> options are redundant. Merging these two options into one will simplify
> the code slightly and will, more importantly, avoid confusion and
> questions like: Which hugetlbfs CONFIG option should my code depend on?
>
> CONFIG_HUGETLB_PAGE is aliased to the value of CONFIG_HUGETLBFS, so one
> option can be removed without any effect. The first patch merges the
> two options into one option: CONFIG_HUGETLB. The second patch updates
> the defconfigs to set the one new option appropriately.
>
> I have cross-compiled this on i386, x86_64, ia64, powerpc, sparc64 and
> sh with the option enabled and disabled. This is completely mechanical
> but, due to the large number of files affected (especially defconfigs),
> could do well with a review from several sets of eyeballs. Thanks.
MIPS doesn't do HUGETLB (at least not in-tree atm) so I'm not sure why
linux-mips@linux-mips.org was cc'ed at all. So feel free to add my
Couldnt-care-less: ack line ;-)
Ralf
WARNING: multiple messages have this Message-ID (diff)
From: Ralf Baechle <ralf@linux-mips.org>
To: Adam Litke <agl@us.ibm.com>
Cc: linux-mm <linux-mm@kvack.org>,
npiggin@suse.de, nacc@us.ibm.com, mel@csn.ul.ie,
Eric B Munson <ebmunson@us.ibm.com>,
linux-kernel@vger.kernel.org, linux-ia64@vger.kernel.org,
linuxppc-dev@ozlabs.org, sparclinux@vger.kernel.org,
linux-sh@vger.kernel.org, linux-s390@vger.kernel.org,
linux-mips@linux-mips.org
Subject: Re: [RFC PATCH 0/2] Merge HUGETLB_PAGE and HUGETLBFS Kconfig options
Date: Fri, 13 Jun 2008 14:46:29 +0100 [thread overview]
Message-ID: <20080613134629.GD16344@linux-mips.org> (raw)
In-Reply-To: <1213296540.17108.8.camel@localhost.localdomain>
On Thu, Jun 12, 2008 at 02:49:00PM -0400, Adam Litke wrote:
> There are currently two global Kconfig options that enable/disable the
> hugetlb code: CONFIG_HUGETLB_PAGE and CONFIG_HUGETLBFS. This may have
> made sense before hugetlbfs became ubiquitous but now the pair of
> options are redundant. Merging these two options into one will simplify
> the code slightly and will, more importantly, avoid confusion and
> questions like: Which hugetlbfs CONFIG option should my code depend on?
>
> CONFIG_HUGETLB_PAGE is aliased to the value of CONFIG_HUGETLBFS, so one
> option can be removed without any effect. The first patch merges the
> two options into one option: CONFIG_HUGETLB. The second patch updates
> the defconfigs to set the one new option appropriately.
>
> I have cross-compiled this on i386, x86_64, ia64, powerpc, sparc64 and
> sh with the option enabled and disabled. This is completely mechanical
> but, due to the large number of files affected (especially defconfigs),
> could do well with a review from several sets of eyeballs. Thanks.
MIPS doesn't do HUGETLB (at least not in-tree atm) so I'm not sure why
linux-mips@linux-mips.org was cc'ed at all. So feel free to add my
Couldnt-care-less: ack line ;-)
Ralf
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2008-06-13 13:46 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-12 18:49 [RFC PATCH 0/2] Merge HUGETLB_PAGE and HUGETLBFS Kconfig options Adam Litke
2008-06-12 18:49 ` Adam Litke
2008-06-12 18:49 ` Adam Litke
2008-06-12 18:49 ` Adam Litke
2008-06-12 18:53 ` [RFC PATCH 1/2] Merge options into CONFIG_HUGETLB Adam Litke
2008-06-12 18:53 ` Adam Litke
2008-06-12 18:53 ` Adam Litke
2008-06-12 18:53 ` Adam Litke
2008-06-12 18:55 ` [RFC PATCH 2/2] Update defconfigs for CONFIG_HUGETLB Adam Litke
2008-06-12 18:55 ` Adam Litke
2008-06-12 18:55 ` Adam Litke
2008-06-12 18:55 ` Adam Litke
2008-06-12 19:36 ` Adrian Bunk
2008-06-12 19:36 ` Adrian Bunk
2008-06-12 19:36 ` Adrian Bunk
2008-06-12 19:36 ` Adrian Bunk
2008-06-13 18:12 ` Adam Litke
2008-06-13 18:12 ` Adam Litke
2008-06-13 18:12 ` Adam Litke
2008-06-13 18:12 ` Adam Litke
2008-06-13 13:46 ` Ralf Baechle [this message]
2008-06-13 13:46 ` [RFC PATCH 0/2] Merge HUGETLB_PAGE and HUGETLBFS Kconfig options Ralf Baechle
2008-06-13 13:46 ` Ralf Baechle
2008-06-13 13:46 ` Ralf Baechle
2008-06-13 14:03 ` [RFC PATCH 0/2] Merge HUGETLB_PAGE and HUGETLBFS Kconfig Adam Litke
2008-06-13 14:03 ` [RFC PATCH 0/2] Merge HUGETLB_PAGE and HUGETLBFS Kconfig options Adam Litke
2008-06-13 14:03 ` Adam Litke
2008-06-13 14:03 ` Adam Litke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080613134629.GD16344@linux-mips.org \
--to=ralf@linux-mips.org \
--cc=agl@us.ibm.com \
--cc=ebmunson@us.ibm.com \
--cc=linux-ia64@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=linux-mm@kvack.org \
--cc=linux-s390@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=mel@csn.ul.ie \
--cc=nacc@us.ibm.com \
--cc=npiggin@suse.de \
--cc=sparclinux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.