From: Lee Schermerhorn <Lee.Schermerhorn@hp.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>,
KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>,
linux-mm <linux-mm@kvack.org>,
LKML <linux-kernel@vger.kernel.org>,
Rik van Riel <riel@redhat.com>
Subject: [PATCH] fix to putback_lru_page()/unevictable page handling rework v3
Date: Tue, 24 Jun 2008 13:19:47 -0400 [thread overview]
Message-ID: <1214327987.6563.22.camel@lts-notebook> (raw)
In-Reply-To: <20080624184122.D838.KOSAKI.MOTOHIRO@jp.fujitsu.com>
PATCH fix to rework of putback_lru_page locking.
Against: 26-rc5-mm3 atop Kosaki Motohiro's v3 rework of Kamezawa
Hiroyuki's putback_lru_page rework patch.
'lru' was not being set to 'UNEVICTABLE when page was, in fact,
unevictable [really "nonreclaimable" :-)], so retry would never
happen, and culled pages never counted.
Also, redundant mem_cgroup_move_lists()--one with incorrect 'lru',
in the case of unevictable pages--messes up memcontroller tracking [I think].
Signed-off-by: Lee Schermerhorn <lee.schermerhorn@hp.com>
mm/vmscan.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Index: linux-2.6.26-rc5-mm3/mm/vmscan.c
===================================================================
--- linux-2.6.26-rc5-mm3.orig/mm/vmscan.c 2008-06-23 11:45:26.000000000 -0400
+++ linux-2.6.26-rc5-mm3/mm/vmscan.c 2008-06-24 12:45:15.000000000 -0400
@@ -514,8 +514,8 @@ redo:
* Put unevictable pages directly on zone's unevictable
* list.
*/
+ lru = LRU_UNEVICTABLE;
add_page_to_unevictable_list(page);
- mem_cgroup_move_lists(page, LRU_UNEVICTABLE);
}
mem_cgroup_move_lists(page, lru);
WARNING: multiple messages have this Message-ID (diff)
From: Lee Schermerhorn <Lee.Schermerhorn@hp.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>,
KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>,
linux-mm <linux-mm@kvack.org>,
LKML <linux-kernel@vger.kernel.org>,
Rik van Riel <riel@redhat.com>
Subject: [PATCH] fix to putback_lru_page()/unevictable page handling rework v3
Date: Tue, 24 Jun 2008 13:19:47 -0400 [thread overview]
Message-ID: <1214327987.6563.22.camel@lts-notebook> (raw)
In-Reply-To: <20080624184122.D838.KOSAKI.MOTOHIRO@jp.fujitsu.com>
PATCH fix to rework of putback_lru_page locking.
Against: 26-rc5-mm3 atop Kosaki Motohiro's v3 rework of Kamezawa
Hiroyuki's putback_lru_page rework patch.
'lru' was not being set to 'UNEVICTABLE when page was, in fact,
unevictable [really "nonreclaimable" :-)], so retry would never
happen, and culled pages never counted.
Also, redundant mem_cgroup_move_lists()--one with incorrect 'lru',
in the case of unevictable pages--messes up memcontroller tracking [I think].
Signed-off-by: Lee Schermerhorn <lee.schermerhorn@hp.com>
mm/vmscan.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Index: linux-2.6.26-rc5-mm3/mm/vmscan.c
===================================================================
--- linux-2.6.26-rc5-mm3.orig/mm/vmscan.c 2008-06-23 11:45:26.000000000 -0400
+++ linux-2.6.26-rc5-mm3/mm/vmscan.c 2008-06-24 12:45:15.000000000 -0400
@@ -514,8 +514,8 @@ redo:
* Put unevictable pages directly on zone's unevictable
* list.
*/
+ lru = LRU_UNEVICTABLE;
add_page_to_unevictable_list(page);
- mem_cgroup_move_lists(page, LRU_UNEVICTABLE);
}
mem_cgroup_move_lists(page, lru);
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2008-06-24 17:20 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-21 10:00 [RFC][PATCH] putback_lru_page()/unevictable page handling rework v3 KOSAKI Motohiro
2008-06-21 10:00 ` KOSAKI Motohiro
2008-06-24 2:43 ` KOSAKI Motohiro
2008-06-24 2:43 ` KOSAKI Motohiro
2008-06-24 17:10 ` Lee Schermerhorn
2008-06-24 17:10 ` Lee Schermerhorn
2008-06-24 17:55 ` Andrew Morton
2008-06-24 17:55 ` Andrew Morton
2008-06-24 19:11 ` Lee Schermerhorn
2008-06-24 19:11 ` Lee Schermerhorn
2008-06-24 19:19 ` Andrew Morton
2008-06-24 19:19 ` Andrew Morton
2008-06-24 17:29 ` [PATCH] fix2 to " Lee Schermerhorn
2008-06-24 17:29 ` Lee Schermerhorn
2008-06-24 17:38 ` KOSAKI Motohiro
2008-06-24 17:38 ` KOSAKI Motohiro
2008-06-24 9:49 ` [RFC][PATCH] " KOSAKI Motohiro
2008-06-24 9:49 ` KOSAKI Motohiro
2008-06-24 9:59 ` KAMEZAWA Hiroyuki
2008-06-24 9:59 ` KAMEZAWA Hiroyuki
2008-06-24 17:15 ` Lee Schermerhorn
2008-06-24 17:15 ` Lee Schermerhorn
2008-06-24 17:19 ` Lee Schermerhorn [this message]
2008-06-24 17:19 ` [PATCH] fix to " Lee Schermerhorn
2008-06-24 17:35 ` KOSAKI Motohiro
2008-06-24 17:35 ` KOSAKI Motohiro
2008-06-24 17:48 ` Lee Schermerhorn
2008-06-24 17:48 ` Lee Schermerhorn
2008-06-24 18:19 ` KOSAKI Motohiro
2008-06-24 18:19 ` KOSAKI Motohiro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1214327987.6563.22.camel@lts-notebook \
--to=lee.schermerhorn@hp.com \
--cc=akpm@linux-foundation.org \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=kosaki.motohiro@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=riel@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.