From: "Javier Martín" <lordhabbit@gmail.com>
To: The development of GRUB 2 <grub-devel@gnu.org>
Subject: Re: Failure to embed core.img is fatal now
Date: Thu, 26 Jun 2008 03:02:38 +0200 [thread overview]
Message-ID: <1214442159.24653.5.camel@localhost> (raw)
In-Reply-To: <1214430514.11716.19.camel@dv>
[-- Attachment #1: Type: text/plain, Size: 762 bytes --]
El mié, 25-06-2008 a las 17:48 -0400, Pavel Roskin escribió:
> I'm also surprised that the code alternately uses dir and
> DEFAULT_DIRECTORY to calculate core_path. core_path is calculated 3
> times in one function! If dir and DEFAULT_DIRECTORY are used correctly,
> I suggest that two different variables are used for what is now called
> core_path.
The core_path variable is indeed reused throughout the code: sometimes
it refers to the path as the OS and grub-setup see it, and then it's
used to search for core.img as GRUB would. This can be a bit confusing
(I've recently fixed a bug in that very function related to core_path
construction), so I agree that two different variables ought to be used.
Why not create a patch for the occasion?
[-- Attachment #2: Esta parte del mensaje está firmada digitalmente --]
[-- Type: application/pgp-signature, Size: 827 bytes --]
next prev parent reply other threads:[~2008-06-26 1:02 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-25 21:48 Failure to embed core.img is fatal now Pavel Roskin
2008-06-26 1:02 ` Javier Martín [this message]
2008-06-26 1:32 ` Pavel Roskin
2008-06-26 1:44 ` Pavel Roskin
2008-06-26 14:20 ` Robert Millan
2008-06-26 14:48 ` Pavel Roskin
2008-06-26 16:54 ` Pavel Roskin
2008-06-29 11:27 ` Robert Millan
2008-06-29 16:20 ` Pavel Roskin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1214442159.24653.5.camel@localhost \
--to=lordhabbit@gmail.com \
--cc=grub-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.