From: Robert Millan <rmh@aybabtu.com>
To: The development of GRUB 2 <grub-devel@gnu.org>
Subject: Re: Failure to embed core.img is fatal now
Date: Sun, 29 Jun 2008 13:27:04 +0200 [thread overview]
Message-ID: <20080629112704.GC2347@thorin> (raw)
In-Reply-To: <1214499294.17243.2.camel@dv>
On Thu, Jun 26, 2008 at 12:54:54PM -0400, Pavel Roskin wrote:
> + dos_part = grub_cpu_to_le32 (root_dev->disk->partition->index);
> + bsd_part = grub_cpu_to_le32 (-1);
> [...]
> grub_util_info ("dos partition is %d, bsd partition is %d",
> - grub_le_to_cpu32 (*install_dos_part),
> - grub_le_to_cpu32 (*install_bsd_part));
> + grub_le_to_cpu32 (dos_part), grub_le_to_cpu32 (bsd_part));
You're doing endian conversion twice.
--
Robert Millan
<GPLv2> I know my rights; I want my phone call!
<DRM> What good is a phone call… if you are unable to speak?
(as seen on /.)
next prev parent reply other threads:[~2008-06-29 11:27 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-25 21:48 Failure to embed core.img is fatal now Pavel Roskin
2008-06-26 1:02 ` Javier Martín
2008-06-26 1:32 ` Pavel Roskin
2008-06-26 1:44 ` Pavel Roskin
2008-06-26 14:20 ` Robert Millan
2008-06-26 14:48 ` Pavel Roskin
2008-06-26 16:54 ` Pavel Roskin
2008-06-29 11:27 ` Robert Millan [this message]
2008-06-29 16:20 ` Pavel Roskin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080629112704.GC2347@thorin \
--to=rmh@aybabtu.com \
--cc=grub-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.