Re: [PATCH] Make CONFIG_MIGRATION available for s390

All of lore.kernel.org
 help / color / mirror / Atom feed

From: Gerald Schaefer <gerald.schaefer@de.ibm.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org,
	schwidefsky@de.ibm.com, heiko.carstens@de.ibm.com,
	Dave Hansen <haveblue@us.ibm.com>,
	Andy Whitcroft <apw@shadowen.org>,
	KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>,
	Yasunori Goto <y-goto@jp.fujitsu.com>
Subject: Re: [PATCH] Make CONFIG_MIGRATION available for s390
Date: Sun, 06 Jul 2008 16:30:25 +0200	[thread overview]
Message-ID: <1215354625.9842.13.camel@localhost.localdomain> (raw)
In-Reply-To: <20080705150659.024F.E1E9C6FF@jp.fujitsu.com>

On Sat, 2008-07-05 at 15:14 +0900, Yasunori Goto wrote:
> > >  config MIGRATION
> > >  	bool "Page migration"
> > >  	def_bool y
> > > -	depends on NUMA
> > > +	depends on NUMA || S390
> 
> Hmm. I think ARCH_ENABLE_MEMORY_HOTREMOVE is better than S390.

Right, that makes more sense. I also noticed that my patch will produce
a compile error when CONFIG_NUMA is set but CONFIG_MIGRATION is not,
because policy_zone is missing in that case. Since policy_zone is only
used for NUMA, a better solution would be to use an "#ifdef CONFIG_NUMA"
within vma_migratable(). I will send a new version of the patch.

Thanks,
Gerald

WARNING: multiple messages have this Message-ID (diff)

From: Gerald Schaefer <gerald.schaefer@de.ibm.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org,
	schwidefsky@de.ibm.com, heiko.carstens@de.ibm.com,
	Dave Hansen <haveblue@us.ibm.com>,
	Andy Whitcroft <apw@shadowen.org>,
	KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>,
	Yasunori Goto <y-goto@jp.fujitsu.com>
Subject: Re: [PATCH] Make CONFIG_MIGRATION available for s390
Date: Sun, 06 Jul 2008 16:30:25 +0200	[thread overview]
Message-ID: <1215354625.9842.13.camel@localhost.localdomain> (raw)
In-Reply-To: <20080705150659.024F.E1E9C6FF@jp.fujitsu.com>

On Sat, 2008-07-05 at 15:14 +0900, Yasunori Goto wrote:
> > >  config MIGRATION
> > >  	bool "Page migration"
> > >  	def_bool y
> > > -	depends on NUMA
> > > +	depends on NUMA || S390
> 
> Hmm. I think ARCH_ENABLE_MEMORY_HOTREMOVE is better than S390.

Right, that makes more sense. I also noticed that my patch will produce
a compile error when CONFIG_NUMA is set but CONFIG_MIGRATION is not,
because policy_zone is missing in that case. Since policy_zone is only
used for NUMA, a better solution would be to use an "#ifdef CONFIG_NUMA"
within vma_migratable(). I will send a new version of the patch.

Thanks,
Gerald


--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

next prev parent reply	other threads:[~2008-07-06 14:31 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-07-04 14:58 [PATCH] Make CONFIG_MIGRATION available for s390 Gerald Schaefer
2008-07-04 14:58 ` [PATCH] Make CONFIG_MIGRATION available for s390, " Gerald Schaefer
2008-07-05  4:02 ` KAMEZAWA Hiroyuki
2008-07-05  4:02   ` KAMEZAWA Hiroyuki
2008-07-05  6:14   ` Yasunori Goto
2008-07-05  6:14     ` Yasunori Goto
2008-07-06 14:30     ` Gerald Schaefer [this message]
2008-07-06 14:30       ` Gerald Schaefer
  -- strict thread matches above, loose matches on Subject: below --
2008-07-06 14:35 Gerald Schaefer
2008-07-07  6:22 ` Yasunori Goto
2008-07-07  6:22   ` Yasunori Goto
2008-07-07  9:16 ` Andy Whitcroft
2008-07-07  9:16   ` Andy Whitcroft
2008-07-07 10:24   ` Yasunori Goto
2008-07-07 10:24     ` Yasunori Goto
2008-07-07 16:41     ` Gerald Schaefer
2008-07-07 16:41       ` Gerald Schaefer
2008-07-07 16:53       ` Christoph Lameter
2008-07-07 16:53         ` Christoph Lameter
2008-07-07 15:09 ` Christoph Lameter
2008-07-07 15:09   ` Christoph Lameter
2008-07-07 17:28   ` Gerald Schaefer
2008-07-07 17:28     ` Gerald Schaefer
2008-07-07 17:38     ` Christoph Lameter
2008-07-07 17:38       ` Christoph Lameter
2008-07-07 18:25       ` Gerald Schaefer
2008-07-07 18:25         ` Gerald Schaefer
2008-07-07 18:32         ` Christoph Lameter
2008-07-07 18:32           ` Christoph Lameter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1215354625.9842.13.camel@localhost.localdomain \
    --to=gerald.schaefer@de.ibm.com \
    --cc=akpm@linux-foundation.org \
    --cc=apw@shadowen.org \
    --cc=haveblue@us.ibm.com \
    --cc=heiko.carstens@de.ibm.com \
    --cc=kamezawa.hiroyu@jp.fujitsu.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=schwidefsky@de.ibm.com \
    --cc=y-goto@jp.fujitsu.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Be sure your reply has a Subject: header at the top and a blank line before the message body.

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.