Re: [PATCH] File readahead buffering

[Pavel Roskin <proski@gnu.org>]

On Tue, 2008-07-22 at 12:06 -0700, Colin D Bennett wrote:

> I agree that TGA is not, in general, a great choice for an image format
> (unless it is faster to load a large background image -- a 1024x768 RGB
> PNG file may take more time to decompress than a TGA image would take
> to load -- although perhaps an uncompressed PNG file would be
> comparable in speed to load).  However, I have not been able to load any
> PNG images that I have tried to use. Something about the chunk type not
> being supported.

Strange.  It's working for me.  You may want to post that file to the
list.

> If the buffering is not done in the file I/O layer, then the font
> loading, theme file loading, image file loading, etc. will all need to
> do their own buffering, which IMHO is more error prone and makes those
> modules use more code to handle low level I/O stuff, which detracts
> from their specific purpose.
> 
> Also, this is no small increase in speed, but from 10x to 100x increase
> in performance for some cases where small sequential reads are
> performed.

OK, then you may have a case.

-- 
Regards,
Pavel Roskin