Re: [PATCH] File readahead buffering

[Colin D Bennett <colin@gibibit.com>]

[-- Attachment #1: Type: text/plain, Size: 1486 bytes --]

On Thu, 24 Jul 2008 17:51:23 +0800
Bean <bean123ch@gmail.com> wrote:

> On Wed, Jul 23, 2008 at 10:56 PM, Colin D Bennett <colin@gibibit.com>
> wrote:
> > On Wed, 23 Jul 2008 07:33:32 -0700
> > Colin D Bennett <colin@gibibit.com> wrote:
> >
> >> Ok, after some more testing, I have found that if I create PNG
> >> images with ImageMagick or The GIMP, they work.  However, I have
> >> an image that I was trying to use as a GRUB background which is
> >> from a MythTV theme called Titivillus.  The PNG file from the
> >> MythTV theme doesn't load in GRUB.  I get the message "error: png:
> >> block type fixed not supported".
> >
> > Oops!  After more testing, I have found PNG images that I saved in
> > The GIMP which also refuse to load due to the "block type fixed not
> > supported" error.  One ZIP file [1] contains images that all fail to
> > load in GRUB with that error, and the other [2] contains similar
> > images that load just fine.
> >
> > [1] gibibit.com/upload/grub-png-bad.zip
> > [2] gibibit.com/upload/grub-png-good.zip
> 
> Hi,
> 
> This patch should fix the problem.

Hi Bean,

Thanks for the PNG fix!  I tested it and it fixes the problem.  8-)
I am now using PNG files in my testing and they are working great.

I'm also using my file I/O buffering patch and it helps performance
massively when loading images.  I hope that in using the file
buffering patch myself I can find any potential problems with it.

Regards,
Colin

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 197 bytes --]