All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Javier Martín" <lordhabbit@gmail.com>
To: The development of GRUB 2 <grub-devel@gnu.org>
Subject: Re: [PATCH] File readahead buffering
Date: Wed, 23 Jul 2008 04:43:13 +0200	[thread overview]
Message-ID: <1216780993.3033.20.camel@localhost> (raw)
In-Reply-To: <ca0f59980807221905j5b7d9e2blec3b0bc473420667@mail.gmail.com>

[-- Attachment #1: Type: text/plain, Size: 1065 bytes --]

El mié, 23-07-2008 a las 10:05 +0800, Bean escribió:
> On Wed, Jul 23, 2008 at 3:06 AM, Colin D Bennett <colin@gibibit.com> wrote:
> > On Tue, 22 Jul 2008 14:48:31 -0400
> > Pavel Roskin <proski@gnu.org> wrote:
> > However, I have not been able to load any
> > PNG images that I have tried to use. Something about the chunk type not
> > being supported.
> >
> 
> Hi,
> 
> Please upload the png file that cause problem.
> 
> Also note that png use DEFLATE compression. I write a decoder in png,
> which may be a little slow. Perhaps I can import the decoder from
> zlib, if copyright allows.
Does the GRUB decoder distinguish between critical and ancillary chunks?
A decoder finding a critical chunk that it does not understand should
abort, but finding an unknown ancillary chunk is not an error - maybe
his file has an ancillary chunk like zTXt and the GRUB png reader is
rejecting it as having unknown chunks. I didn't even take a look at the
decoder code so I could be dead wrong, but I think it's a possibility
worth investigating...


[-- Attachment #2: Esta parte del mensaje está firmada digitalmente --]
[-- Type: application/pgp-signature, Size: 827 bytes --]

  reply	other threads:[~2008-07-23  2:42 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-07-22 15:43 [PATCH] File readahead buffering Colin D Bennett
2008-07-22 18:48 ` Pavel Roskin
2008-07-22 19:06   ` Colin D Bennett
2008-07-22 21:44     ` Pavel Roskin
2008-07-23  4:14       ` Colin D Bennett
2008-07-23  2:05     ` Bean
2008-07-23  2:43       ` Javier Martín [this message]
2008-07-23 14:33       ` Colin D Bennett
2008-07-23 14:56         ` Colin D Bennett
2008-07-24  9:51           ` Bean
2008-07-26 17:32             ` Colin D Bennett
2008-07-26 18:14               ` Bean

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1216780993.3033.20.camel@localhost \
    --to=lordhabbit@gmail.com \
    --cc=grub-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.