All of lore.kernel.org
 help / color / mirror / Atom feed
From: Pavel Roskin <proski@gnu.org>
To: The development of GRUB 2 <grub-devel@gnu.org>
Subject: Re: [PATCH] hold shift or control to disable timeout even timeout=0
Date: Wed, 23 Jul 2008 21:13:58 -0400	[thread overview]
Message-ID: <1216862038.30436.8.camel@dv> (raw)
In-Reply-To: <20080724005259.GA16237@spacedout.fries.net>

On Wed, 2008-07-23 at 19:52 -0500, David Fries wrote:

> This calls the getshiftflags BIOS int 16h function 2 in startup.S, to
> find out the status of the shift and control keys (among others).  The
> required header and source files were modified to expose
> grub_getshiftflags.  menu.c checks grub_getshiftflags and will disable
> the timeout.

Cannot we avoid adding code to core.img that it not called from
core.img?  Just because it's written in assembly it doesn't mean it
should be in the in the core.

Sure, we are better off now that we are using lzma, but it we start
adding stuff mindlessly, core.img can again grow too large for some
setups.

-- 
Regards,
Pavel Roskin



  reply	other threads:[~2008-07-24  1:14 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-07-24  0:52 [PATCH] hold shift or control to disable timeout even timeout=0 David Fries
2008-07-24  1:13 ` Pavel Roskin [this message]
2008-07-24  1:36   ` David Fries
2008-07-24  1:45     ` Pavel Roskin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1216862038.30436.8.camel@dv \
    --to=proski@gnu.org \
    --cc=grub-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.