From: Pavel Roskin <proski@gnu.org>
To: The development of GRUB 2 <grub-devel@gnu.org>
Subject: Re: [PATCH] hold shift or control to disable timeout even timeout=0
Date: Wed, 23 Jul 2008 21:45:22 -0400 [thread overview]
Message-ID: <1216863922.30436.16.camel@dv> (raw)
In-Reply-To: <20080724013607.GA5621@spacedout.fries.net>
On Wed, 2008-07-23 at 20:36 -0500, David Fries wrote:
> I could make the argument that it is ten assmebly instructions, but I
> think the stronger case is the other two keyboard reading routines are
> right there in the same file.
>
> I suppose the grub_checkkey and the new grub_getshiftflags could both
> be moved out of core.img, but where would they go and how would they
> get assigned to the grub_term structure?
I think they should be in normal.mod, and should be assigned in the
normal.mod initialization. Maybe it could be a new file with
architecture specific code needed for normal.mod support.
--
Regards,
Pavel Roskin
prev parent reply other threads:[~2008-07-24 1:45 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-24 0:52 [PATCH] hold shift or control to disable timeout even timeout=0 David Fries
2008-07-24 1:13 ` Pavel Roskin
2008-07-24 1:36 ` David Fries
2008-07-24 1:45 ` Pavel Roskin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1216863922.30436.16.camel@dv \
--to=proski@gnu.org \
--cc=grub-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.