From: Markus Pargmann <mpa@pengutronix.de>
To: linux-arm-kernel@lists.infradead.org
Cc: Boris Brezillon <boris.brezillon@free-electrons.com>,
Han Xu <han.xu@nxp.com>,
Fabio Estevam <fabio.estevam@freescale.com>,
Elie De Brauwer <eliedebrauwer@gmail.com>,
Artem Bityutskiy <dedekind1@gmail.com>,
Stefan Christ <s.christ@phytec.de>,
Huang Shijie <shijie.huang@intel.com>,
"linux-mtd@lists.infradead.org" <linux-mtd@lists.infradead.org>,
"kernel@pengutronix.de" <kernel@pengutronix.de>,
Richard Weinberger <richard@nod.at>,
Brian Norris <computersforpeace@gmail.com>,
David Woodhouse <dwmw2@infradead.org>
Subject: Re: [PATCH RESEND] gpmi-nand: Handle ECC Errors in erased pages
Date: Mon, 18 Apr 2016 12:07:27 +0200 [thread overview]
Message-ID: <12179071.kte6qB1Shv@adelgunde> (raw)
In-Reply-To: <20160415174031.3c088df5@bbrezillon>
[-- Attachment #1: Type: text/plain, Size: 1485 bytes --]
On Friday 15 April 2016 17:40:31 Boris Brezillon wrote:
> On Fri, 15 Apr 2016 15:33:07 +0000
> Han Xu <han.xu@nxp.com> wrote:
>
> > >
> > > I just did [1] (it applies on top of your patch), but maybe you
> > > can test it (I don't have any imx platforms right now) ;).
> >
> > Great, thank you :). I just tested the patch and it works for me. The
> > erased page bitflips are still detected and fixed. I will send a new
> > version then.
> >
> > Hi Markus,
> >
> > Could you please share how to verify the patch, in other words, how to reproduce the
> > UBIFS corruption issue consistently. Thanks.
I used a simple bashscript with 'nandwrite --noecc' that writes a number
of zeroes in every sub-page. For written pages the ECC will handle the
flips. For erased pages we can test the algorithm that handles the
erased page bitflips.
>
> I should really post a new version of the nandflipbits tool [1].
> That's clearly the easiest solution to verify that your bitflip
> correction is reliable.
Seems really useful.
Best Regards,
Markus
>
>
> [1]http://lists.infradead.org/pipermail/linux-mtd/2014-November/056634.html
>
>
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: mpa@pengutronix.de (Markus Pargmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH RESEND] gpmi-nand: Handle ECC Errors in erased pages
Date: Mon, 18 Apr 2016 12:07:27 +0200 [thread overview]
Message-ID: <12179071.kte6qB1Shv@adelgunde> (raw)
In-Reply-To: <20160415174031.3c088df5@bbrezillon>
On Friday 15 April 2016 17:40:31 Boris Brezillon wrote:
> On Fri, 15 Apr 2016 15:33:07 +0000
> Han Xu <han.xu@nxp.com> wrote:
>
> > >
> > > I just did [1] (it applies on top of your patch), but maybe you
> > > can test it (I don't have any imx platforms right now) ;).
> >
> > Great, thank you :). I just tested the patch and it works for me. The
> > erased page bitflips are still detected and fixed. I will send a new
> > version then.
> >
> > Hi Markus,
> >
> > Could you please share how to verify the patch, in other words, how to reproduce the
> > UBIFS corruption issue consistently. Thanks.
I used a simple bashscript with 'nandwrite --noecc' that writes a number
of zeroes in every sub-page. For written pages the ECC will handle the
flips. For erased pages we can test the algorithm that handles the
erased page bitflips.
>
> I should really post a new version of the nandflipbits tool [1].
> That's clearly the easiest solution to verify that your bitflip
> correction is reliable.
Seems really useful.
Best Regards,
Markus
>
>
> [1]http://lists.infradead.org/pipermail/linux-mtd/2014-November/056634.html
>
>
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20160418/b0f1222c/attachment-0001.sig>
next prev parent reply other threads:[~2016-04-18 10:07 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-21 12:52 [PATCH RESEND] gpmi-nand: Handle ECC Errors in erased pages Markus Pargmann
2016-02-21 12:52 ` Markus Pargmann
2016-02-24 13:57 ` Boris Brezillon
2016-02-24 13:57 ` Boris Brezillon
2016-04-11 6:34 ` Markus Pargmann
2016-04-11 6:34 ` Markus Pargmann
2016-04-11 7:29 ` Boris Brezillon
2016-04-11 7:29 ` Boris Brezillon
2016-04-12 22:39 ` Han Xu
2016-04-12 22:39 ` Han Xu
2016-04-12 22:51 ` Boris Brezillon
2016-04-12 22:51 ` Boris Brezillon
2016-04-15 7:55 ` Markus Pargmann
2016-04-15 7:55 ` Markus Pargmann
2016-04-15 8:35 ` Boris Brezillon
2016-04-15 8:35 ` Boris Brezillon
2016-04-15 9:35 ` Markus Pargmann
2016-04-15 9:35 ` Markus Pargmann
2016-04-15 9:39 ` Boris Brezillon
2016-04-15 9:39 ` Boris Brezillon
2016-04-15 12:03 ` Markus Pargmann
2016-04-15 12:03 ` Markus Pargmann
2016-04-15 15:33 ` Han Xu
2016-04-15 15:33 ` Han Xu
2016-04-15 15:40 ` Boris Brezillon
2016-04-15 15:40 ` Boris Brezillon
2016-04-18 10:07 ` Markus Pargmann [this message]
2016-04-18 10:07 ` Markus Pargmann
2016-04-18 14:47 ` Stefan Christ
2016-04-18 14:47 ` Stefan Christ
2016-04-18 15:10 ` Boris Brezillon
2016-04-18 15:10 ` Boris Brezillon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=12179071.kte6qB1Shv@adelgunde \
--to=mpa@pengutronix.de \
--cc=boris.brezillon@free-electrons.com \
--cc=computersforpeace@gmail.com \
--cc=dedekind1@gmail.com \
--cc=dwmw2@infradead.org \
--cc=eliedebrauwer@gmail.com \
--cc=fabio.estevam@freescale.com \
--cc=han.xu@nxp.com \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-mtd@lists.infradead.org \
--cc=richard@nod.at \
--cc=s.christ@phytec.de \
--cc=shijie.huang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.