All of lore.kernel.org
 help / color / mirror / Atom feed
From: Boris Brezillon <boris.brezillon@free-electrons.com>
To: Han Xu <han.xu@nxp.com>
Cc: Markus Pargmann <mpa@pengutronix.de>,
	David Woodhouse <dwmw2@infradead.org>,
	Fabio Estevam <fabio.estevam@freescale.com>,
	"linux-mtd@lists.infradead.org" <linux-mtd@lists.infradead.org>,
	"kernel@pengutronix.de" <kernel@pengutronix.de>,
	Huang Shijie <shijie.huang@intel.com>,
	Brian Norris <computersforpeace@gmail.com>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>,
	Stefan Christ <s.christ@phytec.de>,
	Elie De Brauwer <eliedebrauwer@gmail.com>,
	Richard Weinberger <richard@nod.at>,
	Artem Bityutskiy <dedekind1@gmail.com>
Subject: Re: [PATCH RESEND] gpmi-nand: Handle ECC Errors in erased pages
Date: Fri, 15 Apr 2016 17:40:31 +0200	[thread overview]
Message-ID: <20160415174031.3c088df5@bbrezillon> (raw)
In-Reply-To: <AM4PR0401MB1841C82A9BCBFF2C55AA4DC397680@AM4PR0401MB1841.eurprd04.prod.outlook.com>

On Fri, 15 Apr 2016 15:33:07 +0000
Han Xu <han.xu@nxp.com> wrote:

> >
> > I just did [1] (it applies on top of your patch), but maybe you
> > can test it (I don't have any imx platforms right now) ;).
> 
> Great, thank you :). I just tested the patch and it works for me. The
> erased page bitflips are still detected and fixed. I will send a new
> version then.
> 
> Hi Markus,
> 
> Could you please share how to verify the patch, in other words, how to reproduce the
> UBIFS corruption issue consistently. Thanks.

I should really post a new version of the nandflipbits tool [1].
That's clearly the easiest solution to verify that your bitflip
correction is reliable.


[1]http://lists.infradead.org/pipermail/linux-mtd/2014-November/056634.html

-- 
Boris Brezillon, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

WARNING: multiple messages have this Message-ID (diff)
From: boris.brezillon@free-electrons.com (Boris Brezillon)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH RESEND] gpmi-nand: Handle ECC Errors in erased pages
Date: Fri, 15 Apr 2016 17:40:31 +0200	[thread overview]
Message-ID: <20160415174031.3c088df5@bbrezillon> (raw)
In-Reply-To: <AM4PR0401MB1841C82A9BCBFF2C55AA4DC397680@AM4PR0401MB1841.eurprd04.prod.outlook.com>

On Fri, 15 Apr 2016 15:33:07 +0000
Han Xu <han.xu@nxp.com> wrote:

> >
> > I just did [1] (it applies on top of your patch), but maybe you
> > can test it (I don't have any imx platforms right now) ;).
> 
> Great, thank you :). I just tested the patch and it works for me. The
> erased page bitflips are still detected and fixed. I will send a new
> version then.
> 
> Hi Markus,
> 
> Could you please share how to verify the patch, in other words, how to reproduce the
> UBIFS corruption issue consistently. Thanks.

I should really post a new version of the nandflipbits tool [1].
That's clearly the easiest solution to verify that your bitflip
correction is reliable.


[1]http://lists.infradead.org/pipermail/linux-mtd/2014-November/056634.html

-- 
Boris Brezillon, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

  reply	other threads:[~2016-04-15 15:40 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-21 12:52 [PATCH RESEND] gpmi-nand: Handle ECC Errors in erased pages Markus Pargmann
2016-02-21 12:52 ` Markus Pargmann
2016-02-24 13:57 ` Boris Brezillon
2016-02-24 13:57   ` Boris Brezillon
2016-04-11  6:34   ` Markus Pargmann
2016-04-11  6:34     ` Markus Pargmann
2016-04-11  7:29     ` Boris Brezillon
2016-04-11  7:29       ` Boris Brezillon
2016-04-12 22:39       ` Han Xu
2016-04-12 22:39         ` Han Xu
2016-04-12 22:51         ` Boris Brezillon
2016-04-12 22:51           ` Boris Brezillon
2016-04-15  7:55           ` Markus Pargmann
2016-04-15  7:55             ` Markus Pargmann
2016-04-15  8:35             ` Boris Brezillon
2016-04-15  8:35               ` Boris Brezillon
2016-04-15  9:35               ` Markus Pargmann
2016-04-15  9:35                 ` Markus Pargmann
2016-04-15  9:39                 ` Boris Brezillon
2016-04-15  9:39                   ` Boris Brezillon
2016-04-15 12:03                   ` Markus Pargmann
2016-04-15 12:03                     ` Markus Pargmann
2016-04-15 15:33                     ` Han Xu
2016-04-15 15:33                       ` Han Xu
2016-04-15 15:40                       ` Boris Brezillon [this message]
2016-04-15 15:40                         ` Boris Brezillon
2016-04-18 10:07                         ` Markus Pargmann
2016-04-18 10:07                           ` Markus Pargmann
2016-04-18 14:47                   ` Stefan Christ
2016-04-18 14:47                     ` Stefan Christ
2016-04-18 15:10                     ` Boris Brezillon
2016-04-18 15:10                       ` Boris Brezillon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160415174031.3c088df5@bbrezillon \
    --to=boris.brezillon@free-electrons.com \
    --cc=computersforpeace@gmail.com \
    --cc=dedekind1@gmail.com \
    --cc=dwmw2@infradead.org \
    --cc=eliedebrauwer@gmail.com \
    --cc=fabio.estevam@freescale.com \
    --cc=han.xu@nxp.com \
    --cc=kernel@pengutronix.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=mpa@pengutronix.de \
    --cc=richard@nod.at \
    --cc=s.christ@phytec.de \
    --cc=shijie.huang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.