All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH][LINUX] don't WARN_ON -ENOSYS from PHYSDEVOP_manage_pci_remove
@ 2008-08-07 21:17 Alex Williamson
  0 siblings, 0 replies; only message in thread
From: Alex Williamson @ 2008-08-07 21:17 UTC (permalink / raw)
  To: xen-devel; +Cc: Keir Fraser


We let -ENOSYS slip through on the add side to support old hypervisors,
let's do the same on the remove end so we don't get stack dumps during
bootup.

Signed-off-by: Alex Williamson <alex.williamson@hp.com>
--

diff -r 2866e6af503e drivers/xen/core/pci.c
--- a/drivers/xen/core/pci.c	Thu Jul 31 15:33:54 2008 +0100
+++ b/drivers/xen/core/pci.c	Thu Aug 07 15:14:07 2008 -0600
@@ -23,9 +23,13 @@ static int pci_bus_probe_wrapper(struct 
 		return r;
 
 	r = pci_bus_probe(dev);
-	if (r)
-		WARN_ON(HYPERVISOR_physdev_op(PHYSDEVOP_manage_pci_remove,
-					      &manage_pci));
+	if (r) {
+		int ret;
+
+		ret = HYPERVISOR_physdev_op(PHYSDEVOP_manage_pci_remove,
+					    &manage_pci);
+		WARN_ON(ret && ret != -ENOSYS);
+	}
 
 	return r;
 }

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2008-08-07 21:17 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-08-07 21:17 [PATCH][LINUX] don't WARN_ON -ENOSYS from PHYSDEVOP_manage_pci_remove Alex Williamson

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.