All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dave Hansen <dave@linux.vnet.ibm.com>
To: C Michael Sundius <Michael.sundius@sciatl.com>
Cc: Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
	linux-mm@kvack.org, linux-mips@linux-mips.org,
	jfraser@broadcom.com, Andy Whitcroft <apw@shadowen.org>
Subject: Re: sparsemem support for mips with highmem
Date: Fri, 15 Aug 2008 10:37:55 -0700	[thread overview]
Message-ID: <1218821875.23641.103.camel@nimitz> (raw)
In-Reply-To: <48A5B9F1.3080201@sciatl.com>

On Fri, 2008-08-15 at 10:16 -0700, C Michael Sundius wrote:
> Ah, your right. thanks.  "but it's not necessar*il*y a good idea".
> That 
> is to say, we don't put
> memory above 2 GiB. No need to make the mem_section[] array bigger
> than 
> need be.
> 
> This gives further credence for it to be a configurable in Kconfig as
> well.

I definitely don't want it to be something that users see.  It is never
enough overhead to really care.  On a 16TB system with 16MB sections,
the mem_section[] array is still only 16MB!!

So, I'd say to just make it as big as the arch needs in the worst case
(smallest SECTION_SIZE_BITS and largest MAX_PHYSMEM_BITS) and leave it.
We might even want to merge the 32 and 64-bit versions.

For your 32-bit version, we now use:
8 bytes (2 32-bit words) for each mem_section[]
2GB/128MB sections = 16
So, that's only 512 bytes.

For the 64-bit version, we now use:
16 bytes (2 64-bit words) for each mem_section[]
32GB/256MB sections = 128
So, that's only 2048 bytes.

If we were to merge the 32 and 64-bit versions to:
#define SECTION_SIZE_BITS       27
#define MAX_PHYSMEM_BITS        35

Your 32-bit version would go to 2048 bytes, and the 64-bit version would
go to 4096 bytes.  The 32-bit version would we able to address more
memory, and the 64-bit version would be able to handle smaller memory
holes more efficiently. 

-- Dave

WARNING: multiple messages have this Message-ID (diff)
From: Dave Hansen <dave@linux.vnet.ibm.com>
To: C Michael Sundius <Michael.sundius@sciatl.com>
Cc: Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
	linux-mm@kvack.org, linux-mips@linux-mips.org,
	jfraser@broadcom.com, Andy Whitcroft <apw@shadowen.org>
Subject: Re: sparsemem support for mips with highmem
Date: Fri, 15 Aug 2008 10:37:55 -0700	[thread overview]
Message-ID: <1218821875.23641.103.camel@nimitz> (raw)
In-Reply-To: <48A5B9F1.3080201@sciatl.com>

On Fri, 2008-08-15 at 10:16 -0700, C Michael Sundius wrote:
> Ah, your right. thanks.  "but it's not necessar*il*y a good idea".
> That 
> is to say, we don't put
> memory above 2 GiB. No need to make the mem_section[] array bigger
> than 
> need be.
> 
> This gives further credence for it to be a configurable in Kconfig as
> well.

I definitely don't want it to be something that users see.  It is never
enough overhead to really care.  On a 16TB system with 16MB sections,
the mem_section[] array is still only 16MB!!

So, I'd say to just make it as big as the arch needs in the worst case
(smallest SECTION_SIZE_BITS and largest MAX_PHYSMEM_BITS) and leave it.
We might even want to merge the 32 and 64-bit versions.

For your 32-bit version, we now use:
8 bytes (2 32-bit words) for each mem_section[]
2GB/128MB sections = 16
So, that's only 512 bytes.

i>>?For the 64-bit version, we now use:
16 bytes (2 64-bit words) for each mem_section[]
32GB/256MB sections = 128
So, that's only 2048 bytes.

If we were to merge the 32 and 64-bit versions to:
#define SECTION_SIZE_BITS       27
#define MAX_PHYSMEM_BITS        35

Your 32-bit version would go to 2048 bytes, and the 64-bit version would
go to 4096 bytes.  The 32-bit version would we able to address more
memory, and the 64-bit version would be able to handle smaller memory
holes more efficiently. 

-- Dave

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  reply	other threads:[~2008-08-15 17:38 UTC|newest]

Thread overview: 59+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-08-14 22:05 sparsemem support for mips with highmem C Michael Sundius
2008-08-14 22:35 ` Dave Hansen
2008-08-14 22:35   ` Dave Hansen
2008-08-14 23:16   ` C Michael Sundius
2008-08-14 23:16     ` C Michael Sundius
2008-08-14 23:52   ` C Michael Sundius
2008-08-15  0:02     ` Dave Hansen
2008-08-15  0:02       ` Dave Hansen
2008-08-15  8:03     ` Thomas Bogendoerfer
2008-08-15  8:03       ` Thomas Bogendoerfer
2008-08-15 15:48       ` Dave Hansen
2008-08-15 15:48         ` Dave Hansen
2008-08-15 16:12         ` C Michael Sundius
2008-08-15 16:12           ` C Michael Sundius
2008-08-15 16:20           ` Dave Hansen
2008-08-15 16:20             ` Dave Hansen
2008-08-15 16:33           ` Thomas Bogendoerfer
2008-08-15 16:33             ` Thomas Bogendoerfer
2008-08-15 17:16             ` C Michael Sundius
2008-08-15 17:16               ` C Michael Sundius
2008-08-15 17:37               ` Dave Hansen [this message]
2008-08-15 17:37                 ` Dave Hansen
2008-08-15 18:17                 ` C Michael Sundius
2008-08-15 18:17                   ` C Michael Sundius
2008-08-15 18:23                   ` Dave Hansen
2008-08-15 18:23                     ` Dave Hansen
2008-08-16 20:07                     ` Thomas Bogendoerfer
2008-08-16 20:07                       ` Thomas Bogendoerfer
2008-08-18 16:44                   ` Randy Dunlap
2008-08-18 16:44                     ` Randy Dunlap
2008-08-18 21:24                     ` Christoph Lameter
2008-08-18 21:24                       ` Christoph Lameter
2008-08-18 21:27                       ` Dave Hansen
2008-08-18 21:27                         ` Dave Hansen
2008-08-18 21:33                         ` Christoph Lameter
2008-08-18 21:33                           ` Christoph Lameter
2009-01-16 21:46                           ` Michael Sundius
2009-01-16 21:46                             ` Michael Sundius
2009-01-21 14:39                             ` Christoph Lameter
2009-01-21 14:39                               ` Christoph Lameter
2008-08-18 21:57                       ` David VomLehn
2008-08-18 21:57                         ` David VomLehn
2008-08-19 13:06                         ` Christoph Lameter
2008-08-19 13:06                           ` Christoph Lameter
2008-08-19 23:38                           ` David VomLehn
2008-08-19 23:38                             ` David VomLehn
2008-08-19 23:53                             ` Jon Fraser
2008-08-19 23:53                               ` Jon Fraser
2008-08-20 13:58                             ` Christoph Lameter
2008-08-20 13:58                               ` Christoph Lameter
2008-08-20 19:28                               ` David VomLehn
2008-08-20 19:28                                 ` David VomLehn
2008-08-20 20:51                                 ` Christoph Lameter
2008-08-20 20:51                                   ` Christoph Lameter
2008-08-15 16:30         ` Thomas Bogendoerfer
2008-08-15 16:30           ` Thomas Bogendoerfer
2008-08-26  9:09     ` Andy Whitcroft
2008-08-26  9:09       ` Andy Whitcroft
2008-10-06 20:15       ` Have ever checked in your mips sparsemem code into mips-linux tree? C Michael Sundius

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1218821875.23641.103.camel@nimitz \
    --to=dave@linux.vnet.ibm.com \
    --cc=Michael.sundius@sciatl.com \
    --cc=apw@shadowen.org \
    --cc=jfraser@broadcom.com \
    --cc=linux-mips@linux-mips.org \
    --cc=linux-mm@kvack.org \
    --cc=tsbogend@alpha.franken.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.