All of lore.kernel.org
 help / color / mirror / Atom feed
From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Sebastian Andrzej Siewior <sebastian@breakpoint.cc>
Cc: linuxppc-dev@ozlabs.org,
	Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
	kexec@lists.infradead.org
Subject: Re: [RFC] powerpc: add kexec support on Book-E
Date: Fri, 10 Oct 2008 14:53:46 +1100	[thread overview]
Message-ID: <1223610826.8157.142.camel@pasglop> (raw)
In-Reply-To: <1222896024-22172-2-git-send-email-sebastian@breakpoint.cc>

On Wed, 2008-10-01 at 23:20 +0200, Sebastian Andrzej Siewior wrote:

> +#define KEXEC_MODE_NOMMU 1
> +#define KEXEC_MODE_BOOKE 2

No need for runtime detection here, you cannot and likely never will be
able to build a kernel that does bot BookE and real mode...

> +
> +/* 1. Find the index of the entry we're executing in */
> +	bl	invstr			/* Find our address */
> +invstr:
> +	mflr	r6			/* Make it accessible */
> +	mfmsr	r7
> +	rlwinm	r4,r7,27,31,31		/* extract MSR[IS] */
> +	mfspr	r7, SPRN_PID0
> +	slwi	r7,r7,16
> +	or	r7,r7,r4
> +	mtspr	SPRN_MAS6,r7
> +	tlbsx	0,r6			/* search MSR[IS], SPID=PID0 */
> +	mfspr	r7,SPRN_MAS1
> +	andis.	r7,r7,MAS1_VALID@h
> +	bne	match_TLB

This isn't just BookE .. it's specifically FSL BookE (or "merged"
architecture). This isn't going to work on 44x for example. You need to
make it clearer.

Cheers,
Ben.



_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec

WARNING: multiple messages have this Message-ID (diff)
From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Sebastian Andrzej Siewior <sebastian@breakpoint.cc>
Cc: linuxppc-dev@ozlabs.org,
	Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
	kexec@lists.infradead.org
Subject: Re: [RFC] powerpc: add kexec support on Book-E
Date: Fri, 10 Oct 2008 14:53:46 +1100	[thread overview]
Message-ID: <1223610826.8157.142.camel@pasglop> (raw)
In-Reply-To: <1222896024-22172-2-git-send-email-sebastian@breakpoint.cc>

On Wed, 2008-10-01 at 23:20 +0200, Sebastian Andrzej Siewior wrote:

> +#define KEXEC_MODE_NOMMU 1
> +#define KEXEC_MODE_BOOKE 2

No need for runtime detection here, you cannot and likely never will be
able to build a kernel that does bot BookE and real mode...

> +
> +/* 1. Find the index of the entry we're executing in */
> +	bl	invstr			/* Find our address */
> +invstr:
> +	mflr	r6			/* Make it accessible */
> +	mfmsr	r7
> +	rlwinm	r4,r7,27,31,31		/* extract MSR[IS] */
> +	mfspr	r7, SPRN_PID0
> +	slwi	r7,r7,16
> +	or	r7,r7,r4
> +	mtspr	SPRN_MAS6,r7
> +	tlbsx	0,r6			/* search MSR[IS], SPID=PID0 */
> +	mfspr	r7,SPRN_MAS1
> +	andis.	r7,r7,MAS1_VALID@h
> +	bne	match_TLB

This isn't just BookE .. it's specifically FSL BookE (or "merged"
architecture). This isn't going to work on 44x for example. You need to
make it clearer.

Cheers,
Ben.

  reply	other threads:[~2008-10-10  3:54 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-10-01 21:20 [RFC] kexec support on Book-e, ppc32 Sebastian Andrzej Siewior
2008-10-01 21:20 ` Sebastian Andrzej Siewior
2008-10-01 21:20 ` [RFC] powerpc: add kexec support on Book-E Sebastian Andrzej Siewior
2008-10-01 21:20   ` Sebastian Andrzej Siewior
2008-10-10  3:53   ` Benjamin Herrenschmidt [this message]
2008-10-10  3:53     ` Benjamin Herrenschmidt
2008-10-12 13:55     ` Sebastian Andrzej Siewior
2008-10-12 13:55       ` Sebastian Andrzej Siewior
2008-10-01 21:20 ` [RFC] powerpc: enable kexec support on mpc8544ds Sebastian Andrzej Siewior
2008-10-01 21:20   ` Sebastian Andrzej Siewior
2008-10-01 21:20 ` [PATCH] powerpc: dtb and purgatory support for ppc32 Sebastian Andrzej Siewior
2008-10-01 21:20   ` Sebastian Andrzej Siewior
2008-10-02  3:54   ` Kumar Gala
2008-10-02  3:54     ` Kumar Gala
2008-10-02  7:50     ` Sebastian Siewior
2008-10-02  7:50       ` Sebastian Siewior
2008-10-02 10:05       ` Simon Horman
2008-10-02 10:05         ` Simon Horman
2008-10-03  5:44         ` Mohan Kumar M
2008-10-03  5:44           ` Mohan Kumar M
2008-10-02 12:52   ` Kumar Gala
2008-10-02 12:52     ` Kumar Gala
2008-10-02 13:03     ` Sebastian Andrzej Siewior
2008-10-02 13:03       ` Sebastian Andrzej Siewior
2008-10-08  3:03   ` Simon Horman
2008-10-08  3:03     ` Simon Horman
2008-10-12 13:39     ` Sebastian Andrzej Siewior
2008-10-12 13:39       ` Sebastian Andrzej Siewior
2008-10-15  3:37       ` Simon Horman
2008-10-15  3:37         ` Simon Horman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1223610826.8157.142.camel@pasglop \
    --to=benh@kernel.crashing.org \
    --cc=bigeasy@linutronix.de \
    --cc=kexec@lists.infradead.org \
    --cc=linuxppc-dev@ozlabs.org \
    --cc=sebastian@breakpoint.cc \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.