From: Dan Williams <dcbw-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
To: Alexey Fisher
<bug-track-M18mAb7Tlt0yCq4wW13eYl6hYfS7NtTn@public.gmane.org>
Cc: linux-wireless-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linville-2XuSBdqkA4R54TAoqtyWWQ@public.gmane.org,
rjw-KKrjLPT3xs0@public.gmane.org,
kernel-testers-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH] make assocaittion only if SSID is known.
Date: Tue, 04 Nov 2008 17:47:08 -0500 [thread overview]
Message-ID: <1225838828.22671.0.camel@localhost.localdomain> (raw)
In-Reply-To: <1225836101-5723-1-git-send-email-bug-track-M18mAb7Tlt0yCq4wW13eYl6hYfS7NtTn@public.gmane.org>
On Tue, 2008-11-04 at 23:01 +0100, Alexey Fisher wrote:
> 'iwconfig eth1 channel 6' would trigger association to _something_, which is wrong. Changing the channel should (and does) trigger reassociation, but only if there is an SSID to associate with!
Heh :) Need the Signed-off-by: here too though.
Dan
> drivers/net/wireless/ipw2200.c | 3 +--
> 1 files changed, 1 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/wireless/ipw2200.c b/drivers/net/wireless/ipw2200.c
> index dcce354..d26beed 100644
> --- a/drivers/net/wireless/ipw2200.c
> +++ b/drivers/net/wireless/ipw2200.c
> @@ -7581,8 +7581,7 @@ static int ipw_associate(void *data)
> }
>
> if (!(priv->config & CFG_ASSOCIATE) &&
> - !(priv->config & (CFG_STATIC_ESSID |
> - CFG_STATIC_CHANNEL | CFG_STATIC_BSSID))) {
> + !(priv->config & (CFG_STATIC_ESSID | CFG_STATIC_BSSID))) {
> IPW_DEBUG_ASSOC("Not attempting association (associate=0)\n");
> return 0;
> }
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: Dan Williams <dcbw@redhat.com>
To: Alexey Fisher <bug-track@fisher-privat.net>
Cc: linux-wireless@vger.kernel.org, linville@tuxdriver.com,
rjw@sisk.pl, kernel-testers@vger.kernel.org
Subject: Re: [PATCH] make assocaittion only if SSID is known.
Date: Tue, 04 Nov 2008 17:47:08 -0500 [thread overview]
Message-ID: <1225838828.22671.0.camel@localhost.localdomain> (raw)
In-Reply-To: <1225836101-5723-1-git-send-email-bug-track@fisher-privat.net>
On Tue, 2008-11-04 at 23:01 +0100, Alexey Fisher wrote:
> 'iwconfig eth1 channel 6' would trigger association to _something_, which is wrong. Changing the channel should (and does) trigger reassociation, but only if there is an SSID to associate with!
Heh :) Need the Signed-off-by: here too though.
Dan
> drivers/net/wireless/ipw2200.c | 3 +--
> 1 files changed, 1 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/wireless/ipw2200.c b/drivers/net/wireless/ipw2200.c
> index dcce354..d26beed 100644
> --- a/drivers/net/wireless/ipw2200.c
> +++ b/drivers/net/wireless/ipw2200.c
> @@ -7581,8 +7581,7 @@ static int ipw_associate(void *data)
> }
>
> if (!(priv->config & CFG_ASSOCIATE) &&
> - !(priv->config & (CFG_STATIC_ESSID |
> - CFG_STATIC_CHANNEL | CFG_STATIC_BSSID))) {
> + !(priv->config & (CFG_STATIC_ESSID | CFG_STATIC_BSSID))) {
> IPW_DEBUG_ASSOC("Not attempting association (associate=0)\n");
> return 0;
> }
next prev parent reply other threads:[~2008-11-04 22:47 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-04 22:01 [PATCH] make assocaittion only if SSID is known Alexey Fisher
2008-11-04 22:01 ` Alexey Fisher
[not found] ` <1225836101-5723-1-git-send-email-bug-track-M18mAb7Tlt0yCq4wW13eYl6hYfS7NtTn@public.gmane.org>
2008-11-04 22:47 ` Dan Williams [this message]
2008-11-04 22:47 ` Dan Williams
[not found] ` <1225838828.22671.0.camel-bi+AKbBUZKY6gyzm1THtWbp2dZbC/Bob@public.gmane.org>
2008-11-05 5:25 ` Kalle Valo
2008-11-05 5:25 ` Kalle Valo
[not found] ` <871vxq217k.fsf-xNZwKgViW5gAvxtiuMwx3w@public.gmane.org>
2008-11-05 8:59 ` Alexey Fisher
2008-11-05 8:59 ` Alexey Fisher
2008-11-05 10:20 ` Kalle Valo
2008-11-05 10:20 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1225838828.22671.0.camel@localhost.localdomain \
--to=dcbw-h+wxahxf7alqt0dzr+alfa@public.gmane.org \
--cc=bug-track-M18mAb7Tlt0yCq4wW13eYl6hYfS7NtTn@public.gmane.org \
--cc=kernel-testers-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-wireless-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linville-2XuSBdqkA4R54TAoqtyWWQ@public.gmane.org \
--cc=rjw-KKrjLPT3xs0@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.