From: Kalle Valo <kalle.valo-xNZwKgViW5gAvxtiuMwx3w@public.gmane.org>
To: Alexey Fisher
<bug-track-M18mAb7Tlt0yCq4wW13eYl6hYfS7NtTn@public.gmane.org>
Cc: Dan Williams <dcbw-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>,
linux-wireless-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linville-2XuSBdqkA4R54TAoqtyWWQ@public.gmane.org,
rjw-KKrjLPT3xs0@public.gmane.org,
kernel-testers-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH] make assocaittion only if SSID is known.
Date: Wed, 05 Nov 2008 12:20:28 +0200 [thread overview]
Message-ID: <87skq6fp8z.fsf@nokia.com> (raw)
In-Reply-To: <1225875556.5905.11.camel@zwerg> (ext Alexey Fisher's message of "Wed\, 05 Nov 2008 09\:59\:15 +0100")
Alexey Fisher <bug-track-M18mAb7Tlt0yCq4wW13eYl6hYfS7NtTn@public.gmane.org> writes:
> Am Mittwoch, den 05.11.2008, 07:25 +0200 schrieb Kalle Valo:
>> Dan Williams <dcbw-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> writes:
>>
>> > On Tue, 2008-11-04 at 23:01 +0100, Alexey Fisher wrote:
>> >> 'iwconfig eth1 channel 6' would trigger association to _something_,
>> >> which is wrong. Changing the channel should (and does) trigger
>> >> reassociation, but only if there is an SSID to associate with!
>> >
>> > Heh :) Need the Signed-off-by: here too though.
>>
>> And the subject should contain the driver name, for example like this:
>
> I found some time to _read_ linux-2.6/Documentation/Submit* ! ;)
> but i think it need some "howto submit the patch with git". My englisch
> is to bad to make documentation. Here was my steps:
>
> $git clone
> git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux-2.6.git
> $git pull
> $vi make/changes
> $git-commit -a
In this phase just write the commit log in this style:
----------------------------------------------------------------------
stlc45xx: fix bug in blah blah
stlc45xx was really broken in blah blah blah, I had
to blah blah blah.
Signed-off-by: Kalle Valo <kalle.valo-xNZwKgViW5gAvxtiuMwx3w@public.gmane.org>
----------------------------------------------------------------------
git will take care of the rest.
--
Kalle Valo
WARNING: multiple messages have this Message-ID (diff)
From: Kalle Valo <kalle.valo@nokia.com>
To: "Alexey Fisher" <bug-track@fisher-privat.net>
Cc: Dan Williams <dcbw@redhat.com>,
linux-wireless@vger.kernel.org, linville@tuxdriver.com,
rjw@sisk.pl, kernel-testers@vger.kernel.org
Subject: Re: [PATCH] make assocaittion only if SSID is known.
Date: Wed, 05 Nov 2008 12:20:28 +0200 [thread overview]
Message-ID: <87skq6fp8z.fsf@nokia.com> (raw)
In-Reply-To: <1225875556.5905.11.camel@zwerg> (ext Alexey Fisher's message of "Wed\, 05 Nov 2008 09\:59\:15 +0100")
Alexey Fisher <bug-track@fisher-privat.net> writes:
> Am Mittwoch, den 05.11.2008, 07:25 +0200 schrieb Kalle Valo:
>> Dan Williams <dcbw@redhat.com> writes:
>>
>> > On Tue, 2008-11-04 at 23:01 +0100, Alexey Fisher wrote:
>> >> 'iwconfig eth1 channel 6' would trigger association to _something_,
>> >> which is wrong. Changing the channel should (and does) trigger
>> >> reassociation, but only if there is an SSID to associate with!
>> >
>> > Heh :) Need the Signed-off-by: here too though.
>>
>> And the subject should contain the driver name, for example like this:
>
> I found some time to _read_ linux-2.6/Documentation/Submit* ! ;)
> but i think it need some "howto submit the patch with git". My englisch
> is to bad to make documentation. Here was my steps:
>
> $git clone
> git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux-2.6.git
> $git pull
> $vi make/changes
> $git-commit -a
In this phase just write the commit log in this style:
----------------------------------------------------------------------
stlc45xx: fix bug in blah blah
stlc45xx was really broken in blah blah blah, I had
to blah blah blah.
Signed-off-by: Kalle Valo <kalle.valo@nokia.com>
----------------------------------------------------------------------
git will take care of the rest.
--
Kalle Valo
next prev parent reply other threads:[~2008-11-05 10:20 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-04 22:01 [PATCH] make assocaittion only if SSID is known Alexey Fisher
2008-11-04 22:01 ` Alexey Fisher
[not found] ` <1225836101-5723-1-git-send-email-bug-track-M18mAb7Tlt0yCq4wW13eYl6hYfS7NtTn@public.gmane.org>
2008-11-04 22:47 ` Dan Williams
2008-11-04 22:47 ` Dan Williams
[not found] ` <1225838828.22671.0.camel-bi+AKbBUZKY6gyzm1THtWbp2dZbC/Bob@public.gmane.org>
2008-11-05 5:25 ` Kalle Valo
2008-11-05 5:25 ` Kalle Valo
[not found] ` <871vxq217k.fsf-xNZwKgViW5gAvxtiuMwx3w@public.gmane.org>
2008-11-05 8:59 ` Alexey Fisher
2008-11-05 8:59 ` Alexey Fisher
2008-11-05 10:20 ` Kalle Valo [this message]
2008-11-05 10:20 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87skq6fp8z.fsf@nokia.com \
--to=kalle.valo-xnzwkgviw5gavxtiumwx3w@public.gmane.org \
--cc=bug-track-M18mAb7Tlt0yCq4wW13eYl6hYfS7NtTn@public.gmane.org \
--cc=dcbw-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=kernel-testers-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-wireless-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linville-2XuSBdqkA4R54TAoqtyWWQ@public.gmane.org \
--cc=rjw-KKrjLPT3xs0@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.