All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sam Vilain <sam@vilain.net>
To: Junio C Hamano <gitster@pobox.com>
Cc: Francis Galiegue <fg@one2team.com>,
	Francis Galiegue <fge@one2team.com>,
	git@vger.kernel.org
Subject: Re: [PATCH] sha1_file: make sure correct error is propagated
Date: Sat, 15 Nov 2008 19:30:23 +1300	[thread overview]
Message-ID: <1226730623.26334.2.camel@maia.lan> (raw)
In-Reply-To: <7vr65d7dct.fsf@gitster.siamese.dyndns.org>

On Fri, 2008-11-14 at 21:44 -0800, Junio C Hamano wrote:
> Actually, POSIX does not even talk about EPERM for mkdir(2), but that was
> not my point.  The code does something different from what the proposed
> commit log message talks about.  That was what bothered me.

My wording was a little terse and confusing.  Here's a new one;

Subject: sha1_file.c: resolve confusion EACCESS vs EPERM

EPERM or 'Operation not permitted' is an unlikely error from
mkstemp(); test for EACCESS 'Access Denied' instead.  Make the
special branch which prints the error to the user nicely also
understand EACCESS.

      reply	other threads:[~2008-11-15  6:31 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-11-14  7:19 [PATCH] sha1_file: make sure correct error is propagated Sam Vilain
2008-11-14  7:44 ` Francis Galiegue
2008-11-14  9:41   ` Sam Vilain
2008-11-14 19:05     ` Junio C Hamano
2008-11-14 19:09       ` Francis Galiegue
2008-11-14 19:50         ` Andreas Ericsson
2008-11-14 20:08           ` Francis Galiegue
2008-11-15  5:44         ` Junio C Hamano
2008-11-15  6:30           ` Sam Vilain [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1226730623.26334.2.camel@maia.lan \
    --to=sam@vilain.net \
    --cc=fg@one2team.com \
    --cc=fge@one2team.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.