From: Junio C Hamano <gitster@pobox.com>
To: Sam Vilain <sam@vilain.net>
Cc: Francis Galiegue <fge@one2team.com>, git@vger.kernel.org
Subject: Re: [PATCH] sha1_file: make sure correct error is propagated
Date: Fri, 14 Nov 2008 11:05:19 -0800 [thread overview]
Message-ID: <7vfxlu9lhs.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: <1226655681.17731.4.camel@maia.lan> (Sam Vilain's message of "Fri, 14 Nov 2008 22:41:21 +1300")
Sam Vilain <sam@vilain.net> writes:
> Subject: sha1_file: accept EACCESS as equivalent to EPERM
>
> This was testing for 'Operation not permitted' rather than any kind
> of 'Permission Denied' error; prefer EACCESS.
>
> Signed-off-by: Sam Vilain <sam@vilain.net>
> --
> Sorry for the inevitable wrapping/whitespace fail :(
>
> diff --git a/sha1_file.c b/sha1_file.c
> index 7662330..cd422e6 100644
> --- a/sha1_file.c
> +++ b/sha1_file.c
> @@ -2231,7 +2231,7 @@ static int create_tmpfile(char *buffer, size_t
> bufsiz, const char *filename)
> memcpy(buffer, filename, dirlen);
> strcpy(buffer + dirlen, "tmp_obj_XXXXXX");
> fd = mkstemp(buffer);
> - if (fd < 0 && dirlen && (errno != EPERM)) {
> + if (fd < 0 && dirlen && (errno != EACCESS)) {
Is this accepting the two as equivalents???
next prev parent reply other threads:[~2008-11-14 19:07 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-14 7:19 [PATCH] sha1_file: make sure correct error is propagated Sam Vilain
2008-11-14 7:44 ` Francis Galiegue
2008-11-14 9:41 ` Sam Vilain
2008-11-14 19:05 ` Junio C Hamano [this message]
2008-11-14 19:09 ` Francis Galiegue
2008-11-14 19:50 ` Andreas Ericsson
2008-11-14 20:08 ` Francis Galiegue
2008-11-15 5:44 ` Junio C Hamano
2008-11-15 6:30 ` Sam Vilain
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vfxlu9lhs.fsf@gitster.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=fge@one2team.com \
--cc=git@vger.kernel.org \
--cc=sam@vilain.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.