From: Francis Galiegue <fge@one2team.com>
To: Sam Vilain <sam@vilain.net>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] sha1_file: make sure correct error is propagated
Date: Fri, 14 Nov 2008 08:44:58 +0100 [thread overview]
Message-ID: <200811140844.58746.fge@one2team.com> (raw)
In-Reply-To: <1226647174-15844-1-git-send-email-sam@vilain.net>
Le vendredi 14 novembre 2008, Sam Vilain a écrit :
> From: Sam Vilain <samv@maia.lan>
>
> In the case that a object directory exists, but is not writable, the
> code path that tries to create it is followed and the returned errno
> and path that of the directory tried to be created. The resultant
> error message is confusing.
>
> So, if the mkstemp() fails with EPERM, don't try to create the
> directory - return straight away.
>
Are you sure you didn't mean EACCESS?
--
Francis Galiegue
ONE2TEAM
Ingénieur système
Mob : +33 (0) 6 83 87 78 75
Tel : +33 (0) 1 78 94 55 52
fge@one2team.com
40 avenue Raymond Poincaré
75116 Paris
next prev parent reply other threads:[~2008-11-14 7:49 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-14 7:19 [PATCH] sha1_file: make sure correct error is propagated Sam Vilain
2008-11-14 7:44 ` Francis Galiegue [this message]
2008-11-14 9:41 ` Sam Vilain
2008-11-14 19:05 ` Junio C Hamano
2008-11-14 19:09 ` Francis Galiegue
2008-11-14 19:50 ` Andreas Ericsson
2008-11-14 20:08 ` Francis Galiegue
2008-11-15 5:44 ` Junio C Hamano
2008-11-15 6:30 ` Sam Vilain
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200811140844.58746.fge@one2team.com \
--to=fge@one2team.com \
--cc=git@vger.kernel.org \
--cc=sam@vilain.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.