All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Takashi Iwai <tiwai@suse.de>
Cc: alsa-devel@alsa-project.org,
	Mark Brown <broonie@opensource.wolfsonmicro.com>,
	Cliff Cai <cliff.cai@analog.com>, Bryan Wu <cooloney@kernel.org>
Subject: [PATCH 12/17] ASoC: Blackfin: Fix AD1980/1 build with MMAP support disabled
Date: Tue, 18 Nov 2008 12:38:18 +0000	[thread overview]
Message-ID: <1227011903-2825-12-git-send-email-broonie@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <1227011903-2825-11-git-send-email-broonie@opensource.wolfsonmicro.com>

From: Cliff Cai <cliff.cai@analog.com>

clean up redudent code and correct building problem in non-mmap mode

Signed-off-by: Cliff Cai <cliff.cai@analog.com>
Signed-off-by: Bryan Wu <cooloney@kernel.org>
Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
---
 sound/soc/blackfin/bf5xx-ac97-pcm.c |   22 +++-------------------
 1 files changed, 3 insertions(+), 19 deletions(-)

diff --git a/sound/soc/blackfin/bf5xx-ac97-pcm.c b/sound/soc/blackfin/bf5xx-ac97-pcm.c
index 4be1a49..4d25f73 100644
--- a/sound/soc/blackfin/bf5xx-ac97-pcm.c
+++ b/sound/soc/blackfin/bf5xx-ac97-pcm.c
@@ -193,8 +193,10 @@ static int bf5xx_pcm_trigger(struct snd_pcm_substream *substream, int cmd)
 	switch (cmd) {
 	case SNDRV_PCM_TRIGGER_START:
 		if (substream->stream == SNDRV_PCM_STREAM_PLAYBACK) {
+#if defined(CONFIG_SND_BF5XX_MMAP_SUPPORT)
 			bf5xx_mmap_copy(substream, runtime->period_size);
 			sport->tx_delay_pos = 0;
+#endif
 			sport_tx_start(sport);
 		} else
 			sport_rx_start(sport);
@@ -267,23 +269,6 @@ static int bf5xx_pcm_open(struct snd_pcm_substream *substream)
 	return ret;
 }
 
-static int bf5xx_pcm_close(struct snd_pcm_substream *substream)
-{
-	struct snd_pcm_runtime *runtime = substream->runtime;
-	struct sport_device *sport = runtime->private_data;
-
-	pr_debug("%s enter\n", __func__);
-	if (substream->stream == SNDRV_PCM_STREAM_PLAYBACK) {
-		sport->once = 0;
-		memset(sport->tx_dma_buf, 0, runtime->buffer_size *
-			sizeof(struct ac97_frame));
-	} else
-		memset(sport->rx_dma_buf, 0, runtime->buffer_size *
-			sizeof(struct ac97_frame));
-
-	return 0;
-}
-
 #if defined(CONFIG_SND_BF5XX_MMAP_SUPPORT)
 static int bf5xx_pcm_mmap(struct snd_pcm_substream *substream,
 	struct vm_area_struct *vma)
@@ -301,7 +286,7 @@ static	int bf5xx_pcm_copy(struct snd_pcm_substream *substream, int channel,
 		    void __user *buf, snd_pcm_uframes_t count)
 {
 	struct snd_pcm_runtime *runtime = substream->runtime;
-
+	unsigned int chan_mask = ac97_chan_mask[runtime->channels - 1];
 	pr_debug("%s copy pos:0x%lx count:0x%lx\n",
 			substream->stream ? "Capture" : "Playback", pos, count);
 
@@ -317,7 +302,6 @@ static	int bf5xx_pcm_copy(struct snd_pcm_substream *substream, int channel,
 
 struct snd_pcm_ops bf5xx_pcm_ac97_ops = {
 	.open		= bf5xx_pcm_open,
-	.close		= bf5xx_pcm_close,
 	.ioctl		= snd_pcm_lib_ioctl,
 	.hw_params	= bf5xx_pcm_hw_params,
 	.hw_free	= bf5xx_pcm_hw_free,
-- 
1.5.6.5

  reply	other threads:[~2008-11-18 12:38 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-11-18 12:38 [PATCH 01/17] ASoC: Fix for master playback/capture volume range for TWL4030 codec Mark Brown
2008-11-18 12:38 ` [PATCH 02/17] ASoC: UDA134x codec driver Mark Brown
2008-11-18 12:38   ` [PATCH 03/17] ASoC: Machine driver for for s3c24xx with uda134x Mark Brown
2008-11-18 12:38     ` [PATCH 04/17] ASoC: Allow writes to uncached registers in WM8990 Mark Brown
2008-11-18 12:38       ` [PATCH 05/17] ASoC: Enable WM8990 ADC clocking workaround Mark Brown
2008-11-18 12:38         ` [PATCH 06/17] ASoC: Manage VMID mode for WM8990 Mark Brown
2008-11-18 12:38           ` [PATCH 07/17] ASoC: Build tlv320aic23 cleanly Mark Brown
2008-11-18 12:38             ` [PATCH 08/17] ASoC: DaVinci: Fix audio stall when doing full duplex Mark Brown
2008-11-18 12:38               ` [PATCH 09/17] ASoC: Blackfin: updates Kconfig for SPORT Mark Brown
2008-11-18 12:38                 ` [PATCH 10/17] ASoC: AD1980 codec: add multi-channel function support Mark Brown
2008-11-18 12:38                   ` [PATCH 11/17] ASoC: Blackfin: " Mark Brown
2008-11-18 12:38                     ` Mark Brown [this message]
2008-11-18 12:38                       ` [PATCH 13/17] ASoC: Fix Blackfin AC97 DAI probe function return code Mark Brown
2008-11-18 12:38                         ` [PATCH 14/17] ASoC: Blackfin: do not force TWI bus for ssm2602 codec Mark Brown
2008-11-18 12:38                           ` [PATCH 15/17] ASoC: Blackfin: Simplify the MMAP_SUPPORT macros protected code Mark Brown
2008-11-18 12:38                             ` [PATCH 16/17] ASoC: Blackfin: always set a default value for that GPIO range Mark Brown
2008-11-18 12:38                               ` [PATCH 17/17] ASoC: Move uda134x_codec.h to uda134x.h Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1227011903-2825-12-git-send-email-broonie@opensource.wolfsonmicro.com \
    --to=broonie@opensource.wolfsonmicro.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=cliff.cai@analog.com \
    --cc=cooloney@kernel.org \
    --cc=tiwai@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.