From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Takashi Iwai <tiwai@suse.de>
Cc: alsa-devel@alsa-project.org,
Mark Brown <broonie@opensource.wolfsonmicro.com>
Subject: [PATCH 04/17] ASoC: Allow writes to uncached registers in WM8990
Date: Tue, 18 Nov 2008 12:38:10 +0000 [thread overview]
Message-ID: <1227011903-2825-4-git-send-email-broonie@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <1227011903-2825-3-git-send-email-broonie@opensource.wolfsonmicro.com>
Only fully documented registers are cached in the WM8990 but additional
registers exist.
Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
---
sound/soc/codecs/wm8990.c | 6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/sound/soc/codecs/wm8990.c b/sound/soc/codecs/wm8990.c
index 572d22b..5c84f02 100644
--- a/sound/soc/codecs/wm8990.c
+++ b/sound/soc/codecs/wm8990.c
@@ -106,6 +106,7 @@ static const u16 wm8990_reg[] = {
0x0008, /* R60 - PLL1 */
0x0031, /* R61 - PLL2 */
0x0026, /* R62 - PLL3 */
+ 0x0000, /* R63 - Driver internal */
};
/*
@@ -126,10 +127,9 @@ static inline void wm8990_write_reg_cache(struct snd_soc_codec *codec,
unsigned int reg, unsigned int value)
{
u16 *cache = codec->reg_cache;
- BUG_ON(reg > (ARRAY_SIZE(wm8990_reg)) - 1);
- /* Reset register is uncached */
- if (reg == 0)
+ /* Reset register and reserved registers are uncached */
+ if (reg == 0 || reg > ARRAY_SIZE(wm8990_reg) - 1)
return;
cache[reg] = value;
--
1.5.6.5
next prev parent reply other threads:[~2008-11-18 12:38 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-18 12:38 [PATCH 01/17] ASoC: Fix for master playback/capture volume range for TWL4030 codec Mark Brown
2008-11-18 12:38 ` [PATCH 02/17] ASoC: UDA134x codec driver Mark Brown
2008-11-18 12:38 ` [PATCH 03/17] ASoC: Machine driver for for s3c24xx with uda134x Mark Brown
2008-11-18 12:38 ` Mark Brown [this message]
2008-11-18 12:38 ` [PATCH 05/17] ASoC: Enable WM8990 ADC clocking workaround Mark Brown
2008-11-18 12:38 ` [PATCH 06/17] ASoC: Manage VMID mode for WM8990 Mark Brown
2008-11-18 12:38 ` [PATCH 07/17] ASoC: Build tlv320aic23 cleanly Mark Brown
2008-11-18 12:38 ` [PATCH 08/17] ASoC: DaVinci: Fix audio stall when doing full duplex Mark Brown
2008-11-18 12:38 ` [PATCH 09/17] ASoC: Blackfin: updates Kconfig for SPORT Mark Brown
2008-11-18 12:38 ` [PATCH 10/17] ASoC: AD1980 codec: add multi-channel function support Mark Brown
2008-11-18 12:38 ` [PATCH 11/17] ASoC: Blackfin: " Mark Brown
2008-11-18 12:38 ` [PATCH 12/17] ASoC: Blackfin: Fix AD1980/1 build with MMAP support disabled Mark Brown
2008-11-18 12:38 ` [PATCH 13/17] ASoC: Fix Blackfin AC97 DAI probe function return code Mark Brown
2008-11-18 12:38 ` [PATCH 14/17] ASoC: Blackfin: do not force TWI bus for ssm2602 codec Mark Brown
2008-11-18 12:38 ` [PATCH 15/17] ASoC: Blackfin: Simplify the MMAP_SUPPORT macros protected code Mark Brown
2008-11-18 12:38 ` [PATCH 16/17] ASoC: Blackfin: always set a default value for that GPIO range Mark Brown
2008-11-18 12:38 ` [PATCH 17/17] ASoC: Move uda134x_codec.h to uda134x.h Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1227011903-2825-4-git-send-email-broonie@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=alsa-devel@alsa-project.org \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.