From: Martin Schwidefsky <schwidefsky@de.ibm.com>
To: Julia Lawall <julia@diku.dk>
Cc: heiko.carstens@de.ibm.com, linux390@de.ibm.com,
linux-s390@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH 1/2] drivers/s390/crypto: Move dereference to after
Date: Mon, 08 Dec 2008 09:06:29 +0000 [thread overview]
Message-ID: <1228727189.15048.1.camel@localhost> (raw)
In-Reply-To: <Pine.LNX.4.64.0812072314270.7130@ask.diku.dk>
On Sun, 2008-12-07 at 23:14 +0100, Julia Lawall wrote:
> If reply is ERR_PTR(...), then it should not be dereferenced, so I have
> moved the dereference from the declaration to after the IS_ERR test.
Nice finding again. That semantic match tools is really useful.
Thanks, I'll add the patch to my collection.
--
blue skies,
Martin.
"Reality continues to ruin my life." - Calvin.
WARNING: multiple messages have this Message-ID (diff)
From: Martin Schwidefsky <schwidefsky@de.ibm.com>
To: Julia Lawall <julia@diku.dk>
Cc: heiko.carstens@de.ibm.com, linux390@de.ibm.com,
linux-s390@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH 1/2] drivers/s390/crypto: Move dereference to after IS_ERR test
Date: Mon, 08 Dec 2008 10:06:29 +0100 [thread overview]
Message-ID: <1228727189.15048.1.camel@localhost> (raw)
In-Reply-To: <Pine.LNX.4.64.0812072314270.7130@ask.diku.dk>
On Sun, 2008-12-07 at 23:14 +0100, Julia Lawall wrote:
> If reply is ERR_PTR(...), then it should not be dereferenced, so I have
> moved the dereference from the declaration to after the IS_ERR test.
Nice finding again. That semantic match tools is really useful.
Thanks, I'll add the patch to my collection.
--
blue skies,
Martin.
"Reality continues to ruin my life." - Calvin.
next prev parent reply other threads:[~2008-12-08 9:06 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-07 22:14 [PATCH 1/2] drivers/s390/crypto: Move dereference to after IS_ERR Julia Lawall
2008-12-07 22:14 ` [PATCH 1/2] drivers/s390/crypto: Move dereference to after IS_ERR test Julia Lawall
2008-12-08 9:06 ` Martin Schwidefsky [this message]
2008-12-08 9:06 ` Martin Schwidefsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1228727189.15048.1.camel@localhost \
--to=schwidefsky@de.ibm.com \
--cc=heiko.carstens@de.ibm.com \
--cc=julia@diku.dk \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=linux390@de.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.