From: Harvey Harrison <harvey.harrison@gmail.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Adrian McMenamin <adrian@newgolddream.dyndns.info>,
linux-kernel@vger.kernel.org, dmitry.torokhov@gmail.com,
linux-sh@vger.kernel.org, lethal@linux-sh.org
Subject: Re: [PATCH] sh: maple: add support for Maple controller as a
Date: Tue, 23 Dec 2008 01:07:35 +0000 [thread overview]
Message-ID: <1229994455.22856.61.camel@brick> (raw)
In-Reply-To: <20081222150636.8dc20d61.akpm@linux-foundation.org>
On Mon, 2008-12-22 at 15:06 -0800, Andrew Morton wrote:
> On Fri, 19 Dec 2008 23:15:42 +0000
> Adrian McMenamin <adrian@newgolddream.dyndns.info> wrote:
>
> > Not sure what happened with earlier submissions, so here is an up-to-date
> > patch for the Dreamcast Maple controlled.
> >
> >
> > Add support for the SEGA Dreamcast Maple controller as a joystick
> >
> > ...
> >
> > +static void dc_pad_callback(struct mapleq *mq)
> > +{
> > + unsigned short buttons;
> > + struct maple_device *mapledev = mq->dev;
> > + struct dc_pad *pad = maple_get_drvdata(mapledev);
> > + struct input_dev *dev = pad->dev;
> > + unsigned char *res = mq->recvbuf;
> > +
> > + buttons = ~cpu_to_le16(*(unsigned short *)(res + 8));
>
> hm, could that be simplified?
And as a bonus fix the obvious sparse warning:
buttons = ~le16_to_cpup((__le16 *)(res + 8));
Cheers,
Harvey
WARNING: multiple messages have this Message-ID (diff)
From: Harvey Harrison <harvey.harrison@gmail.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Adrian McMenamin <adrian@newgolddream.dyndns.info>,
linux-kernel@vger.kernel.org, dmitry.torokhov@gmail.com,
linux-sh@vger.kernel.org, lethal@linux-sh.org
Subject: Re: [PATCH] sh: maple: add support for Maple controller as a joystick
Date: Mon, 22 Dec 2008 17:07:35 -0800 [thread overview]
Message-ID: <1229994455.22856.61.camel@brick> (raw)
In-Reply-To: <20081222150636.8dc20d61.akpm@linux-foundation.org>
On Mon, 2008-12-22 at 15:06 -0800, Andrew Morton wrote:
> On Fri, 19 Dec 2008 23:15:42 +0000
> Adrian McMenamin <adrian@newgolddream.dyndns.info> wrote:
>
> > Not sure what happened with earlier submissions, so here is an up-to-date
> > patch for the Dreamcast Maple controlled.
> >
> >
> > Add support for the SEGA Dreamcast Maple controller as a joystick
> >
> > ...
> >
> > +static void dc_pad_callback(struct mapleq *mq)
> > +{
> > + unsigned short buttons;
> > + struct maple_device *mapledev = mq->dev;
> > + struct dc_pad *pad = maple_get_drvdata(mapledev);
> > + struct input_dev *dev = pad->dev;
> > + unsigned char *res = mq->recvbuf;
> > +
> > + buttons = ~cpu_to_le16(*(unsigned short *)(res + 8));
>
> hm, could that be simplified?
And as a bonus fix the obvious sparse warning:
buttons = ~le16_to_cpup((__le16 *)(res + 8));
Cheers,
Harvey
next prev parent reply other threads:[~2008-12-23 1:07 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-19 23:15 [PATCH] sh: maple: add support for Maple controller as a joystick Adrian McMenamin
2008-12-20 15:16 ` [PATCH] sh: maple: add support for Maple controller as a Matt Fleming
2008-12-20 15:16 ` [PATCH] sh: maple: add support for Maple controller as a joystick Matt Fleming
2008-12-20 16:07 ` [PATCH] sh: maple: add support for Maple controller as a Adrian McMenamin
2008-12-20 16:07 ` [PATCH] sh: maple: add support for Maple controller as a joystick Adrian McMenamin
2008-12-20 20:19 ` Dmitry Torokhov
2008-12-20 20:19 ` Dmitry Torokhov
2008-12-20 20:47 ` [PATCH] sh: maple: add support for Maple controller as a Adrian McMenamin
2008-12-20 20:47 ` [PATCH] sh: maple: add support for Maple controller as a joystick Adrian McMenamin
2008-12-20 22:17 ` Dmitry Torokhov
2008-12-20 22:17 ` Dmitry Torokhov
2008-12-21 6:47 ` Paul Mundt
2008-12-21 6:47 ` Paul Mundt
2008-12-21 9:16 ` Rabin Vincent
2008-12-21 9:28 ` [PATCH] sh: maple: add support for Maple controller as a Rabin Vincent
2008-12-22 23:06 ` Andrew Morton
2008-12-22 23:06 ` [PATCH] sh: maple: add support for Maple controller as a joystick Andrew Morton
2008-12-23 1:07 ` Harvey Harrison [this message]
2008-12-23 1:07 ` Harvey Harrison
2008-12-23 8:59 ` [PATCH] sh: maple: add support for Maple controller as a Dmitry Torokhov
2008-12-23 8:59 ` [PATCH] sh: maple: add support for Maple controller as a joystick Dmitry Torokhov
2008-12-26 19:08 ` [PATCH] sh: maple: add support for Maple controller as a Adrian McMenamin
2008-12-26 19:08 ` [PATCH] sh: maple: add support for Maple controller as a joystick Adrian McMenamin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1229994455.22856.61.camel@brick \
--to=harvey.harrison@gmail.com \
--cc=adrian@newgolddream.dyndns.info \
--cc=akpm@linux-foundation.org \
--cc=dmitry.torokhov@gmail.com \
--cc=lethal@linux-sh.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.