From: Matt Fleming <matt@console-pimps.org>
To: Adrian McMenamin <adrian@newgolddream.dyndns.info>
Cc: LKML <linux-kernel@vger.kernel.org>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
linux-sh <linux-sh@vger.kernel.org>,
Andrew Morton <akpm@osdl.org>, Paul Mundt <lethal@linux-sh.org>
Subject: Re: [PATCH] sh: maple: add support for Maple controller as a
Date: Sat, 20 Dec 2008 15:16:59 +0000 [thread overview]
Message-ID: <20081220151511.GA6528@console-pimps.org> (raw)
In-Reply-To: <1229728542.1441.6.camel@localhost.localdomain>
On Fri, Dec 19, 2008 at 11:15:42PM +0000, Adrian McMenamin wrote:
>
> Add support for the SEGA Dreamcast Maple controller as a joystick
>
[snip]
> + struct dc_pad *pad = maple_get_drvdata(mapledev);
> + struct input_dev *dev = pad->dev;
> + unsigned char *res = mq->recvbuf;
> +
> + buttons = ~cpu_to_le16(*(unsigned short *)(res + 8));
> +
I may be wrong but shouldn't this use the I/O accessor functions?
> +
> + pad = kzalloc(sizeof(struct dc_pad), GFP_KERNEL);
> + idev = input_allocate_device();
> + if (!pad || !idev){
> + error = ENOMEM;
> + goto fail;
> + }
[snip]
> +fail:
> + input_free_device(pad->dev);
Possible NULL pointer dereference?
WARNING: multiple messages have this Message-ID (diff)
From: Matt Fleming <matt@console-pimps.org>
To: Adrian McMenamin <adrian@newgolddream.dyndns.info>
Cc: LKML <linux-kernel@vger.kernel.org>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
linux-sh <linux-sh@vger.kernel.org>,
Andrew Morton <akpm@osdl.org>, Paul Mundt <lethal@linux-sh.org>
Subject: Re: [PATCH] sh: maple: add support for Maple controller as a joystick
Date: Sat, 20 Dec 2008 15:16:59 +0000 [thread overview]
Message-ID: <20081220151511.GA6528@console-pimps.org> (raw)
In-Reply-To: <1229728542.1441.6.camel@localhost.localdomain>
On Fri, Dec 19, 2008 at 11:15:42PM +0000, Adrian McMenamin wrote:
>
> Add support for the SEGA Dreamcast Maple controller as a joystick
>
[snip]
> + struct dc_pad *pad = maple_get_drvdata(mapledev);
> + struct input_dev *dev = pad->dev;
> + unsigned char *res = mq->recvbuf;
> +
> + buttons = ~cpu_to_le16(*(unsigned short *)(res + 8));
> +
I may be wrong but shouldn't this use the I/O accessor functions?
> +
> + pad = kzalloc(sizeof(struct dc_pad), GFP_KERNEL);
> + idev = input_allocate_device();
> + if (!pad || !idev){
> + error = ENOMEM;
> + goto fail;
> + }
[snip]
> +fail:
> + input_free_device(pad->dev);
Possible NULL pointer dereference?
next prev parent reply other threads:[~2008-12-20 15:16 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-19 23:15 [PATCH] sh: maple: add support for Maple controller as a joystick Adrian McMenamin
2008-12-20 15:16 ` Matt Fleming [this message]
2008-12-20 15:16 ` Matt Fleming
2008-12-20 16:07 ` [PATCH] sh: maple: add support for Maple controller as a Adrian McMenamin
2008-12-20 16:07 ` [PATCH] sh: maple: add support for Maple controller as a joystick Adrian McMenamin
2008-12-20 20:19 ` Dmitry Torokhov
2008-12-20 20:19 ` Dmitry Torokhov
2008-12-20 20:47 ` [PATCH] sh: maple: add support for Maple controller as a Adrian McMenamin
2008-12-20 20:47 ` [PATCH] sh: maple: add support for Maple controller as a joystick Adrian McMenamin
2008-12-20 22:17 ` Dmitry Torokhov
2008-12-20 22:17 ` Dmitry Torokhov
2008-12-21 6:47 ` Paul Mundt
2008-12-21 6:47 ` Paul Mundt
2008-12-21 9:16 ` Rabin Vincent
2008-12-21 9:28 ` [PATCH] sh: maple: add support for Maple controller as a Rabin Vincent
2008-12-22 23:06 ` Andrew Morton
2008-12-22 23:06 ` [PATCH] sh: maple: add support for Maple controller as a joystick Andrew Morton
2008-12-23 1:07 ` [PATCH] sh: maple: add support for Maple controller as a Harvey Harrison
2008-12-23 1:07 ` [PATCH] sh: maple: add support for Maple controller as a joystick Harvey Harrison
2008-12-23 8:59 ` [PATCH] sh: maple: add support for Maple controller as a Dmitry Torokhov
2008-12-23 8:59 ` [PATCH] sh: maple: add support for Maple controller as a joystick Dmitry Torokhov
2008-12-26 19:08 ` [PATCH] sh: maple: add support for Maple controller as a Adrian McMenamin
2008-12-26 19:08 ` [PATCH] sh: maple: add support for Maple controller as a joystick Adrian McMenamin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081220151511.GA6528@console-pimps.org \
--to=matt@console-pimps.org \
--cc=adrian@newgolddream.dyndns.info \
--cc=akpm@osdl.org \
--cc=dmitry.torokhov@gmail.com \
--cc=lethal@linux-sh.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.