From: Dave Hansen <dave@linux.vnet.ibm.com>
To: Chandru <chandru@in.ibm.com>
Cc: linuxppc-dev@ozlabs.org,
Andrew Morton <akpm@linux-foundation.org>,
Paul Mackerras <paulus@samba.org>,
linux-kernel@vger.kernel.org
Subject: Re: 2.6.28-rc9 panics with crashkernel=256M while booting
Date: Wed, 07 Jan 2009 09:25:25 -0800 [thread overview]
Message-ID: <1231349125.23462.81.camel@nimitz> (raw)
In-Reply-To: <200901071828.13719.chandru@in.ibm.com>
On Wed, 2009-01-07 at 18:28 +0530, Chandru wrote:
> I don't know how you wanted NODE_DATA() to be consulted here. i.e before
> calling reserve_bootmem_node() should we have a condition
>
> if (PFN_UP(physbase+reserve_size) > node_end_pfn)
> then
> resize reserve_size again so that PFN_UP() will equate to node_end_pfn ??
> end
I'm just suggesting making your fix in the ppc code instead of in
mm/bootmem.c.
-- Dave
WARNING: multiple messages have this Message-ID (diff)
From: Dave Hansen <dave@linux.vnet.ibm.com>
To: Chandru <chandru@in.ibm.com>
Cc: Paul Mackerras <paulus@samba.org>,
Andrew Morton <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org, linuxppc-dev@ozlabs.org,
Benjamin Herrenschmidt <benh@kernel.crashing.org>
Subject: Re: 2.6.28-rc9 panics with crashkernel=256M while booting
Date: Wed, 07 Jan 2009 09:25:25 -0800 [thread overview]
Message-ID: <1231349125.23462.81.camel@nimitz> (raw)
In-Reply-To: <200901071828.13719.chandru@in.ibm.com>
On Wed, 2009-01-07 at 18:28 +0530, Chandru wrote:
> I don't know how you wanted NODE_DATA() to be consulted here. i.e before
> calling reserve_bootmem_node() should we have a condition
>
> if (PFN_UP(physbase+reserve_size) > node_end_pfn)
> then
> resize reserve_size again so that PFN_UP() will equate to node_end_pfn ??
> end
I'm just suggesting making your fix in the ppc code instead of in
mm/bootmem.c.
-- Dave
next prev parent reply other threads:[~2009-01-07 17:25 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-24 7:55 2.6.28-rc9 panics with crashkernel=256M while booting Chandru
2008-12-25 7:35 ` Andrew Morton
2008-12-25 7:35 ` Andrew Morton
2008-12-25 8:07 ` Andrew Morton
2008-12-26 6:35 ` Chandru
2008-12-26 0:59 ` Paul Mackerras
2008-12-26 0:59 ` Paul Mackerras
2008-12-29 21:36 ` Dave Hansen
2008-12-29 21:36 ` Dave Hansen
2009-01-05 13:49 ` Chandru
2009-01-05 13:49 ` Chandru
2009-01-05 16:30 ` Dave Hansen
2009-01-05 16:30 ` Dave Hansen
2009-01-07 12:58 ` Chandru
2009-01-07 12:58 ` Chandru
2009-01-07 17:25 ` Dave Hansen [this message]
2009-01-07 17:25 ` Dave Hansen
2009-01-08 10:29 ` Chandru
2009-01-08 10:29 ` Chandru
2009-01-08 20:03 ` Dave Hansen
2009-01-08 20:03 ` Dave Hansen
2009-01-09 11:07 ` Chandru
2009-01-09 11:07 ` Chandru
2009-01-15 8:05 ` Chandru
2009-01-15 8:05 ` Chandru
2009-01-16 12:16 ` Chandru
2009-01-16 12:16 ` Chandru
2009-01-16 17:52 ` Dave Hansen
2009-01-16 17:52 ` Dave Hansen
2009-01-19 8:11 ` Chandru
2009-01-19 8:11 ` Chandru
2009-01-19 11:30 ` Chandru
2009-01-19 11:30 ` Chandru
2009-01-20 8:13 ` Chandru
2009-01-22 0:29 ` Dave Hansen
2009-01-22 0:29 ` Dave Hansen
2009-01-22 8:20 ` Chandru
2009-01-22 8:20 ` Chandru
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1231349125.23462.81.camel@nimitz \
--to=dave@linux.vnet.ibm.com \
--cc=akpm@linux-foundation.org \
--cc=chandru@in.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.