All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jaswinder Singh Rajput <jaswinder@kernel.org>
To: Stephen Rothwell <sfr@canb.auug.org.au>
Cc: urs.thuermann@volkswagen.de, neilb@suse.de, greg@kroah.com,
	bfields@fieldses.org, linux-mtd@lists.infradead.org,
	dbrownell@users.sourceforge.net, x86 maintainers <x86@kernel.org>,
	tiwai@suse.de, Ingo Molnar <mingo@elte.hu>,
	linux-media@vger.kernel.org, mchehab@infradead.org,
	linux-raid@vger.kernel.org, netfilter@vger.kernel.org,
	linux-nfs@vger.kernel.org, netdev@vger.kernel.org,
	linux-usb@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>,
	netfilter-devel@vger.kernel.org, oliver.hartkopp@volkswagen.de,
	spi-devel-general@lists.sourceforge.net,
	Andrew Morton <akpm@linux-foundation.org>,
	dwmw2@infradead.org
Subject: Re: [GIT PULL -tip] fix 33 make headers_check warnings
Date: Mon, 19 Jan 2009 08:23:14 +0530	[thread overview]
Message-ID: <1232333594.3129.31.camel@localhost.localdomain> (raw)
In-Reply-To: <20090119112429.78f5dc33.sfr@canb.auug.org.au>

On Mon, 2009-01-19 at 11:24 +1100, Stephen Rothwell wrote:
> On Sun, 18 Jan 2009 01:47:21 +0530 Jaswinder Singh Rajput <jaswinder@kernel.org> wrote:
> >
> > diff --git a/include/linux/nfsd/stats.h b/include/linux/nfsd/stats.h
> > index 7678cfb..0b53cfe 100644
> > --- a/include/linux/nfsd/stats.h
> > +++ b/include/linux/nfsd/stats.h
> > @@ -29,9 +29,11 @@ struct nfsd_stats {
> >  	unsigned int	ra_size;	/* size of ra cache */
> >  	unsigned int	ra_depth[11];	/* number of times ra entry was found that deep
> >  					 * in the cache (10percentiles). [10] = not found */
> > +#ifdef __KERNEL__
> >  #ifdef CONFIG_NFSD_V4
> >  	unsigned int	nfs4_opcount[LAST_NFS4_OP + 1];	/* count of individual nfsv4 operations */
> >  #endif
> > +#endif /* __KERNEL__ */
> >  
> >  };
> 
> The only variable in the kernel of type "struct nfsd_stats" is only
> exported to user mode via procfs, so this whole structure could probably
> go inside __KERNEL__.  Then looking harder, I wonder if this header
> should be exported to user mode at all.
> 

I was in doubt may be this will be used by some userspace utilities.

Once I got confirmation that it is not required in userspace, I will
remove it :-)

--
JSR

WARNING: multiple messages have this Message-ID (diff)
From: Jaswinder Singh Rajput <jaswinder@kernel.org>
To: Stephen Rothwell <sfr@canb.auug.org.au>
Cc: Ingo Molnar <mingo@elte.hu>, x86 maintainers <x86@kernel.org>,
	urs.thuermann@volkswagen.de, oliver.hartkopp@volkswagen.de,
	linux-media@vger.kernel.org, netfilter-devel@vger.kernel.org,
	netfilter@vger.kernel.org, bfields@fieldses.org, neilb@suse.de,
	linux-nfs@vger.kernel.org, linux-raid@vger.kernel.org,
	dbrownell@users.sourceforge.net,
	spi-devel-general@lists.sourceforge.net, netdev@vger.kernel.org,
	greg@kroah.com, linux-usb@vger.kernel.org, dwmw2@infradead.org,
	linux-mtd@lists.infradead.org, tiwai@suse.de,
	mchehab@infradead.org, LKML <linux-kernel@vger.kernel.org>,
	Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [GIT PULL -tip] fix 33 make headers_check warnings
Date: Mon, 19 Jan 2009 08:23:14 +0530	[thread overview]
Message-ID: <1232333594.3129.31.camel@localhost.localdomain> (raw)
In-Reply-To: <20090119112429.78f5dc33.sfr@canb.auug.org.au>

On Mon, 2009-01-19 at 11:24 +1100, Stephen Rothwell wrote:
> On Sun, 18 Jan 2009 01:47:21 +0530 Jaswinder Singh Rajput <jaswinder@kernel.org> wrote:
> >
> > diff --git a/include/linux/nfsd/stats.h b/include/linux/nfsd/stats.h
> > index 7678cfb..0b53cfe 100644
> > --- a/include/linux/nfsd/stats.h
> > +++ b/include/linux/nfsd/stats.h
> > @@ -29,9 +29,11 @@ struct nfsd_stats {
> >  	unsigned int	ra_size;	/* size of ra cache */
> >  	unsigned int	ra_depth[11];	/* number of times ra entry was found that deep
> >  					 * in the cache (10percentiles). [10] = not found */
> > +#ifdef __KERNEL__
> >  #ifdef CONFIG_NFSD_V4
> >  	unsigned int	nfs4_opcount[LAST_NFS4_OP + 1];	/* count of individual nfsv4 operations */
> >  #endif
> > +#endif /* __KERNEL__ */
> >  
> >  };
> 
> The only variable in the kernel of type "struct nfsd_stats" is only
> exported to user mode via procfs, so this whole structure could probably
> go inside __KERNEL__.  Then looking harder, I wonder if this header
> should be exported to user mode at all.
> 

I was in doubt may be this will be used by some userspace utilities.

Once I got confirmation that it is not required in userspace, I will
remove it :-)

--
JSR


  reply	other threads:[~2009-01-19  2:54 UTC|newest]

Thread overview: 81+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-01-17 20:17 [GIT PULL -tip] fix 33 make headers_check warnings Jaswinder Singh Rajput
2009-01-17 20:17 ` Jaswinder Singh Rajput
2009-01-17 20:17 ` Jaswinder Singh Rajput
2009-01-17 21:37 ` David Woodhouse
2009-01-17 21:37   ` David Woodhouse
2009-01-17 21:37   ` David Woodhouse
2009-01-17 21:37   ` David Woodhouse
2009-01-17 22:04   ` Jan Engelhardt
2009-01-17 22:04     ` Jan Engelhardt
2009-01-17 22:19   ` Sam Ravnborg
2009-01-17 22:19     ` Sam Ravnborg
2009-01-17 22:23     ` David Woodhouse
2009-01-17 22:23       ` David Woodhouse
2009-01-18  2:46       ` Jaswinder Singh Rajput
2009-01-18  2:46         ` Jaswinder Singh Rajput
2009-01-18  2:46         ` Jaswinder Singh Rajput
2009-01-18  2:46         ` Jaswinder Singh Rajput
2009-01-17 22:26     ` H. Peter Anvin
2009-01-17 22:26       ` H. Peter Anvin
2009-01-21  0:38       ` Jaswinder Singh Rajput
2009-01-21  0:38         ` Jaswinder Singh Rajput
2009-01-21  0:38         ` Jaswinder Singh Rajput
2009-01-21  0:38         ` Jaswinder Singh Rajput
2009-01-23 15:59         ` Jaswinder Singh Rajput
2009-01-23 15:59           ` Jaswinder Singh Rajput
2009-01-23 16:04           ` Jaswinder Singh Rajput
2009-01-23 16:04             ` Jaswinder Singh Rajput
2009-01-23 16:11             ` Jan Engelhardt
2009-01-23 16:11               ` Jan Engelhardt
2009-01-23 16:21               ` Sam Ravnborg
2009-01-23 16:21                 ` Sam Ravnborg
2009-01-23 16:21                 ` Sam Ravnborg
2009-01-23 16:21                 ` Sam Ravnborg
2009-01-23 16:31                 ` Jaswinder Singh Rajput
2009-01-23 16:31                   ` Jaswinder Singh Rajput
2009-01-23 17:09                   ` Sam Ravnborg
2009-01-23 17:09                     ` Sam Ravnborg
2009-01-23 17:09                     ` Sam Ravnborg
2009-01-23 17:09                     ` Sam Ravnborg
2009-01-23 17:28                     ` Jaswinder Singh Rajput
2009-01-23 17:28                       ` Jaswinder Singh Rajput
2009-01-23 21:33               ` H. Peter Anvin
2009-01-23 21:33                 ` H. Peter Anvin
2009-01-23 21:33                 ` H. Peter Anvin
2009-01-23 21:54                 ` Jan Engelhardt
2009-01-23 21:54                   ` Jan Engelhardt
2009-01-23 21:54                   ` Jan Engelhardt
2009-01-23 21:54                   ` Jan Engelhardt
2009-01-23 22:01                   ` H. Peter Anvin
2009-01-23 22:01                     ` H. Peter Anvin
2009-01-18  3:05     ` Jaswinder Singh Rajput
2009-01-18  3:05       ` Jaswinder Singh Rajput
2009-01-18  3:33       ` Kyle McMartin
2009-01-18  3:33         ` Kyle McMartin
2009-01-18  3:38         ` Jaswinder Singh Rajput
2009-01-18  3:38           ` Jaswinder Singh Rajput
2009-01-18  3:38           ` Jaswinder Singh Rajput
2009-01-18  3:38           ` Jaswinder Singh Rajput
2009-01-18  4:18           ` Kyle McMartin
2009-01-18  4:18             ` Kyle McMartin
2009-01-18  4:18             ` Kyle McMartin
2009-01-18  4:18             ` Kyle McMartin
2009-01-23 15:56             ` Jaswinder Singh Rajput
2009-01-23 15:56               ` Jaswinder Singh Rajput
2009-01-23 15:56               ` Jaswinder Singh Rajput
2009-01-23 15:56               ` Jaswinder Singh Rajput
2009-01-18  9:13     ` Ingo Molnar
2009-01-18  9:13       ` Ingo Molnar
2009-01-18 10:10       ` Sam Ravnborg
2009-01-18 10:10         ` Sam Ravnborg
2009-01-18 10:10         ` Sam Ravnborg
2009-01-18 10:10         ` Sam Ravnborg
2009-01-19  0:24 ` Stephen Rothwell
2009-01-19  0:24   ` Stephen Rothwell
2009-01-19  0:24   ` Stephen Rothwell
2009-01-19  0:24   ` Stephen Rothwell
2009-01-19  2:53   ` Jaswinder Singh Rajput [this message]
2009-01-19  2:53     ` Jaswinder Singh Rajput
  -- strict thread matches above, loose matches on Subject: below --
2009-01-17 20:17 Jaswinder Singh Rajput
2009-01-17 20:17 Jaswinder Singh Rajput
2009-01-17 20:17 Jaswinder Singh Rajput

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1232333594.3129.31.camel@localhost.localdomain \
    --to=jaswinder@kernel.org \
    --cc=akpm@linux-foundation.org \
    --cc=bfields@fieldses.org \
    --cc=dbrownell@users.sourceforge.net \
    --cc=dwmw2@infradead.org \
    --cc=greg@kroah.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=linux-nfs@vger.kernel.org \
    --cc=linux-raid@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=mchehab@infradead.org \
    --cc=mingo@elte.hu \
    --cc=neilb@suse.de \
    --cc=netdev@vger.kernel.org \
    --cc=netfilter-devel@vger.kernel.org \
    --cc=netfilter@vger.kernel.org \
    --cc=oliver.hartkopp@volkswagen.de \
    --cc=sfr@canb.auug.org.au \
    --cc=spi-devel-general@lists.sourceforge.net \
    --cc=tiwai@suse.de \
    --cc=urs.thuermann@volkswagen.de \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.