All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jaswinder Singh Rajput <jaswinder@kernel.org>
To: "H. Peter Anvin" <hpa@kernel.org>
Cc: urs.thuermann@volkswagen.de, neilb@suse.de, greg@kroah.com,
	bfields@fieldses.org, linux-mtd@lists.infradead.org,
	Sam Ravnborg <sam@ravnborg.org>,
	dbrownell@users.sourceforge.net, x86 maintainers <x86@kernel.org>,
	tiwai@suse.de, Ingo Molnar <mingo@elte.hu>,
	linux-media@vger.kernel.org, mchehab@infradead.org,
	linux-raid@vger.kernel.org, netfilter@vger.kernel.org,
	linux-nfs@vger.kernel.org, netdev@vger.kernel.org,
	linux-usb@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>,
	netfilter-devel@vger.kernel.org, oliver.hartkopp@volkswagen.de,
	spi-devel-general@lists.sourceforge.net,
	Andrew Morton <akpm@linux-foundation.org>,
	David Woodhouse <dwmw2@infradead.org>
Subject: Re: [GIT PULL -tip] fix 33 make headers_check warnings
Date: Wed, 21 Jan 2009 06:08:39 +0530	[thread overview]
Message-ID: <1232498319.3123.34.camel@localhost.localdomain> (raw)
In-Reply-To: <49725B1E.604@kernel.org>

On Sat, 2009-01-17 at 14:26 -0800, H. Peter Anvin wrote:
> Sam Ravnborg wrote:
> >>>  
> >> That patch looks wrong, and unnecessary. It was fine before.
> > Nope - include/linux/dvb/audio.h failed to include linux/types.h
> > despite the fact that is uses __u32 etc.
> > 
> > But why the _kernel_ should include a userspace header is
> > much more questionable.
> > 
> 
> <stdint.h> is one of a handful of headers provided by gcc itself.
> 

Should I reintroduce my patch to solve this warning of 'make headers_check':
 usr/include/linux/dvb/audio.h:133: found __[us]{8,16,32,64} type without #include <linux/types.h>

diff --git a/include/linux/dvb/audio.h b/include/linux/dvb/audio.h
index 89412e1..758a48c 100644
--- a/include/linux/dvb/audio.h
+++ b/include/linux/dvb/audio.h
@@ -24,9 +24,8 @@
 #ifndef _DVBAUDIO_H_
 #define _DVBAUDIO_H_
 
-#ifdef __KERNEL__
 #include <linux/types.h>
-#else
+#ifndef __KERNEL__
 #include <stdint.h>
 #endif

Or you guys have some better plan.

Thanks,

--
JSR

WARNING: multiple messages have this Message-ID (diff)
From: Jaswinder Singh Rajput <jaswinder@kernel.org>
To: "H. Peter Anvin" <hpa@kernel.org>
Cc: Sam Ravnborg <sam-uyr5N9Q2VtJg9hUCZPvPmw@public.gmane.org>,
	David Woodhouse <dwmw2@infradead.org>,
	Ingo Molnar <mingo@elte.hu>, x86 maintainers <x86@kernel.org>,
	urs.thuermann-l29pVbxQd1IUtdQbppsyvg@public.gmane.org,
	oliver.hartkopp-l29pVbxQd1IUtdQbppsyvg@public.gmane.org,
	linux-media@vger.kernel.org, netfilter-devel@vger.kernel.org,
	netfilter@vger.kernel.org, bfields@fieldses.org, neilb@suse.de,
	linux-nfs@vger.kernel.org, linux-raid@vger.kernel.org,
	dbrownell@users.sourceforge.net,
	spi-devel-general@lists.sourceforge.net, netdev@vger.kernel.org,
	greg@kroah.com, linux-usb@vger.kernel.org,
	linux-mtd@lists.infradead.org, tiwai@suse.de,
	mchehab@infradead.org, LKML <linux-kernel@vger.kernel.org>,
	Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [GIT PULL -tip] fix 33 make headers_check warnings
Date: Wed, 21 Jan 2009 06:08:39 +0530	[thread overview]
Message-ID: <1232498319.3123.34.camel@localhost.localdomain> (raw)
In-Reply-To: <49725B1E.604@kernel.org>

On Sat, 2009-01-17 at 14:26 -0800, H. Peter Anvin wrote:
> Sam Ravnborg wrote:
> >>>  
> >> That patch looks wrong, and unnecessary. It was fine before.
> > Nope - include/linux/dvb/audio.h failed to include linux/types.h
> > despite the fact that is uses __u32 etc.
> > 
> > But why the _kernel_ should include a userspace header is
> > much more questionable.
> > 
> 
> <stdint.h> is one of a handful of headers provided by gcc itself.
> 

Should I reintroduce my patch to solve this warning of 'make headers_check':
 usr/include/linux/dvb/audio.h:133: found __[us]{8,16,32,64} type without #include <linux/types.h>

diff --git a/include/linux/dvb/audio.h b/include/linux/dvb/audio.h
index 89412e1..758a48c 100644
--- a/include/linux/dvb/audio.h
+++ b/include/linux/dvb/audio.h
@@ -24,9 +24,8 @@
 #ifndef _DVBAUDIO_H_
 #define _DVBAUDIO_H_
 
-#ifdef __KERNEL__
 #include <linux/types.h>
-#else
+#ifndef __KERNEL__
 #include <stdint.h>
 #endif

Or you guys have some better plan.

Thanks,

--
JSR



WARNING: multiple messages have this Message-ID (diff)
From: Jaswinder Singh Rajput <jaswinder-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
To: "H. Peter Anvin" <hpa-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
Cc: Sam Ravnborg <sam-uyr5N9Q2VtJg9hUCZPvPmw@public.gmane.org>,
	David Woodhouse <dwmw2-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>,
	Ingo Molnar <mingo-X9Un+BFzKDI@public.gmane.org>,
	x86 maintainers <x86-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
	urs.thuermann-l29pVbxQd1IUtdQbppsyvg@public.gmane.org,
	oliver.hartkopp-l29pVbxQd1IUtdQbppsyvg@public.gmane.org,
	linux-media-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	netfilter-devel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	netfilter-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	bfields-uC3wQj2KruNg9hUCZPvPmw@public.gmane.org,
	neilb-l3A5Bk7waGM@public.gmane.org,
	linux-nfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-raid-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	dbrownell-Rn4VEauK+AKRv+LV9MX5uipxlwaOVQ5f@public.gmane.org,
	spi-devel-general-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org,
	netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	greg-U8xfFu+wG4EAvxtiuMwx3w@public.gmane.org,
	linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-mtd-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
	tiwai-l3A5Bk7waGM@public.gmane.org,
	mchehab-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org,
	LKML <linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	Andrew Morton
	<akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org>
Subject: Re: [GIT PULL -tip] fix 33 make headers_check warnings
Date: Wed, 21 Jan 2009 06:08:39 +0530	[thread overview]
Message-ID: <1232498319.3123.34.camel@localhost.localdomain> (raw)
In-Reply-To: <49725B1E.604-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>

On Sat, 2009-01-17 at 14:26 -0800, H. Peter Anvin wrote:
> Sam Ravnborg wrote:
> >>>  
> >> That patch looks wrong, and unnecessary. It was fine before.
> > Nope - include/linux/dvb/audio.h failed to include linux/types.h
> > despite the fact that is uses __u32 etc.
> > 
> > But why the _kernel_ should include a userspace header is
> > much more questionable.
> > 
> 
> <stdint.h> is one of a handful of headers provided by gcc itself.
> 

Should I reintroduce my patch to solve this warning of 'make headers_check':
 usr/include/linux/dvb/audio.h:133: found __[us]{8,16,32,64} type without #include <linux/types.h>

diff --git a/include/linux/dvb/audio.h b/include/linux/dvb/audio.h
index 89412e1..758a48c 100644
--- a/include/linux/dvb/audio.h
+++ b/include/linux/dvb/audio.h
@@ -24,9 +24,8 @@
 #ifndef _DVBAUDIO_H_
 #define _DVBAUDIO_H_
 
-#ifdef __KERNEL__
 #include <linux/types.h>
-#else
+#ifndef __KERNEL__
 #include <stdint.h>
 #endif

Or you guys have some better plan.

Thanks,

--
JSR


--
To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

WARNING: multiple messages have this Message-ID (diff)
From: Jaswinder Singh Rajput <jaswinder@kernel.org>
To: "H. Peter Anvin" <hpa@kernel.org>
Cc: Sam Ravnborg <sam@ravnborg.org>,
	David Woodhouse <dwmw2@infradead.org>,
	Ingo Molnar <mingo@elte.hu>, x86 maintainers <x86@kernel.org>,
	urs.thuermann@volkswagen.de, oliver.hartkopp@volkswagen.de,
	linux-media@vger.kernel.org, netfilter-devel@vger.kernel.org,
	netfilter@vger.kernel.org, bfields@fieldses.org, neilb@suse.de,
	linux-nfs@vger.kernel.org, linux-raid@vger.kernel.org,
	dbrownell@users.sourceforge.net,
	spi-devel-general@lists.sourceforge.net, netdev@vger.kernel.org,
	greg@kroah.com, linux-usb@vger.kernel.org,
	linux-mtd@lists.infradead.org, tiwai@suse.de,
	mchehab@infradead.org, LKML <linux-kernel@vger.kernel.org>,
	Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [GIT PULL -tip] fix 33 make headers_check warnings
Date: Wed, 21 Jan 2009 06:08:39 +0530	[thread overview]
Message-ID: <1232498319.3123.34.camel@localhost.localdomain> (raw)
In-Reply-To: <49725B1E.604@kernel.org>

On Sat, 2009-01-17 at 14:26 -0800, H. Peter Anvin wrote:
> Sam Ravnborg wrote:
> >>>  
> >> That patch looks wrong, and unnecessary. It was fine before.
> > Nope - include/linux/dvb/audio.h failed to include linux/types.h
> > despite the fact that is uses __u32 etc.
> > 
> > But why the _kernel_ should include a userspace header is
> > much more questionable.
> > 
> 
> <stdint.h> is one of a handful of headers provided by gcc itself.
> 

Should I reintroduce my patch to solve this warning of 'make headers_check':
 usr/include/linux/dvb/audio.h:133: found __[us]{8,16,32,64} type without #include <linux/types.h>

diff --git a/include/linux/dvb/audio.h b/include/linux/dvb/audio.h
index 89412e1..758a48c 100644
--- a/include/linux/dvb/audio.h
+++ b/include/linux/dvb/audio.h
@@ -24,9 +24,8 @@
 #ifndef _DVBAUDIO_H_
 #define _DVBAUDIO_H_
 
-#ifdef __KERNEL__
 #include <linux/types.h>
-#else
+#ifndef __KERNEL__
 #include <stdint.h>
 #endif

Or you guys have some better plan.

Thanks,

--
JSR



  reply	other threads:[~2009-01-21  0:39 UTC|newest]

Thread overview: 81+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-01-17 20:17 [GIT PULL -tip] fix 33 make headers_check warnings Jaswinder Singh Rajput
2009-01-17 20:17 ` Jaswinder Singh Rajput
2009-01-17 20:17 ` Jaswinder Singh Rajput
2009-01-17 21:37 ` David Woodhouse
2009-01-17 21:37   ` David Woodhouse
2009-01-17 21:37   ` David Woodhouse
2009-01-17 21:37   ` David Woodhouse
2009-01-17 22:04   ` Jan Engelhardt
2009-01-17 22:04     ` Jan Engelhardt
2009-01-17 22:19   ` Sam Ravnborg
2009-01-17 22:19     ` Sam Ravnborg
2009-01-17 22:23     ` David Woodhouse
2009-01-17 22:23       ` David Woodhouse
2009-01-18  2:46       ` Jaswinder Singh Rajput
2009-01-18  2:46         ` Jaswinder Singh Rajput
2009-01-18  2:46         ` Jaswinder Singh Rajput
2009-01-18  2:46         ` Jaswinder Singh Rajput
2009-01-17 22:26     ` H. Peter Anvin
2009-01-17 22:26       ` H. Peter Anvin
2009-01-21  0:38       ` Jaswinder Singh Rajput [this message]
2009-01-21  0:38         ` Jaswinder Singh Rajput
2009-01-21  0:38         ` Jaswinder Singh Rajput
2009-01-21  0:38         ` Jaswinder Singh Rajput
2009-01-23 15:59         ` Jaswinder Singh Rajput
2009-01-23 15:59           ` Jaswinder Singh Rajput
2009-01-23 16:04           ` Jaswinder Singh Rajput
2009-01-23 16:04             ` Jaswinder Singh Rajput
2009-01-23 16:11             ` Jan Engelhardt
2009-01-23 16:11               ` Jan Engelhardt
2009-01-23 16:21               ` Sam Ravnborg
2009-01-23 16:21                 ` Sam Ravnborg
2009-01-23 16:21                 ` Sam Ravnborg
2009-01-23 16:21                 ` Sam Ravnborg
2009-01-23 16:31                 ` Jaswinder Singh Rajput
2009-01-23 16:31                   ` Jaswinder Singh Rajput
2009-01-23 17:09                   ` Sam Ravnborg
2009-01-23 17:09                     ` Sam Ravnborg
2009-01-23 17:09                     ` Sam Ravnborg
2009-01-23 17:09                     ` Sam Ravnborg
2009-01-23 17:28                     ` Jaswinder Singh Rajput
2009-01-23 17:28                       ` Jaswinder Singh Rajput
2009-01-23 21:33               ` H. Peter Anvin
2009-01-23 21:33                 ` H. Peter Anvin
2009-01-23 21:33                 ` H. Peter Anvin
2009-01-23 21:54                 ` Jan Engelhardt
2009-01-23 21:54                   ` Jan Engelhardt
2009-01-23 21:54                   ` Jan Engelhardt
2009-01-23 21:54                   ` Jan Engelhardt
2009-01-23 22:01                   ` H. Peter Anvin
2009-01-23 22:01                     ` H. Peter Anvin
2009-01-18  3:05     ` Jaswinder Singh Rajput
2009-01-18  3:05       ` Jaswinder Singh Rajput
2009-01-18  3:33       ` Kyle McMartin
2009-01-18  3:33         ` Kyle McMartin
2009-01-18  3:38         ` Jaswinder Singh Rajput
2009-01-18  3:38           ` Jaswinder Singh Rajput
2009-01-18  3:38           ` Jaswinder Singh Rajput
2009-01-18  3:38           ` Jaswinder Singh Rajput
2009-01-18  4:18           ` Kyle McMartin
2009-01-18  4:18             ` Kyle McMartin
2009-01-18  4:18             ` Kyle McMartin
2009-01-18  4:18             ` Kyle McMartin
2009-01-23 15:56             ` Jaswinder Singh Rajput
2009-01-23 15:56               ` Jaswinder Singh Rajput
2009-01-23 15:56               ` Jaswinder Singh Rajput
2009-01-23 15:56               ` Jaswinder Singh Rajput
2009-01-18  9:13     ` Ingo Molnar
2009-01-18  9:13       ` Ingo Molnar
2009-01-18 10:10       ` Sam Ravnborg
2009-01-18 10:10         ` Sam Ravnborg
2009-01-18 10:10         ` Sam Ravnborg
2009-01-18 10:10         ` Sam Ravnborg
2009-01-19  0:24 ` Stephen Rothwell
2009-01-19  0:24   ` Stephen Rothwell
2009-01-19  0:24   ` Stephen Rothwell
2009-01-19  0:24   ` Stephen Rothwell
2009-01-19  2:53   ` Jaswinder Singh Rajput
2009-01-19  2:53     ` Jaswinder Singh Rajput
  -- strict thread matches above, loose matches on Subject: below --
2009-01-17 20:17 Jaswinder Singh Rajput
2009-01-17 20:17 Jaswinder Singh Rajput
2009-01-17 20:17 Jaswinder Singh Rajput

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1232498319.3123.34.camel@localhost.localdomain \
    --to=jaswinder@kernel.org \
    --cc=akpm@linux-foundation.org \
    --cc=bfields@fieldses.org \
    --cc=dbrownell@users.sourceforge.net \
    --cc=dwmw2@infradead.org \
    --cc=greg@kroah.com \
    --cc=hpa@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=linux-nfs@vger.kernel.org \
    --cc=linux-raid@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=mchehab@infradead.org \
    --cc=mingo@elte.hu \
    --cc=neilb@suse.de \
    --cc=netdev@vger.kernel.org \
    --cc=netfilter-devel@vger.kernel.org \
    --cc=netfilter@vger.kernel.org \
    --cc=oliver.hartkopp@volkswagen.de \
    --cc=sam@ravnborg.org \
    --cc=spi-devel-general@lists.sourceforge.net \
    --cc=tiwai@suse.de \
    --cc=urs.thuermann@volkswagen.de \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.