From: Peter Zijlstra <peterz@infradead.org>
To: Ingo Molnar <mingo@elte.hu>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
Nick Piggin <npiggin@suse.de>, Hugh Dickins <hugh@veritas.com>,
Thomas Gleixner <tglx@linutronix.de>,
Andrew Morton <akpm@linux-foundation.org>,
L-K <linux-kernel@vger.kernel.org>, linux-mm <linux-mm@kvack.org>,
David Howells <dhowells@redhat.com>
Subject: Re: [PATCH] x86,mm: fix pte_free()
Date: Fri, 23 Jan 2009 18:39:46 +0100 [thread overview]
Message-ID: <1232732387.4850.1.camel@laptop> (raw)
In-Reply-To: <20090123173421.GA30980@elte.hu>
On Fri, 2009-01-23 at 18:34 +0100, Ingo Molnar wrote:
> So i agree with the fix, but the patch does not look right: shouldnt that
> be pgtable_page_dtor(pte), so that we get ->mapping cleared via
> pte_lock_deinit()? (which i guess your intention was here - this probably
> wont even build)
Yeah, I somehow fudged it, already send out a better one. -- One of them
days I guess :-(
WARNING: multiple messages have this Message-ID (diff)
From: Peter Zijlstra <peterz@infradead.org>
To: Ingo Molnar <mingo@elte.hu>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
Nick Piggin <npiggin@suse.de>, Hugh Dickins <hugh@veritas.com>,
Thomas Gleixner <tglx@linutronix.de>,
Andrew Morton <akpm@linux-foundation.org>,
L-K <linux-kernel@vger.kernel.org>, linux-mm <linux-mm@kvack.org>,
David Howells <dhowells@redhat.com>
Subject: Re: [PATCH] x86,mm: fix pte_free()
Date: Fri, 23 Jan 2009 18:39:46 +0100 [thread overview]
Message-ID: <1232732387.4850.1.camel@laptop> (raw)
In-Reply-To: <20090123173421.GA30980@elte.hu>
On Fri, 2009-01-23 at 18:34 +0100, Ingo Molnar wrote:
> So i agree with the fix, but the patch does not look right: shouldnt that
> be pgtable_page_dtor(pte), so that we get ->mapping cleared via
> pte_lock_deinit()? (which i guess your intention was here - this probably
> wont even build)
Yeah, I somehow fudged it, already send out a better one. -- One of them
days I guess :-(
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2009-01-23 17:41 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-23 16:37 [PATCH] x86,mm: fix pte_free() Peter Zijlstra
2009-01-23 16:37 ` Peter Zijlstra
2009-01-23 17:34 ` Ingo Molnar
2009-01-23 17:34 ` Ingo Molnar
2009-01-23 17:39 ` Peter Zijlstra [this message]
2009-01-23 17:39 ` Peter Zijlstra
2009-01-23 17:45 ` Ingo Molnar
2009-01-23 17:45 ` Ingo Molnar
2009-01-26 3:09 ` KOSAKI Motohiro
2009-01-26 3:09 ` KOSAKI Motohiro
2009-01-23 17:34 ` Peter Zijlstra
2009-01-23 17:34 ` Peter Zijlstra
2009-01-23 18:42 ` Hugh Dickins
2009-01-23 18:42 ` Hugh Dickins
2009-01-23 20:15 ` David Howells
2009-01-23 20:15 ` David Howells
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1232732387.4850.1.camel@laptop \
--to=peterz@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=dhowells@redhat.com \
--cc=hugh@veritas.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mingo@elte.hu \
--cc=npiggin@suse.de \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.