All of lore.kernel.org
 help / color / mirror / Atom feed
From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: "Rafael J. Wysocki" <rjw@sisk.pl>
Cc: Jesse Barnes <jbarnes@virtuousgeek.org>,
	Linus Torvalds <torvalds@linux-foundation.org>,
	pm list <linux-pm@lists.linux-foundation.org>,
	LKML <linux-kernel@vger.kernel.org>,
	Linux PCI <linux-pci@vger.kernel.org>
Subject: Re: [PATCH 7/7] PCI PM: Let the core be more careful with respect to drivers using new framework
Date: Thu, 05 Feb 2009 12:18:03 +1100	[thread overview]
Message-ID: <1233796683.4612.37.camel@pasglop> (raw)
In-Reply-To: <200902050147.02632.rjw@sisk.pl>


> I don't know about ppc, but on x86 the pcibios hook is only supposed to
> disable the device's interrupt link.

Right now on ppc, I may disable the clocks too, but then:

 - As soon as you have implemented the new scheme, I'll replace all that
with using the same hooks as ACPI so that won't be an issue anymore

 - Today, it's probably a non issue too because none of the devices for
which I have that sort of manual clock control also shares interrupts.

> Potentially, calling into the AML interpreter.

Right, but we are fixing that anyway with the noirq phase being AML safe
by no ? :-)
 
> When we implement the changes discussed in the "PCI PM: Restore standard
> config registers of all devices early" thread, that part will end up in
> suspend_noirq.

Yup.

Cheers,
Ben.


  parent reply	other threads:[~2009-02-05  1:19 UTC|newest]

Thread overview: 57+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-02-04  0:54 [PATCH 0/7] PCI PM: Fixes and refinements Rafael J. Wysocki
2009-02-04  0:56 ` [PATCH 1/7] PCI PM: Fix handling of devices without drivers Rafael J. Wysocki
2009-02-04  1:53   ` Benjamin Herrenschmidt
2009-02-04  1:53   ` Benjamin Herrenschmidt
2009-02-04  2:23   ` Linus Torvalds
2009-02-04  2:49     ` Benjamin Herrenschmidt
2009-02-04 12:12       ` Rafael J. Wysocki
2009-02-04 12:12       ` Rafael J. Wysocki
2009-02-04  2:49     ` Benjamin Herrenschmidt
2009-02-04 12:10     ` Rafael J. Wysocki
2009-02-04 12:10     ` Rafael J. Wysocki
2009-02-04  2:23   ` Linus Torvalds
2009-02-04  0:56 ` Rafael J. Wysocki
2009-02-04  0:57 ` [PATCH 2/7] PCI PM: Check if the state has been saved before trying to restore it Rafael J. Wysocki
2009-02-04  0:57 ` Rafael J. Wysocki
2009-02-04  1:54   ` Benjamin Herrenschmidt
2009-02-04  1:54   ` Benjamin Herrenschmidt
2009-02-04  0:59 ` [PATCH 3/7] PCI PM: Fix saving of device state in pci_legacy_suspend Rafael J. Wysocki
2009-02-04  0:59 ` Rafael J. Wysocki
2009-02-04  1:56   ` Benjamin Herrenschmidt
2009-02-04 10:14     ` Frans Pop
2009-02-04 10:14     ` Frans Pop
2009-02-04 21:38       ` Benjamin Herrenschmidt
2009-02-04 21:38       ` Benjamin Herrenschmidt
2009-02-04 21:53         ` Frans Pop
2009-02-04 21:53         ` Frans Pop
2009-02-04 21:56         ` Linus Torvalds
2009-02-04 21:56         ` Linus Torvalds
2009-02-05  0:40           ` Benjamin Herrenschmidt
2009-02-05  0:40           ` Benjamin Herrenschmidt
2009-02-05  0:57             ` Michael Ellerman
2009-02-05  1:29               ` Benjamin Herrenschmidt
2009-02-05  1:29               ` Benjamin Herrenschmidt
2009-02-05  2:58                 ` Michael Ellerman
2009-02-05  2:58                 ` Michael Ellerman
2009-02-05  4:06                   ` Benjamin Herrenschmidt
2009-02-05  4:06                   ` Benjamin Herrenschmidt
2009-02-05  0:57             ` Michael Ellerman
2009-02-04  1:56   ` Benjamin Herrenschmidt
2009-02-04  1:00 ` [PATCH 4/7] PCI PCIe portdrv: Simplify suspend and resume Rafael J. Wysocki
2009-02-04  1:00 ` Rafael J. Wysocki
2009-02-04  1:01 ` [PATCH 5/7] PCI PM: Do not disable and enable bridges during suspend-resume Rafael J. Wysocki
2009-02-04  1:01 ` Rafael J. Wysocki
2009-02-04  1:02 ` [PATCH 6/7] PCI PM: Read power state from device after trying to change it on resume Rafael J. Wysocki
2009-02-04  1:02 ` Rafael J. Wysocki
2009-02-04  1:09 ` [PATCH 7/7] PCI PM: Let the core be more careful with respect to drivers using new framework Rafael J. Wysocki
2009-02-04  2:05   ` Benjamin Herrenschmidt
2009-02-04  2:05   ` Benjamin Herrenschmidt
2009-02-05  0:47     ` Rafael J. Wysocki
2009-02-05  0:47     ` Rafael J. Wysocki
2009-02-05  1:18       ` Benjamin Herrenschmidt
2009-02-05  1:18       ` Benjamin Herrenschmidt [this message]
2009-02-04  1:09 ` Rafael J. Wysocki
2009-02-05  1:23 ` [PATCH 0/7] PCI PM: Fixes and refinements Jesse Barnes
2009-02-05  1:48   ` Rafael J. Wysocki
2009-02-05  1:48   ` Rafael J. Wysocki
2009-02-05  1:23 ` Jesse Barnes

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1233796683.4612.37.camel@pasglop \
    --to=benh@kernel.crashing.org \
    --cc=jbarnes@virtuousgeek.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=linux-pm@lists.linux-foundation.org \
    --cc=rjw@sisk.pl \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.