All of lore.kernel.org
 help / color / mirror / Atom feed
From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Gaudenz Steinlin <gaudenz@soziologie.ch>
Cc: linux-kernel@vger.kernel.org, "Rafael J. Wysocki" <rjw@sisk.pl>,
	Andrew Morton <akpm@linux-foundation.org>
Subject: Re: commit "radeonfb: Fix resume from D3Cold on some platforms" breaks resume from RAM on PowerBook
Date: Thu, 05 Mar 2009 13:25:20 +1100	[thread overview]
Message-ID: <1236219920.7260.6.camel@pasglop> (raw)
In-Reply-To: <20090304083859.GB6889@soziologie.ch>

On Wed, 2009-03-04 at 09:38 +0100, Gaudenz Steinlin wrote:
> Hi Benjamin
> 
> The commit 1fb25cb8b83e85f5bf1a4adb3c9a254c4ce92405 "radeonfb: Fix resume 
> from D3Cold on some platforms" breaks resume from suspend to RAM on my
> PowerBook (Model PowerBook5,8 with ATI Mobility Radeon 9600 M10).
> 
> On resume the pulsing led indicating sleep just changes to solid white
> and nothing else happens. 
> 
> Reverting this commit on top of the current Linus' tree fixes resume.

Ok, so after some tests here on what appear to the the exact same
machine...

I did the commit specifically to -fix- a regression due to upstream
changes, ie, for me it doesn't work without that commit. That is very
weird.

In fact, I just tried also with AGP and DRM enabled with X wobbly
windows etc... and it's working just fine.

I know that the early resume hack I have in there for powerbooks might
be a bit fishy, so please try without it (according to my previous email
on that matter).

Please let me know if that makes a difference.

Cheers,
Ben.



  parent reply	other threads:[~2009-03-05  2:26 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-03-04  8:38 commit "radeonfb: Fix resume from D3Cold on some platforms" breaks resume from RAM on PowerBook Gaudenz Steinlin
2009-03-04 23:22 ` Benjamin Herrenschmidt
2009-03-05 10:25   ` Gaudenz Steinlin
2009-03-05  2:25 ` Benjamin Herrenschmidt [this message]
2009-03-05 12:59   ` Gaudenz Steinlin
2009-03-06  5:50     ` Benjamin Herrenschmidt
2009-03-06  9:09       ` Gaudenz Steinlin
2009-03-06  9:57         ` Benjamin Herrenschmidt
2009-03-06 11:41           ` Gaudenz Steinlin
2009-03-06 21:26             ` Benjamin Herrenschmidt
2009-03-09 22:37             ` Benjamin Herrenschmidt
2009-03-10  9:32               ` Rafael J. Wysocki
2009-03-10 15:01                 ` Gaudenz Steinlin
2009-03-10 20:58                   ` Benjamin Herrenschmidt
2009-03-10 21:27                     ` Gaudenz Steinlin
2009-03-10 21:30               ` Gaudenz Steinlin
2009-03-10 22:07                 ` Benjamin Herrenschmidt
2009-03-10 23:04                   ` Rafael J. Wysocki
2009-03-11  0:34                     ` Benjamin Herrenschmidt
2009-03-09 22:49             ` Benjamin Herrenschmidt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1236219920.7260.6.camel@pasglop \
    --to=benh@kernel.crashing.org \
    --cc=akpm@linux-foundation.org \
    --cc=gaudenz@soziologie.ch \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rjw@sisk.pl \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.